[ICE-9338] Resource coalescing omitting fileentry.js - ICEsoft JIRA Issue Tracker

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 3.3, EE-3.3.0.GA
Fix Version/s: EE-3.3.0.GA_P01, 4.0.BETA, 4.0
Component/s: Framework
Labels:
None
Environment:
Liferay portal 6.1.1 on Tomcat 7.0.27 with Liferay faces bridge 3.1.2 and ICEfaces 3.3 EE tag branch HEAD

Assignee Priority:
P1

Description

Having an ICEfaces ACE FileEntry portlet on its own works fine with coalescing. The included fileentry.js code can be readily found. But, if another ACE component sample portlet is added, for example Accordion, and the display is refreshed, then there is this exception:

Uncaught TypeError: Cannot call method 'captureFormOnsubmit' of undefined

This is because the ice.ace.fileentry.captureFormOnsubmit function is not found since the file it comes in is not included:

icefaces/ace/component/resources/icefaces.ace/fileentry/fileEntry.js

This might be related to ~~ICE-9263~~.

Issue Links

blocks

ICE-9433 Compat broken theme image links in CSS

Closed

depends on

ICE-9263 Resource coalescing does not work in a portlet environment

Closed

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Deryk Sinotte added a comment - 11/Jun/13 5:26 PM - edited

Fixed most of the outstanding issues with portlets by modifying the CoalescingResourceHandler to use the proper session scope for portlets.

There is still an outstanding problem with the Context Menu example in that they fail when included on the same page with the File Entry example. The Context Menu examples work fine in any of the following scenarios:

they are on a page by themselves
they are on a page with other portlets (except File Entry)
coalescing is turned off

So it's very specific to the combination of Context Menu + File Entry + coalescing together.

Show

Deryk Sinotte added a comment - 11/Jun/13 5:26 PM - edited Fixed most of the outstanding issues with portlets by modifying the CoalescingResourceHandler to use the proper session scope for portlets. There is still an outstanding problem with the Context Menu example in that they fail when included on the same page with the File Entry example. The Context Menu examples work fine in any of the following scenarios: they are on a page by themselves they are on a page with other portlets (except File Entry) coalescing is turned off So it's very specific to the combination of Context Menu + File Entry + coalescing together.

5 older comments

Hide

Permalink

Mircea Toma added a comment - 16/Jul/13 3:39 PM

Backported fix to EE branch.

Show

Mircea Toma added a comment - 16/Jul/13 3:39 PM Backported fix to EE branch.

Hide

Permalink

Carmen Cristurean added a comment - 17/Jul/13 11:43 AM - edited

Showcase tests fail on icefaces3/trunk rev# 36979 or Jenkins Build#1400:
There is a JS error that starts occurring in Firefox21 when navigating to various demos in showcase:

TypeError: Ice.DnD is undefined
http://localhost:8080/showcase/javax.faces.resource/coalesced.js.jsf?ln=ice.core&dgst=r62d0r
Line 12695

At the same time, the Firefox browser memory increases continuously and eventually the browser crashes after a while, if continuing running the tests.

Turning the coalescing off, the errors could not be reproduced any longer.

Show

Carmen Cristurean added a comment - 17/Jul/13 11:43 AM - edited Showcase tests fail on icefaces3/trunk rev# 36979 or Jenkins Build#1400: There is a JS error that starts occurring in Firefox21 when navigating to various demos in showcase: TypeError: Ice.DnD is undefined http://localhost:8080/showcase/javax.faces.resource/coalesced.js.jsf?ln=ice.core&dgst=r62d0r Line 12695 At the same time, the Firefox browser memory increases continuously and eventually the browser crashes after a while, if continuing running the tests. Turning the coalescing off, the errors could not be reproduced any longer.

Hide

Permalink

Mircea Toma added a comment - 17/Jul/13 5:16 PM

The browser memory is growing because the coalesced files grow while the application is used.

Show

Mircea Toma added a comment - 17/Jul/13 5:16 PM The browser memory is growing because the coalesced files grow while the application is used.

Hide

Permalink

Mircea Toma added a comment - 17/Jul/13 5:17 PM

Implement hashCode method for the CoalescingResource.Info class to make the hash set used for merging resources is effective when removeAll method is invoked on the set.

Show

Mircea Toma added a comment - 17/Jul/13 5:17 PM Implement hashCode method for the CoalescingResource.Info class to make the hash set used for merging resources is effective when removeAll method is invoked on the set.

Hide

Permalink

Liana Munroe added a comment - 22/Jul/13 11:21 AM

Was not able to reproduce in FF 21, IE 9, or Chrome 28 in trunk, revision #37037.

Show

Liana Munroe added a comment - 22/Jul/13 11:21 AM Was not able to reproduce in FF 21, IE 9, or Chrome 28 in trunk, revision #37037.

People

Assignee:

Mircea Toma

Reporter:

Mark Collette

Votes:

0 Vote for this issue

Watchers:

6 Start watching this issue

Dates

Created:

10/Jun/13 7:50 PM

Updated:

14/Nov/14 5:18 PM

Resolved:

17/Jul/13 5:17 PM