ICEfaces
  1. ICEfaces
  2. ICE-9304

New ace:growlMessages component

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0.BETA, 4.0
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      ICEfaces 3, ACE components
    • Assignee Priority:
      P1
    • Affects:
      Documentation (User Guide, Ref. Guide, etc.), Sample App./Tutorial

      Description

      Add a new ace:growlMessages component that can be used in place of the standard h:messages or ace:messages components.

      The Growl Messages component will provide the user with a popup notification panel, similar to the OS X Growl component.

      There are several jQuery Growl components that we could leverage for this functionality, including this one:
      http://plugins.jquery.com/jgrowl/

      1. screenshot-01.png
        267 kB
      2. screenshot-02.png
        279 kB
      3. screenshot-03.png
        348 kB
      4. screenshot-04.png
        322 kB

        Activity

        Ken Fyten created issue -
        Ken Fyten made changes -
        Field Original Value New Value
        Assignee yip.ng [ yip.ng ]
        Fix Version/s 3.4 [ 10770 ]
        Affects Documentation (User Guide, Ref. Guide, etc.),Sample App./Tutorial [ 10003, 10001 ]
        Assignee Priority P1 [ 10010 ]
        Hide
        yip.ng added a comment -

        First iteration: video.

        Show
        yip.ng added a comment - First iteration: video .
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #35921 Wed Jun 05 11:24:57 MDT 2013 yip.ng ICE-9304: New ace:growlMessages component.
        Files Changed
        Commit graph ADD /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/growlmessages/jquery.jgrowl.js
        Commit graph ADD /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/growlmessages/jquery.jgrowl.css
        Commit graph ADD /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/growlmessages
        yip.ng made changes -
        Attachment screenshot-01.png [ 16019 ]
        Hide
        yip.ng added a comment -

        ThemeRoller styling done. See screenshot-01.

        Show
        yip.ng added a comment - ThemeRoller styling done. See screenshot-01 .
        Hide
        Ken Fyten added a comment -

        It would be useful to be able to configure the message stickiness on per-Severity basis. So for each Severity you can configure if it should be sticky or not.

        stickyConfig = "warn, error, fatal" (Default)
        stickyConfig = "all"
        stickyConfig = "none"

        Show
        Ken Fyten added a comment - It would be useful to be able to configure the message stickiness on per-Severity basis. So for each Severity you can configure if it should be sticky or not. stickyConfig = "warn, error, fatal" (Default) stickyConfig = "all" stickyConfig = "none"
        Hide
        Ken Fyten added a comment -

        Text label for "Close All" needs to be configurable so it can be localized.

        Show
        Ken Fyten added a comment - Text label for "Close All" needs to be configurable so it can be localized.
        yip.ng made changes -
        Attachment screenshot-02.png [ 16032 ]
        yip.ng made changes -
        Attachment screenshot-03.png [ 16033 ]
        Hide
        yip.ng added a comment - - edited
        • Message severity icon added: screenshot-02. The individual message close "button" was also just text, but was easier to change into an icon because there is a parameter facilitating that.
        • Parameters exposed as attributes: screenshot-03. Note that they seem to apply globally to every message. Can't specify for individual message? API doc often says, "This must be changed in the defaults before the startup method is called." Need to study code deeper to see if sticky can be specified and done individually.
        • Animation: video.
        Show
        yip.ng added a comment - - edited Message severity icon added: screenshot-02 . The individual message close "button" was also just text, but was easier to change into an icon because there is a parameter facilitating that. Parameters exposed as attributes: screenshot-03 . Note that they seem to apply globally to every message. Can't specify for individual message? API doc often says, "This must be changed in the defaults before the startup method is called." Need to study code deeper to see if sticky can be specified and done individually. Animation: video .
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #36190 Wed Jun 12 15:54:25 MDT 2013 yip.ng ICE-9304: New ace:growlMessages component.
        Files Changed
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/growlmessages/jquery.jgrowl.js
        Commit graph ADD /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/growlmessages/GrowlMessagesRenderer.java
        Commit graph ADD /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/growlmessages/GrowlMessagesMeta.java
        Commit graph ADD /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/growlmessages/growlmessages.js
        Commit graph ADD /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/growlmessages/growlmessages.css
        Commit graph ADD /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/growlmessages
        Commit graph ADD /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/growlmessages/GrowlMessages.java
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/build.xml
        yip.ng made changes -
        Attachment screenshot-04.png [ 16040 ]
        Hide
        yip.ng added a comment -
        • Attribute renaming done and re-tested. New TLD doc: screenshot-04.png.
        • autoHide(sticky) applied to individual message based on specified severity: see TLD doc: screenshot-04.png. Video: autoHide="warn".
        • According to jGrowl change log, multiple growl containers possible. Need to figure out how if we decide to do it.

        A: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\resources\icefaces.ace\growlmessages#35921
        A: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\resources\icefaces.ace\growlmessages\jquery.jgrowl.css#35921
        A: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\resources\icefaces.ace\growlmessages\jquery.jgrowl.js#35921

        M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\build.xml#36190
        A: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\growlmessages#36190
        A: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\resources\icefaces.ace\growlmessages\growlmessages.css#36190
        A: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\growlmessages\GrowlMessages.java#36190
        A: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\resources\icefaces.ace\growlmessages\growlmessages.js#36190
        A: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\growlmessages\GrowlMessagesMeta.java#36190
        A: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\growlmessages\GrowlMessagesRenderer.java#36190
        M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\resources\icefaces.ace\growlmessages\jquery.jgrowl.js#36190

        Show
        yip.ng added a comment - Attribute renaming done and re-tested. New TLD doc: screenshot-04.png . autoHide(sticky) applied to individual message based on specified severity: see TLD doc: screenshot-04.png . Video: autoHide="warn" . According to jGrowl change log, multiple growl containers possible. Need to figure out how if we decide to do it. A: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\resources\icefaces.ace\growlmessages#35921 A: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\resources\icefaces.ace\growlmessages\jquery.jgrowl.css#35921 A: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\resources\icefaces.ace\growlmessages\jquery.jgrowl.js#35921 M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\build.xml#36190 A: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\growlmessages#36190 A: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\resources\icefaces.ace\growlmessages\growlmessages.css#36190 A: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\growlmessages\GrowlMessages.java#36190 A: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\resources\icefaces.ace\growlmessages\growlmessages.js#36190 A: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\growlmessages\GrowlMessagesMeta.java#36190 A: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\growlmessages\GrowlMessagesRenderer.java#36190 M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\resources\icefaces.ace\growlmessages\jquery.jgrowl.js#36190
        Hide
        yip.ng added a comment -

        Showcase demo done.

        M: C:\svn\ossrepo\icefaces3\trunk\icefaces\samples\showcase\showcase\src\main\java\org\icefaces\samples\showcase\view\navigation\AceMenu.java#36233
        A: C:\svn\ossrepo\icefaces3\trunk\icefaces\samples\showcase\showcase\src\main\java\org\icefaces\samples\showcase\example\ace\growlmessages#36233
        A: C:\svn\ossrepo\icefaces3\trunk\icefaces\samples\showcase\showcase\src\main\webapp\resources\examples\ace\growlmessages#36233
        M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\resources\icefaces.ace\growlmessages\growlmessages.js#36233
        A: C:\svn\ossrepo\icefaces3\trunk\icefaces\samples\showcase\showcase\src\main\webapp\resources\examples\ace\growlmessages\growlmessages.xhtml#36233
        A: C:\svn\ossrepo\icefaces3\trunk\icefaces\samples\showcase\showcase\src\main\java\org\icefaces\samples\showcase\example\ace\growlmessages\GrowlMessagesBean.java#36233
        M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\growlmessages\GrowlMessagesMeta.java#36233
        A: C:\svn\ossrepo\icefaces3\trunk\icefaces\samples\showcase\showcase\src\main\java\org\icefaces\samples\showcase\ace\documentationResources\GrowlMessagesResources.java#36233
        M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\resources\icefaces.ace\growlmessages\jquery.jgrowl.js#36233
        M: C:\svn\ossrepo\icefaces3\trunk\icefaces\samples\showcase\showcase\src\main\resources\org\icefaces\samples\showcase\view\resources\messages.properties#36233
        M: C:\svn\ossrepo\icefaces3\trunk\icefaces\samples\showcase\showcase\src\main\webapp\resources\ice.samples.showcase\override_header.css#36233

        Show
        yip.ng added a comment - Showcase demo done. M: C:\svn\ossrepo\icefaces3\trunk\icefaces\samples\showcase\showcase\src\main\java\org\icefaces\samples\showcase\view\navigation\AceMenu.java#36233 A: C:\svn\ossrepo\icefaces3\trunk\icefaces\samples\showcase\showcase\src\main\java\org\icefaces\samples\showcase\example\ace\growlmessages#36233 A: C:\svn\ossrepo\icefaces3\trunk\icefaces\samples\showcase\showcase\src\main\webapp\resources\examples\ace\growlmessages#36233 M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\resources\icefaces.ace\growlmessages\growlmessages.js#36233 A: C:\svn\ossrepo\icefaces3\trunk\icefaces\samples\showcase\showcase\src\main\webapp\resources\examples\ace\growlmessages\growlmessages.xhtml#36233 A: C:\svn\ossrepo\icefaces3\trunk\icefaces\samples\showcase\showcase\src\main\java\org\icefaces\samples\showcase\example\ace\growlmessages\GrowlMessagesBean.java#36233 M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\growlmessages\GrowlMessagesMeta.java#36233 A: C:\svn\ossrepo\icefaces3\trunk\icefaces\samples\showcase\showcase\src\main\java\org\icefaces\samples\showcase\ace\documentationResources\GrowlMessagesResources.java#36233 M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\resources\icefaces.ace\growlmessages\jquery.jgrowl.js#36233 M: C:\svn\ossrepo\icefaces3\trunk\icefaces\samples\showcase\showcase\src\main\resources\org\icefaces\samples\showcase\view\resources\messages.properties#36233 M: C:\svn\ossrepo\icefaces3\trunk\icefaces\samples\showcase\showcase\src\main\webapp\resources\ice.samples.showcase\override_header.css#36233
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #36233 Fri Jun 14 11:37:01 MDT 2013 yip.ng ICE-9304: New ace:growlMessages component.
        Files Changed
        Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/java/org/icefaces/samples/showcase/view/navigation/AceMenu.java
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/growlmessages/jquery.jgrowl.js
        Commit graph ADD /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/java/org/icefaces/samples/showcase/example/ace/growlmessages
        Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/ice.samples.showcase/override_header.css
        Commit graph ADD /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/java/org/icefaces/samples/showcase/ace/documentationResources/GrowlMessagesResources.java
        Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/resources/org/icefaces/samples/showcase/view/resources/messages.properties
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/growlmessages/GrowlMessagesMeta.java
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/growlmessages/growlmessages.js
        Commit graph ADD /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/growlmessages/growlmessages.xhtml
        Commit graph ADD /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/growlmessages
        Commit graph ADD /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/java/org/icefaces/samples/showcase/example/ace/growlmessages/GrowlMessagesBean.java
        Ken Fyten made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Ken Fyten added a comment -

        On 2013-10-07, at 11:41 AM, Cruz Miraback wrote:

        If the validator/required message contains single quotation marks (' ') a JS error occurs and the component does not display. The default message for f:validateLength tag contains single quotation marks so if using the default message with this tag the component will not render.

        In IE:

        Message: Expected '}'
        Line: 1
        Char: 299
        Code: 0
        URI: http://localhost:8080/growlMessages/growlMessagesDynamic.jsf

        In Firefox:

        SyntaxError: missing } after property list
        http://localhost:8080/growlMessages/growlMessagesDynamic.jsf
        Line 0

        Show
        Ken Fyten added a comment - On 2013-10-07, at 11:41 AM, Cruz Miraback wrote: If the validator/required message contains single quotation marks (' ') a JS error occurs and the component does not display. The default message for f:validateLength tag contains single quotation marks so if using the default message with this tag the component will not render. In IE: Message: Expected '}' Line: 1 Char: 299 Code: 0 URI: http://localhost:8080/growlMessages/growlMessagesDynamic.jsf In Firefox: SyntaxError: missing } after property list http://localhost:8080/growlMessages/growlMessagesDynamic.jsf Line 0
        Ken Fyten made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Assignee yip.ng [ yip.ng ] Arturo Zambrano [ artzambrano ]
        Hide
        Cruz Miraback added a comment -

        Creating a test that contains a custom FacesMessage and in the summary/detail of that message I have an img element that points to an image. If escape=true then we would expect to see the HTML markup and not the image, and if escape=false then we would expect to see the actual image. Currently it isn't working as expected, the image will display regardless of the escape attribute value, so I think this may be a bug.

        Show
        Cruz Miraback added a comment - Creating a test that contains a custom FacesMessage and in the summary/detail of that message I have an img element that points to an image. If escape=true then we would expect to see the HTML markup and not the image, and if escape=false then we would expect to see the actual image. Currently it isn't working as expected, the image will display regardless of the escape attribute value, so I think this may be a bug.
        Hide
        Arturo Zambrano added a comment -

        Committed fix for 'escape' attribute at revision 38555. Now, escape=true should show the markup in the test above, and escape=false should show the image.

        Show
        Arturo Zambrano added a comment - Committed fix for 'escape' attribute at revision 38555. Now, escape=true should show the markup in the test above, and escape=false should show the image.
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #38555 Tue Oct 08 12:20:15 MDT 2013 art.zambrano ICE-9304 fixed 'escape' attribute
        Files Changed
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/growlmessages/GrowlMessagesRenderer.java
        Hide
        Arturo Zambrano added a comment - - edited

        I think there's no harm in having redundant attribute values in general. App developers can use whatever makes the most sense in their minds, instead of having to learn that autoHide=fatal is the same as autoHide=true. We'll leave autoHide=fatal for the sake of completeness.

        Show
        Arturo Zambrano added a comment - - edited I think there's no harm in having redundant attribute values in general. App developers can use whatever makes the most sense in their minds, instead of having to learn that autoHide=fatal is the same as autoHide=true. We'll leave autoHide=fatal for the sake of completeness.
        Arturo Zambrano made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Cruz Miraback added a comment -

        Thanks, confirmed JS error and escape attribute are fixed at revision# 38556 in Firefox24, Chrome30, IE10.

        Show
        Cruz Miraback added a comment - Thanks, confirmed JS error and escape attribute are fixed at revision# 38556 in Firefox24, Chrome30, IE10.
        Ken Fyten made changes -
        Fix Version/s 4.0 [ 11382 ]
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Arturo Zambrano
            Reporter:
            Ken Fyten
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: