ICEfaces
  1. ICEfaces
  2. ICE-9303

ICEfaces JS extends native prototypes overwriting expected behaviours

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.3
    • Fix Version/s: 4.0.BETA, 4.0
    • Component/s: Framework
    • Labels:
      None
    • Environment:
      *
    • Assignee Priority:
      P1

      Description

      As a compatibility and convenience measure, ICEfaces extends the prototypes of native JS types with a variety of helper functions and shims for advanced ECMAscript features.

      However the extend ends up overwriting functions that have existing native implementations. This is generally discouraged for a few of reasons, primarily that this has a global effect, and that the overwriting implementation may not provide the expected functionality to 3rd party scripts, or that the overwriting implementation is slower due to being evaluated JS versus native C JSVM code.

      I encountered this issue when attempting to use Array.prototype.filter to filter a NodeList as recommended by MDN documentation and it broke due to our implementations assumptions. As higher-order JS techniques like this become more popular we run greater risk of being incompatible.

      A naive change, if possible would be to make extend not overwrite. If extend is used with the expectation of overwriting throughout or code this may not be possible however. In that case we may need to alter the calls to extend prototypes to indicate explicitly not to overwrite.

        Issue Links

          Activity

          Repository Revision Date User Message
          ICEsoft Public SVN Repository #37009 Wed Jul 17 17:44:32 MDT 2013 nils.lundquist ICE-9303 - Hack for Prototype Enumerable to avoid deep copy infinite loop.
          Files Changed
          Commit graph MODIFY /icefaces3/trunk/icefaces/compat/core/src/main/javascript/prototype/prototype.js
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #36972 Tue Jul 16 12:16:28 MDT 2013 nils.lundquist Revert: MOBI-832 - convert all uses of Array.each, Array.filter and Array.map to for loops to avoid prototype incompatibility
           
           Incompatibility with Prototype resolved with resolution of ICE-9303.
          Files Changed
          Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/component/resources/org.icefaces.component.util/component.js
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #36971 Tue Jul 16 12:14:11 MDT 2013 nils.lundquist ICE-9303 - Prevent Prototype from overwriting native implementations.
          Files Changed
          Commit graph MODIFY /icefaces3/trunk/icefaces/compat/core/src/main/javascript/prototype/prototype.js
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #35644 Wed May 29 14:43:01 MDT 2013 nils.lundquist Revert: ICE-9109 - Prevented prototype extension from overwriting existing native implementations. Pushed to 3.4. Future effort captured in ICE-9303.
          Files Changed
          Commit graph MODIFY /icefaces3/trunk/icefaces/compat/core/src/main/javascript/prototype/prototype.js

            People

            • Assignee:
              Nils Lundquist
              Reporter:
              Nils Lundquist
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: