ICEfaces
  1. ICEfaces
  2. ICE-9258

ace:dataTable - Add new "rowClick" and "rowDblClick" ace:ajax events

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0.BETA, EE-3.3.0.GA_P02, 4.0
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      ICEfaces 3.x ace:dataTable
    • Assignee Priority:
      P2
    • Salesforce Case Reference:
    • Affects:
      Documentation (User Guide, Ref. Guide, etc.)

      Description

      Users would like to ability to configure the ace:dataTable to say, use single-click for row selection, and also add a double-click listener to the row that would perform a different action, such as popup an edit dialog, etc.

      In order to facilitate this, we should add the following new client events / ace:ajax events to ace:dataTable:

      * 'rowClick' - fires when the primary mouse button is clicked once over a table row.
      * "rowDblClick" - fires when the primary mouse button is double-clicked over a table row.

      In to support the "rowDblClick" detection, a technique similar to that used by the ace:list may be required.

      Note that it is also foreseeable that the application may want to first select the double-clicked row, then perform some action on it. Presumably, this could be implemented by the application "rowDblClick" event handler itself, and not in the ace:dataTable component (unless row selection is already configured for double-click).

        Activity

        Ken Fyten created issue -
        Ken Fyten made changes -
        Field Original Value New Value
        Assignee Nils Lundquist [ nils.lundquist ]
        Fix Version/s 3.4 [ 10770 ]
        Affects Documentation (User Guide, Ref. Guide, etc.) [ 10003 ]
        Assignee Priority P2 [ 10011 ]
        Tyler Johnson made changes -
        Salesforce Case Reference 5007000000T6ablAAB
        Tyler Johnson made changes -
        Fix Version/s EE-3.3.0.GA [ 10572 ]
        Nils Lundquist made changes -
        Fix Version/s EE-3.3.0.GA [ 10572 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #35930 Wed Jun 05 11:51:57 MDT 2013 nils.lundquist ICE-9258 - Added DataTable cellClick & cellDoubleClick events. Refactored DataTable row/cell click event binding.
        Files Changed
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/datatable/DataTableRenderer.java
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/datatable/datatable.css
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/datatable/DataTableMeta.java
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/datatable/datatable.js
        Hide
        Nils Lundquist added a comment -

        Revision #35930
        Committed by nils.lundquist
        2 minutes ago
        ICE-9258 - Added DataTable cellClick & cellDoubleClick events. Refactored DataTable row/cell click event binding.

        Show
        Nils Lundquist added a comment - Revision #35930 Committed by nils.lundquist 2 minutes ago ICE-9258 - Added DataTable cellClick & cellDoubleClick events. Refactored DataTable row/cell click event binding.
        Nils Lundquist made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Nils Lundquist added a comment - - edited

        Reopening issue to add row/cell context info to ace:ajax events.

        Show
        Nils Lundquist added a comment - - edited Reopening issue to add row/cell context info to ace:ajax events.
        Nils Lundquist made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #35938 Wed Jun 05 14:34:15 MDT 2013 nils.lundquist ICE-9258 - Added reduce ECMAScript 5 shim
        Files Changed
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/util/util.js
        Hide
        Nils Lundquist added a comment -

        Revision #36191
        Committed by nils.lundquist
        A minute ago
        ICE-9258 - Added DataTableCellClickEvent AjaxBehaviourEvent subclass.

        Show
        Nils Lundquist added a comment - Revision #36191 Committed by nils.lundquist A minute ago ICE-9258 - Added DataTableCellClickEvent AjaxBehaviourEvent subclass.
        Nils Lundquist made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #36191 Wed Jun 12 16:21:20 MDT 2013 nils.lundquist ICE-9258 - Added DataTableCellClickEvent AjaxBehaviourEvent subclass.
        Files Changed
        Commit graph ADD /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/event/DataTableCellClickEvent.java
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/datatable/DataTable.java
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/datatable/datatable.js
        Hide
        Nils Lundquist added a comment -

        The functionality added as part of this JIRA will have to have extensive tests added to confirm:

        • the right column / row are always part of the DataTableCellClickEvent.
        • no double submits occur when using single & double click
        • standard ace:ajax testing
        Show
        Nils Lundquist added a comment - The functionality added as part of this JIRA will have to have extensive tests added to confirm: the right column / row are always part of the DataTableCellClickEvent. no double submits occur when using single & double click standard ace:ajax testing
        Hide
        Ken Fyten added a comment -
        • Optimize so delay is only used if double click event is listened for.
        • Add new showcase demo to show single click row selection mode with dbl click listener to show popup.
        Show
        Ken Fyten added a comment - Optimize so delay is only used if double click event is listened for. Add new showcase demo to show single click row selection mode with dbl click listener to show popup.
        Ken Fyten made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #36293 Wed Jun 19 09:22:29 MDT 2013 nils.lundquist ICE-9258 - Added showcase example of DataTable ajax row click behaviours.
        Files Changed
        Commit graph ADD /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/dataTable/dataTableClick.xhtml
        Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/resources/org/icefaces/samples/showcase/view/resources/messages.properties
        Commit graph ADD /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/java/org/icefaces/samples/showcase/example/ace/dataTable/DataTableClick.java
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/datatable/datatable.js
        Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/java/org/icefaces/samples/showcase/example/ace/dataTable/DataTableBean.java
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/datatable/DataTableRowRenderer.java
        Hide
        Nils Lundquist added a comment -

        Revision #36293
        Committed by nils.lundquist
        A minute ago
        ICE-9258 - Added showcase example of DataTable ajax row click behaviours.

        Show
        Nils Lundquist added a comment - Revision #36293 Committed by nils.lundquist A minute ago ICE-9258 - Added showcase example of DataTable ajax row click behaviours.
        Nils Lundquist made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #36597 Mon Jul 08 11:09:01 MDT 2013 nils.lundquist ICE-9258 - Altered DataTable event unloading to match refactored click logic.
        Files Changed
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/datatable/datatable.js
        Ken Fyten made changes -
        Fix Version/s EE-3.3.0.GA_P02 [ 11371 ]
        Ken Fyten made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Assignee Nils Lundquist [ nils.lundquist ] Arturo Zambrano [ artzambrano ]
        Hide
        Arturo Zambrano added a comment -

        Finished backporting at revision 38772.

        Show
        Arturo Zambrano added a comment - Finished backporting at revision 38772.
        Arturo Zambrano made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Ken Fyten made changes -
        Fix Version/s 4.0 [ 11382 ]
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Arturo Zambrano
            Reporter:
            Ken Fyten
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: