ICEfaces
  1. ICEfaces
  2. ICE-9170

Showcase: ace:dataTable > Row State, Row/Cell Editing - Add messages component to catch validation errors

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 3.3
    • Fix Version/s: EE-3.3.0.GA, 4.0.BETA, 4.0
    • Component/s: Sample Apps
    • Labels:
      None
    • Environment:
      ICEfaces3 trunk revision# 34375
    • Assignee Priority:
      P3

      Description

      These demos need message components:
      ace:dataTable > Row State
      ace:datatable > Row/Cell Editing

        Activity

        Cruz Miraback created issue -
        Cruz Miraback made changes -
        Field Original Value New Value
        Issue Type Bug [ 1 ] Improvement [ 4 ]
        Ken Fyten made changes -
        Assignee yip.ng [ yip.ng ]
        Fix Version/s 3.4 [ 10770 ]
        Priority Major [ 3 ] Trivial [ 5 ]
        Assignee Priority P3 [ 10012 ]
        yip.ng made changes -
        Attachment screenshot-01.png [ 15812 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #34426 Tue Apr 16 11:42:37 MDT 2013 yip.ng ICE-9170: Showcase: ace:dataTable > Row State, Row/Cell Editing - Add messages component to catch validation errors.
        Files Changed
        Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/dataTable/dataTableRowEditing.xhtml
        Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/dataTable/dataTableRowState.xhtml
        Hide
        yip.ng added a comment -

        Done. See attached screenshot.

        M: C:\svn\ossrepo\icefaces3\trunk\icefaces\samples\showcase\showcase\src\main\webapp\resources\examples\ace\dataTable\dataTableRowEditing.xhtml#34426
        M: C:\svn\ossrepo\icefaces3\trunk\icefaces\samples\showcase\showcase\src\main\webapp\resources\examples\ace\dataTable\dataTableRowState.xhtml#34426

        Show
        yip.ng added a comment - Done. See attached screenshot . M: C:\svn\ossrepo\icefaces3\trunk\icefaces\samples\showcase\showcase\src\main\webapp\resources\examples\ace\dataTable\dataTableRowEditing.xhtml#34426 M: C:\svn\ossrepo\icefaces3\trunk\icefaces\samples\showcase\showcase\src\main\webapp\resources\examples\ace\dataTable\dataTableRowState.xhtml#34426
        yip.ng made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Carmen Cristurean added a comment -

        These changes introduced a regression in showcase on trunk rev# 34426 - Jenkins build 1034 (last working revision is svn #34424):

        ace:dataTable -> Row/Cell Editing, Row State: pressing the 'Cancel' icon after editing a row still updates the row (not an issue with ICEfaces 3.3 release).

        Show
        Carmen Cristurean added a comment - These changes introduced a regression in showcase on trunk rev# 34426 - Jenkins build 1034 (last working revision is svn #34424): ace:dataTable -> Row/Cell Editing, Row State: pressing the 'Cancel' icon after editing a row still updates the row (not an issue with ICEfaces 3.3 release).
        Ken Fyten made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #34555 Fri Apr 26 10:25:10 MDT 2013 yip.ng ICE-9170: Showcase: ace:dataTable > Row State, Row/Cell Editing - Add messages component to catch validation errors.
        Files Changed
        Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/dataTable/dataTableRowEditing.xhtml
        Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/dataTable/dataTableRowState.xhtml
        Hide
        yip.ng added a comment -

        Removed editCancel ajax event. (Original intention must be to clear messages. Seems it's just a misconception.)

        M: C:\svn\ossrepo\icefaces3\trunk\icefaces\samples\showcase\showcase\src\main\webapp\resources\examples\ace\dataTable\dataTableRowEditing.xhtml#34555
        M: C:\svn\ossrepo\icefaces3\trunk\icefaces\samples\showcase\showcase\src\main\webapp\resources\examples\ace\dataTable\dataTableRowState.xhtml#34555

        Show
        yip.ng added a comment - Removed editCancel ajax event. (Original intention must be to clear messages. Seems it's just a misconception.) M: C:\svn\ossrepo\icefaces3\trunk\icefaces\samples\showcase\showcase\src\main\webapp\resources\examples\ace\dataTable\dataTableRowEditing.xhtml#34555 M: C:\svn\ossrepo\icefaces3\trunk\icefaces\samples\showcase\showcase\src\main\webapp\resources\examples\ace\dataTable\dataTableRowState.xhtml#34555
        yip.ng made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Ken Fyten made changes -
        Fix Version/s EE-3.3.0.GA [ 10572 ]
        Ken Fyten made changes -
        Fix Version/s 4.0 [ 11382 ]
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            yip.ng
            Reporter:
            Cruz Miraback
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: