Attached pics to illustrate the head section contents after each step.

Added resource dependency data for the new theme selector resources.

Re-opened as there is still an ordering issue when "org.icefaces.coalesceResources=true" mode is used.

To reproduce the issue, use the showcase sample (from trunk rvn# 34387+). Monitor the HEAD section after each of the following steps:

1. Load the showcase application (opens to the Overview landing page)
1a. Resource ordering is correct (Sam theme comes before other CSS, incl. coalesced.css)
2. Change the current theme to "Pepper-grinder" using the themeSelector.
2a. Resource order is now incorrect. "Pepper-grinder theme is loaded AFTER the coalesced.css file.

The theme MUST be loaded before the coalesced.css or any theme customizations in the coalesced.css file will be overridden by the theme being reloaded again after the coalesced.css has been applied.

Modified ace:themeSelect component to use the resource related JSF API to properly enable resource ordering and coalescing. Now the component needs org.icefaces.generateHeadUpdate enabled to properly work since its basing the theme swiching on the update of the head trough ICEfaces core. Also moved state and utility methods from renderer to component.

Modified bridge to keep the list of current link refs up to date. This way CSS rules that were once interpreted will re-applied whenever the same resource will be referenced again.

I've retested showcase with these latest changes in place. Now the ordering of the theme CSS is incorrect both when coalesced and not.

The new behaviour has the theme css being loaded after the coalesced.css (or after other component and application CSS when not coalesced). This is incorrect as it makes it impossible for the application to override/customize the theme styling if the theme css is not loaded before the application css. Generally, the theme css needs to be loaded first.

I did notice that the theme.css is no longer included in the coalesced.css file, which avoids the issue noted in ICE-9166, so that JIRA could probably be marked FIXED due to these changes.

In addition, the ace:themeSelect component now longer takes effect until the page is reloaded or navigated away from, whether or not coalescing is active. Previously, the theme change would take effect immediately when changed on the page (via a forced page refresh).

Attached snapshots of the various head states that demonstrate the incorrect ordering of the theme.css.

Introduced AddTheme system event listener that adds the theme resource before the view is rendered. Changed CoalescedResource.userAgentNeedsUpdate to return true when the browser request is missing if-modified-since header. Modified ResourceHandler to recalculated the list on every GET, instead of just the first one. Added org.icefaces.generateHeadUpdate to the showcase web.xml.

Moved AddTheme class into ThemeSelectRenderer class. Modified theme select behaviour to reload the page if ace:ajax is used to react to theme changes. Read default theme from context-parameter when initial theme is not defined. Removed org.icefaces.generateHeadUpdate from "showcase" web.xml.