ICEfaces
  1. ICEfaces
  2. ICE-9147

ace:dialog - Add capability to add other components to the header section

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: EE-3.2.0.GA
    • Fix Version/s: 4.0.BETA, 4.0
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      All
    • Assignee Priority:
      P2
    • Salesforce Case Reference:
    • Affects:
      Documentation (User Guide, Ref. Guide, etc.), Sample App./Tutorial, Compatibility/Configuration

      Description

      Feature Request: Currently the ace:dialog header will only render some text and a close button. This request is to add in the capability to add other components such as another button to this header. This could be done through adding capability for an f:facet to be used, in a similar way to the ice:panelPopup.

        Issue Links

          Activity

          Arran Mccullough created issue -
          Arran Mccullough made changes -
          Field Original Value New Value
          Salesforce Case Reference 5007000000SSwXsAAL
          Ken Fyten made changes -
          Fix Version/s 3.4 [ 10770 ]
          Ken Fyten made changes -
          Link This issue blocks ICE-9001 [ ICE-9001 ]
          Ken Fyten made changes -
          Assignee Arturo Zambrano [ artzambrano ]
          Affects Documentation (User Guide, Ref. Guide, etc.),Sample App./Tutorial,Compatibility/Configuration [ 10003, 10001, 10002 ]
          Assignee Priority P2 [ 10011 ]
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #37307 Tue Aug 06 10:18:39 MDT 2013 art.zambrano ICE-9147 added 'handle' option for draggable dialog
          Files Changed
          Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/dialog/DialogMeta.java
          Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/jquery/ui/jquery-ui.js
          Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/dialog/DialogRenderer.java
          Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/jquery/ui/readme.txt
          Hide
          Arturo Zambrano added a comment - - edited

          Committed new feature at revision 37307.

          Added new 'handle' attribute to specify which element(s) inside the dialog will be used as the handle(s), instead of the header. It wasn't feasible to add a facet for custom header rendering. We don't render the header ourselves; the jQueryUI widget only takes a header string and a boolean option for the close button in the configuration object, and it adds the necessary nodes to the dialog.

          For this specific customer, the usage could be like this:

          <ace:dialog handle=".myHeader" showHeader="false" styleClass="noPadding"... >
          	<div class="myHeader" style="height:50px;cursor:move;">
          	<!-- custom header content -->
          	</div>
          	<!-- dialog body -->
          </ace:dialog>
          

          The following styling rule would be necessary to remove all the paddings inside the dialog:
          .noPadding, .noPadding .ui-dialog-content

          { padding:0; }
          Show
          Arturo Zambrano added a comment - - edited Committed new feature at revision 37307. Added new 'handle' attribute to specify which element(s) inside the dialog will be used as the handle(s), instead of the header. It wasn't feasible to add a facet for custom header rendering. We don't render the header ourselves; the jQueryUI widget only takes a header string and a boolean option for the close button in the configuration object, and it adds the necessary nodes to the dialog. For this specific customer, the usage could be like this: <ace:dialog handle= ".myHeader" showHeader= " false " styleClass= "noPadding" ... > <div class= "myHeader" style= "height:50px;cursor:move;" > <!-- custom header content --> </div> <!-- dialog body --> </ace:dialog> The following styling rule would be necessary to remove all the paddings inside the dialog: .noPadding, .noPadding .ui-dialog-content { padding:0; }
          Arturo Zambrano made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #37335 Thu Aug 08 10:15:14 MDT 2013 art.zambrano ICE-9147 added support for header facet in ace:dialog; removed previous approach to solve this issue (adding 'handle' attribute)
          Files Changed
          Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/dialog/DialogMeta.java
          Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/jquery/ui/jquery-ui.js
          Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/dialog/DialogRenderer.java
          Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/jquery/ui/readme.txt
          Hide
          Arturo Zambrano added a comment -

          As per Mark's input, the approach to solve this issue was changed from adding a 'handle' attribute to supporting a 'header' facet. This change was committed at revision 37335.

          This is a new example of how the feature is issued. You can disregard the example in the previous comment.

          <ace:dialog draggable="true" width="400">
             <f:facet name="header">
          		<h:outputText value="Custom Header" />
             </f:facet>
             ...
          </ace:dialog>
          

          The same class name 'ui-dialog-titlebar' will be used for the custom header, so it will show the 'move' cursor.

          Show
          Arturo Zambrano added a comment - As per Mark's input, the approach to solve this issue was changed from adding a 'handle' attribute to supporting a 'header' facet. This change was committed at revision 37335. This is a new example of how the feature is issued. You can disregard the example in the previous comment. <ace:dialog draggable= " true " width= "400" > <f:facet name= "header" > <h:outputText value= "Custom Header" /> </f:facet> ... </ace:dialog> The same class name 'ui-dialog-titlebar' will be used for the custom header, so it will show the 'move' cursor.
          Ken Fyten made changes -
          Fix Version/s 4.0 [ 11382 ]
          Ken Fyten made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              Arturo Zambrano
              Reporter:
              Arran Mccullough
            • Votes:
              1 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: