ICEfaces
  1. ICEfaces
  2. ICE-9140

fileEntry callback can't call FileInfo.updateStatus with invalidate=true

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 3.0.1, EE-3.0.0.GA
          • Fix Version/s: 3.3
          • Component/s: ACE-Components
          • Labels:
            None
          • Environment:
            All
          • Assignee Priority:
            P1
          • Workaround Exists:
            Yes
          • Workaround Description:
            Use invalidate=false and then manually call FacesContext.getCurrentInstance().validationFailed().

            Description

            This is a similar issue with FileInfo.updateStatus that was found in ICE-7712:

            http://jira.icesoft.org/browse/ICE-7712?focusedCommentId=38411&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-38411

            The fix to that was predicated on the file upload processing happening in the FileEntryPhaseListener during RestoreView phase. Afterwards, for ICE-7931, the processing was moved to happen in FileEntryResourceHandler, to better work with Glassfish 3.1.2. As a side effect, the processing is no longer happening within a phase, but before them when the current phase is null, which didn't work with the ICE-7712 test, so we still end up with a NPE and updateStatus not working properly.

              Activity

              Ascending order - Click to sort in descending order
              Mark Collette created issue -
              Mark Collette made changes -
              Field Original Value New Value
              Workaround Description Use invalidate=false and then manually call FacesContext.getCurrentInstance().validationFailed().
              Assignee Mark Collette [ mark.collette ]
              Fix Version/s 3.3 [ 10370 ]
              Workaround Exists Yes [ 10007 ]
              Hide
              Permalink
              Mark Collette added a comment -

              The invalidate parameter has limited utility since the fileEntry will still use its immediateValidation validation property to do validation in processDecodes or processValidators, and use the FileInfo.isSaved() to determine if it's valid or not, and call FacesContext's validationFailed() and renderResponse() methods if not.

              Show
              Mark Collette added a comment - The invalidate parameter has limited utility since the fileEntry will still use its immediateValidation validation property to do validation in processDecodes or processValidators, and use the FileInfo.isSaved() to determine if it's valid or not, and call FacesContext's validationFailed() and renderResponse() methods if not.
              Hide
              Permalink
              Mark Collette added a comment -

              icefaces3 trunk
              Subversion 34266

              Show
              Mark Collette added a comment - icefaces3 trunk Subversion 34266
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #34266 Fri Apr 05 19:18:12 MDT 2013 mark.collette ICE-9140 : fileEntry callback can't call FileInfo.updateStatus with invalidate=true
              Files Changed
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/fileentry/FileEntryResults.java
              Mark Collette made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Assignee Priority P1 [ 10010 ]
              Resolution Fixed [ 1 ]
              Mark Collette made changes -
              Description This is a similar issue with FileInfo.updateStatus that was found in ICE-7712:

              http://jira.icesoft.org/browse/ICE-7712?focusedCommentId=38411&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-38411

              The fix to that was predicated on the file upload processing happening in the FileEntryPhaseListener during RestoreView phase. Afterwards, for ICE-7931, the processing was moved to happen in FileEntryResourceHandler, to better work with portlets. As a side effect, the processing is no longer happening within a phase, but before them when the current phase is null, which didn't work with the ICE-7712 test, so we still end up with a NPE and updateStatus not working properly.               		This is a similar issue with FileInfo.updateStatus that was found in ICE-7712:

              http://jira.icesoft.org/browse/ICE-7712?focusedCommentId=38411&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-38411

              The fix to that was predicated on the file upload processing happening in the FileEntryPhaseListener during RestoreView phase. Afterwards, for ICE-7931, the processing was moved to happen in FileEntryResourceHandler, to better work with Glassfish 3.1.2. As a side effect, the processing is no longer happening within a phase, but before them when the current phase is null, which didn't work with the ICE-7712 test, so we still end up with a NPE and updateStatus not working properly.
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Mark Collette
                  Reporter:
                  Mark Collette
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: