Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 3.3
-
Fix Version/s: EE-4.0.0.GA, 4.1
-
Component/s: ACE-Components
-
Labels:None
-
Environment:Icefaces 3.3 from trunk
-
Assignee Priority:P1
Description
Breakpoint on FileEntryFormSubmit.processEvent() amazingly show this method is called 6-9 times on pages also on pages without ace:fileEntry included?
Activity
- All
- Comments
- History
- Activity
- Remote Attachments
- Subversion
Wired FileEntryFormSubmit listener for form pre-render events to ensure that FileEntry can be found among the grand/children of the form. Previously the listener was executed on form post-add to view events with the condition of finding the FileEntry component among the children, but of course there are cases where the FileEntry is not yet in the tree at that time.
All MyFaces specific issues are still reproducible in showcase on IF4 trunk r.44073.
Introduced view scoped bean that records when beans are disposed first. This is then used to decide if ICEfaces' bean disposal code need to run.
Added back FileEntryLoader class to register FileEntryPhaseListener on startup. FileEntryPhaseListener is responsible for running the validation phase during an upload.
FileEntryFormSubmit is a SystemEventListener that listens for form components being added to the page, on every single lifecycle, and adds javascript to make the form submit work with the fileEntry uploading code, if the form contains any fileEntry components. The more forms on your page, the more this will be called. Is there some performance problem you're experiencing with this?
Modified ice.ace.fileentry.cancelFileSelection function to clone the submitting element and avoid serializing the included input[type=file] elements. This ensures that Myfaces will not invalidate the form submit and cause the issued single submit to fail (including the element cleanup it needs to do).