Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 3.0
-
Fix Version/s: 3.3
-
Component/s: ICE-Components
-
Labels:None
-
Environment:N/A
-
Salesforce Case Reference:
-
Affects:Documentation (User Guide, Ref. Guide, etc.)
Description
The partialSubmit attribute on ice:inputRichText has been broken since the component was refactored to use CKeditor instead of FCKeditor.
The partialSubmit attribute on the inputRichText component should select whether a full or partialSubmit is used by the save button on the toolbar. partialSubmit won't be used when saveOnSubmit=true. The exact behavior needs to be documented in the TLD.
The partialSubmit attribute on the inputRichText component should select whether a full or partialSubmit is used by the save button on the toolbar. partialSubmit won't be used when saveOnSubmit=true. The exact behavior needs to be documented in the TLD.
-
Hide
-
-
META-INF/MANIFEST.MF
-
WEB-INF/classes/Bean.java
-
WEB-INF/classes/Bean.class
-
WEB-INF/faces-config.xml
-
WEB-INF/lib/icefaces-ee-ext.jar
-
WEB-INF/lib/icefaces-ee.jar
-
WEB-INF/lib/commons-logging.jar
-
WEB-INF/lib/icefaces-ee-compat.jar
-
WEB-INF/lib/jxl.jar
-
WEB-INF/.../krysalis-jCharts-1.0.0-alpha-1.jar
-
WEB-INF/lib/icefaces-ee-ace.jar
-
WEB-INF/lib/javax.faces.jar
-
WEB-INF/web.xml
-
index.jsp
-
index.xhtml
-
js/config.js
-
-
Activity
| Field | Original Value | New Value |
|---|---|---|
| Summary | CLONE - Add partialSubmit attribute to inputRichText component | partialSubmit attribute not working with ice:inputRichText component |
| Affects Version/s | 3.0 [ 10241 ] | |
| Affects Version/s | 2.0.0 [ 10230 ] | |
| Affects Version/s | 3.2 [ 10338 ] |
| Fix Version/s | 3.3 [ 10370 ] | |
| Fix Version/s | 2.0.1 [ 10255 ] |
| Description | Add partialSubmit attribute to inputRichText component to select whether a full or partialSubmit is used by the save button on the toolbar. partialSubmit won't be used when saveOnSubmit=true. The exact behavior needs to be documented in the TLD. |
The partialSubmit attribute on ice:inputRichText has been broken since the component was refactored to use CKeditor instead of FCKeditor.
The partialSubmit attribute on the inputRichText component should select whether a full or partialSubmit is used by the save button on the toolbar. partialSubmit won't be used when saveOnSubmit=true. The exact behavior needs to be documented in the TLD. |
We need to restore the original partialSubmit functionality in a backwards compatible way only, no changes.
| Issue Type | New Feature [ 2 ] | Bug [ 1 ] |
| Repository | Revision | Date | User | Message |
| ICEsoft Public SVN Repository | #33993 | Wed Mar 20 14:30:04 MDT 2013 | yip.ng | |
| Files Changed | ||||
MODIFY
/icefaces3/trunk/icefaces/compat/components/src/main/resources/META-INF/resources/inputrichtext/ckeditor_ext.js
MODIFY
/icefaces3/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/inputrichtext/InputRichTextRenderer.java
|
| Attachment | screenshot-03.png [ 15680 ] |
Done, but there seems to be something strange about the partial submit. It seems to be doing a full submit. See screenshot-03.png
.
M: C:\svn\ossrepo\icefaces3\trunk\icefaces\compat\components\src\main\resources\META-INF\resources\inputrichtext\ckeditor_ext.js#33993
M: C:\svn\ossrepo\icefaces3\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\inputrichtext\InputRichTextRenderer.java#33993
Show
yip.ng
added a comment - Done, but there seems to be something strange about the partial submit. It seems to be doing a full submit. See screenshot-03.png .
M: C:\svn\ossrepo\icefaces3\trunk\icefaces\compat\components\src\main\resources\META-INF\resources\inputrichtext\ckeditor_ext.js#33993
M: C:\svn\ossrepo\icefaces3\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\inputrichtext\InputRichTextRenderer.java#33993
The test case should be updated to use an ice:outputText to output the markup output instead of an input component. Then the test should work correctly with this change.
| Attachment | ICE-6656.zip [ 15682 ] |
Done. Zip file of modified test case: ICE-6656.zip
. Video of testing modified test case: http://screencast.com/t/qxaG6j7J.
| Status | Open [ 1 ] | Resolved [ 5 ] |
| Resolution | Fixed [ 1 ] |
| Status | Resolved [ 5 ] | Closed [ 6 ] |
Tyler Johnson added a comment - 15/Mar/13 12:00 AM
PartialSubmit on the ice:inputRichText isn't firing in IF 3.2. Using saveOnSubmit="false" and partialSubmit="true". Attaching test case intended for deployment on Tomcat 7.
yip.ng added a comment - 18/Mar/13 12:34 PM - edited
Changes were applied to icefaces2 only. (Original target was 2.0.1) They were carried over to icefaces3 when icefaces3 was created. (Exact rev. 24137 shows up in icefaces3 svn history.) However, the file fckeditor_ext.js is now gone. Global search of some code snippets turned up nothing. Where did the original code get transferred to?
yip.ng added a comment - 19/Mar/13 10:01 AM - edited
Found a similarly-named file ckeditor_ext.js, but the code is totally different. The Java renderer class is also very different now. So it's not just a simple matter of re-applying the changes at rev. 24137.
Also, the original partial submit feature added was for when clicking the save button. See JIRA description and screenshot-02.png. However, the new test case doesn't even have a save button in it and it seems to want a partial submit on blur. So which should we do?