ICEfaces
  1. ICEfaces
  2. ICE-9055

ace:dataTable - Table Configuration 'Option' button disappears on 'Cost' column switch

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Trivial Trivial
          • Resolution: Fixed
          • Affects Version/s: 3.2
          • Fix Version/s: 4.0.BETA, 4.0
          • Component/s: ICE-Components, QA, Sample Apps
          • Labels:
            None
          • Environment:
            Icefaces3 trunk revision# 33728
            Server: tomcat6
            Browser: FF3.6, IE7 & GoogleChrome25
            Last Known working revision: Currently tracking
          • Assignee Priority:
            P3
          • Workaround Description:
            Use "in-col-right" or "in-col-left" tableConfigPanel position.

            Description

            DataTable - Configuration - Switching 'Cost' column position within the column headers causes config button to disappear (using trunk rev#33730)

            To reproduce:
            - Build and deploy showcase app
            - Navigate to ace:dataTable - table configuration page and click on config button located within cost column
            - remove ID, Chassis, Weight, and MPG visibility, and drag&drop 'Cost' column onto the 2nd place within column headers
            - Notice that the config button disappears on column position switch

              Issue Links

              depends on

              Improvement - An improvement or enhancement to an existing feature or task. ICE-9471 ace:tableConfigPanel - Add built in support for ace:columnGroup

              • Major - Major loss of function.
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                Jerome Ruzol created issue -
                Ken Fyten made changes -
                Field Original Value New Value
                Affects Version/s 3.2 [ 10338 ]
                Ken Fyten made changes -
                Fix Version/s 3.3 [ 10370 ]
                Ken Fyten made changes -
                Assignee Nils Lundquist [ nils.lundquist ]
                Assignee Priority P3 [ 10012 ]
                Hide
                Permalink
                Nils Lundquist added a comment -

                I'll add that this isn't a regression but a known logic limitation.

                Show
                Nils Lundquist added a comment - I'll add that this isn't a regression but a known logic limitation.
                Hide
                Permalink
                Mark Collette added a comment -

                Why doesn't the config button then show in the new last column, 'Accel' ?

                Show
                Mark Collette added a comment - Why doesn't the config button then show in the new last column, 'Accel' ?
                Ken Fyten made changes -
                Assignee Priority P3 [ 10012 ] P2 [ 10011 ]
                Ken Fyten made changes -
                Fix Version/s 3.4 [ 10770 ]
                Fix Version/s 3.3 [ 10370 ]
                Hide
                Permalink
                Nils Lundquist added a comment -

                This issue is due to behaviour where the user is able to hide the column that contains the config panel button. This is only the case when using "first-col", or "last-col" position. When using "in-col-right" or "in-col-left" and a fixed target column - this isn't an issue.

                It's intuitive that if the config button is always in the last column - and you've made a hidden column the last one - you'll end up with a hidden button.

                Improvements to this logic are low priority.

                Show
                Nils Lundquist added a comment - This issue is due to behaviour where the user is able to hide the column that contains the config panel button. This is only the case when using "first-col", or "last-col" position. When using "in-col-right" or "in-col-left" and a fixed target column - this isn't an issue. It's intuitive that if the config button is always in the last column - and you've made a hidden column the last one - you'll end up with a hidden button. Improvements to this logic are low priority.
                Nils Lundquist made changes -
                Workaround Description Use "in-col-right" or "in-col-left" tableConfigPanel position.
                Priority Major [ 3 ] Trivial [ 5 ]
                Assignee Priority P2 [ 10011 ] P3 [ 10012 ]
                Hide
                Permalink
                Nils Lundquist added a comment -

                Mark - because in this context the 'last' column is the one at the end of the list of children. Rendered state doesn't effect order during this calculation.

                Show
                Nils Lundquist added a comment - Mark - because in this context the 'last' column is the one at the end of the list of children. Rendered state doesn't effect order during this calculation.
                Hide
                Permalink
                Nils Lundquist added a comment -

                Revision #36358
                Committed by nils.lundquist
                Moments ago
                ICE-9055 - Altered logic to determine the first and last columns to take rendered state in account.

                Show
                Nils Lundquist added a comment - Revision #36358 Committed by nils.lundquist Moments ago ICE-9055 - Altered logic to determine the first and last columns to take rendered state in account.
                Nils Lundquist made changes -
                Status Open [ 1 ] Resolved [ 5 ]
                Resolution Fixed [ 1 ]
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #36358 Mon Jun 24 18:28:49 MDT 2013 nils.lundquist ICE-9055 - Altered logic to determine the first and last columns to take rendered state in account.
                Files Changed
                Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/datatable/DataTableDecoder.java
                Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/datatable/DataTableHeadRenderer.java
                Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/tableconfigpanel/TableConfigPanelRenderer.java
                Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/datatable/DataTableRowRenderer.java
                Hide
                Permalink
                Liana Munroe added a comment -

                Not able to reproduce, Icefaces3-ee, Myfaces, revision #34815. IE7, chrome FF 3.6

                Show
                Liana Munroe added a comment - Not able to reproduce, Icefaces3-ee, Myfaces, revision #34815. IE7, chrome FF 3.6
                Ken Fyten made changes -
                Summary Icefaces3 Showcase regressions - DataTable - Table Configuration 'Option' button disappears on 'Cost' column switch ace:dataTable - Table Configuration 'Option' button disappears on 'Cost' column switch
                Ken Fyten made changes -
                Security Private [ 10001 ]
                Ken Fyten made changes -
                Fix Version/s EE-3.3.0.GA_P02 [ 11371 ]
                Ken Fyten made changes -
                Fix Version/s EE-3.3.0.GA_P02 [ 11371 ]
                Hide
                Permalink
                Ken Fyten added a comment -

                This fix was superseded by other related changes made for ICE-9471.

                Show
                Ken Fyten added a comment - This fix was superseded by other related changes made for ICE-9471 .
                Ken Fyten made changes -
                Link This issue depends on ICE-9471 [ ICE-9471 ]
                Hide
                Permalink
                Ken Fyten added a comment -

                Fixed by http://jira.icesoft.org/browse/ICE-9471.

                Show
                Ken Fyten added a comment - Fixed by http://jira.icesoft.org/browse/ICE-9471 .
                Ken Fyten made changes -
                Fix Version/s 4.0 [ 11382 ]
                Ken Fyten made changes -
                Status Resolved [ 5 ] Closed [ 6 ]

                  People

                  • Assignee:
                    Nils Lundquist
                    Reporter:
                    Jerome Ruzol
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    5 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: