ICEfaces
  1. ICEfaces
  2. ICE-9049

Fail to hide all popups (diffConfig=att specific)

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.2
    • Fix Version/s: 3.3
    • Component/s: ICE-Components
    • Labels:
      None
    • Environment:
      All supported browsers

      Description

      There's a regression when running ICE-6868 test using diffConfig=att, both popups are not closed when clicking on "hide all" button.

        Activity

        Repository Revision Date User Message
        ICEsoft Public SVN Repository #33762 Tue Mar 05 08:39:51 MST 2013 mircea.toma ICE-9049 Modified modal popup JS code to restore the callbacks disabled by a previously opened popup so that only that the input elements of the last opened popup are active. The reverse was done when closing the last openend popup, the callbacks of the previously opened popup are re-disabled.
        Files Changed
        Commit graph MODIFY /icefaces3/trunk/icefaces/compat/core/src/main/javascript/extras/extras.js
        Mircea Toma created issue -
        Hide
        Mircea Toma added a comment -

        This regression is caused by the popup1 which disables the event handlers of all elements, including popup2's, with the exception of the elements included in popup1's container. When attribute update is not enabled the event handlers are restored when the entire popup2 markup is updated, thus making the "hide all" button work again. The fix we need to apply in this case is at component level, not in JSF or our bridge

        Show
        Mircea Toma added a comment - This regression is caused by the popup1 which disables the event handlers of all elements, including popup2's, with the exception of the elements included in popup1's container. When attribute update is not enabled the event handlers are restored when the entire popup2 markup is updated, thus making the "hide all" button work again. The fix we need to apply in this case is at component level, not in JSF or our bridge
        Mircea Toma made changes -
        Field Original Value New Value
        Description There's a regression when running ICE-6868 test using diffConfig=att, both popups are not closed when clicking on "Close All" button. There's a regression when running ICE-6868 test using diffConfig=att, both popups are not closed when clicking on "hide all" button.
        Mircea Toma made changes -
        Summary Fail to hide all popup overlays (diffConfig=att specific) Fail to hide all popups (diffConfig=att specific)
        Hide
        Mircea Toma added a comment -

        Modified modal popup JS code to restore the callbacks disabled by a previously opened popup so that only that the input elements of the last opened popup are active. The reverse was done when closing the last openend popup, the callbacks of the previously opened popup are re-disabled.

        Show
        Mircea Toma added a comment - Modified modal popup JS code to restore the callbacks disabled by a previously opened popup so that only that the input elements of the last opened popup are active. The reverse was done when closing the last openend popup, the callbacks of the previously opened popup are re-disabled.
        Mircea Toma made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Mircea Toma made changes -
        Assignee Mircea Toma [ mircea.toma ]
        Mircea Toma made changes -
        Affects Version/s 3.2 [ 10338 ]
        Mircea Toma made changes -
        Fix Version/s 3.3 [ 10370 ]
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Mircea Toma
            Reporter:
            Mircea Toma
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: