ICEfaces
  1. ICEfaces
  2. ICE-9029

ace:chart - implement varyBarColor property

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: EE-3.2.0.GA
    • Fix Version/s: EE-3.3.0.GA_P02, 4.0
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      *
    • Assignee Priority:
      P2

      Description

      The varyBarColor property of CartesianSeries could be exposed to users so that they might have bars of differing colours within the same series.

        Activity

        Nils Lundquist created issue -
        Nils Lundquist made changes -
        Field Original Value New Value
        Assignee Nils Lundquist [ nils.lundquist ]
        Ken Fyten made changes -
        Assignee Nils Lundquist [ nils.lundquist ]
        Ken Fyten made changes -
        Assignee Judy Guglielmin [ judy.guglielmin ]
        Fix Version/s EE-3.3.0.GA_P02 [ 11371 ]
        Fix Version/s 4.0 [ 11382 ]
        Assignee Priority P2 [ 10011 ]
        Hide
        Judy Guglielmin added a comment - - edited

        including ability to define seriesColors. Appears that charts can have centrally defined object for seriesColors or can use the model to define by chart model instance.

        Creating tests for all variations for barChart, but with implementation, since Line chart and Bar chart share CartesianSeries model, must create testing for that as well. Since seriesColor is something that can be defined at higher level, may also have to check all other models (so extra testing).

        First implementation of varyColor uses default jqPlot colors, 2nd uses model definition (by chart). Should be able to define by chart, so stackedSeries should be able to have defined color for each chart data series defined.

        Show
        Judy Guglielmin added a comment - - edited including ability to define seriesColors. Appears that charts can have centrally defined object for seriesColors or can use the model to define by chart model instance. Creating tests for all variations for barChart, but with implementation, since Line chart and Bar chart share CartesianSeries model, must create testing for that as well. Since seriesColor is something that can be defined at higher level, may also have to check all other models (so extra testing). First implementation of varyColor uses default jqPlot colors, 2nd uses model definition (by chart). Should be able to define by chart, so stackedSeries should be able to have defined color for each chart data series defined.
        Hide
        Judy Guglielmin added a comment -

        mistakenly committed to 3.3.0 mtce branch as ICE-9209

        Show
        Judy Guglielmin added a comment - mistakenly committed to 3.3.0 mtce branch as ICE-9209
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #40516 Tue Apr 01 14:26:36 MDT 2014 judy.guglielmin ICE-9029 implement varyBarColor and add defaultSeriesColors to override default colors for jqplot. Can define seriesColors in model for CartesianSeries for varyBarColor as well (on a series basis)
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/model/chart/CartesianSeries.java
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/chart/chart.js
        Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/java/org/icefaces/samples/showcase/example/ace/chart/ChartBarBean.java
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/chart/ChartRenderer.java
        Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/chart/chartBar.xhtml
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/chart/ChartMeta.java
        Hide
        Judy Guglielmin added a comment -

        rev 40580 for bulk of checkin for 3.3.0-mtce branch . 40518 to I8N the panel header
        rev 40516 for icefaces4 checkin.

        rev 37790 for 3.3 QA branch chart test app. Don't bother scripting until other bar chart new tasks are implemented.

        varyBarColor is a boolean in the model (CartesianSeries). seriesColor is a String[] in the ChartSeries-which CartesianSeries inherits from, so custom colors may be listed there.

        Also added defaultSeriesColors in chart object which can be used for any chart object to override the jqplot seriesColors.

        Show
        Judy Guglielmin added a comment - rev 40580 for bulk of checkin for 3.3.0-mtce branch . 40518 to I8N the panel header rev 40516 for icefaces4 checkin. rev 37790 for 3.3 QA branch chart test app. Don't bother scripting until other bar chart new tasks are implemented. varyBarColor is a boolean in the model (CartesianSeries). seriesColor is a String[] in the ChartSeries-which CartesianSeries inherits from, so custom colors may be listed there. Also added defaultSeriesColors in chart object which can be used for any chart object to override the jqplot seriesColors.
        Judy Guglielmin made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Carmen Cristurean added a comment - - edited

        Re-opening because of the showcase > chart > Bar demo: test is functional, however the drop-down on this demo appears to render source code, see screen shot (IF4 trunk only, rev# 40799) .

        Show
        Carmen Cristurean added a comment - - edited Re-opening because of the showcase > chart > Bar demo: test is functional, however the drop-down on this demo appears to render source code, see screen shot (IF4 trunk only, rev# 40799) .
        Carmen Cristurean made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Carmen Cristurean made changes -
        Attachment chart-bar.png [ 17097 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #40814 Tue Apr 15 13:40:11 MDT 2014 judy.guglielmin ICE-9029 missed on first checkin for showcase example
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/resources/org/icefaces/samples/showcase/view/resources/messages.properties
        Hide
        Judy Guglielmin added a comment -

        rev 40814 missed messages.properties showcase example on previous checkin ->there now..

        Show
        Judy Guglielmin added a comment - rev 40814 missed messages.properties showcase example on previous checkin ->there now..
        Judy Guglielmin made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #40816 Tue Apr 15 14:34:46 MDT 2014 carmen.cristurean ICE-9029: minor update required to render ace:panel header title.
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/chart/chartBar.xhtml
        Hide
        Carmen Cristurean added a comment -

        Verified with IF4 trunk # 40816 in FF28, Chrome34, IE10.

        Show
        Carmen Cristurean added a comment - Verified with IF4 trunk # 40816 in FF28, Chrome34, IE10.
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Judy Guglielmin
            Reporter:
            Nils Lundquist
          • Votes:
            1 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: