ICEfaces
  1. ICEfaces
  2. ICE-8996

OutputStyleRender checking for .css extension causes problems when URL includes parameters

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.2
    • Fix Version/s: 3.3
    • Component/s: ICE-Components
    • Labels:
      None
    • Environment:
      Compat Components

      Description

      A couple of recent forum postings:

      http://www.icesoft.org/JForum/posts/list/21716.page#76295
      http://www.icesoft.org/JForum/posts/list/21306.page#74870

      have noted that they are seeing this being logged:

      2012-09-24 14:17:19,339 ERROR com.icesoft.faces.component.style.OutputStyleRenderer - Error in OutputStyleRenderer java.lang.RuntimeException: OutputStyle file attribute must end in .css. Current Value is [/app/javax.faces.resource/tce.css.iface?ln=css] at com.icesoft.faces.component.style.OutputStyleRenderer.encodeEnd(OutputStyleRenderer.java:119) - See more at: http://www.icesoft.org/JForum/posts/list/21306.page#74870

      It seems that if you use the #{resource['css:styles.css']} style syntax, the library name is automatically added to the URL. The OutputStyleRenderer is doing a fairly brute force check to see if the URL (rather than the file) ends with .css and bails if it encounters something like /app/javax.faces.resource/styles.css.iface?ln=css.

      So we should make the checking a bit smarter in order to allow the use of the #{resource} EL syntax.
      1. liferay.2013-03-15.log
        27 kB
        yip.ng
      1. screenshot-01.png
        186 kB
      2. screenshot-02.png
        123 kB
      3. screenshot-03.png
        149 kB

        Activity

        Repository Revision Date User Message
        ICEsoft Public SVN Repository #33838 Thu Mar 07 17:32:10 MST 2013 yip.ng ICE-8996: OutputStyleRender checking for .css extension causes problems when URL includes parameters.
        Files Changed
        Commit graph MODIFY /icefaces3/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/style/OutputStyleRenderer.java

          People

          • Assignee:
            yip.ng
            Reporter:
            Deryk Sinotte
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: