Details
-
Type: Bug
-
Status: Closed
-
Priority: Major
-
Resolution: Fixed
-
Affects Version/s: 3.2
-
Fix Version/s: 3.3
-
Component/s: ICE-Components
-
Labels:None
-
Environment:Compat Components
-
Assignee Priority:P1
-
ICEsoft Forum Reference:
Description
A couple of recent forum postings:
http://www.icesoft.org/JForum/posts/list/21716.page#76295
http://www.icesoft.org/JForum/posts/list/21306.page#74870
have noted that they are seeing this being logged:
2012-09-24 14:17:19,339 ERROR com.icesoft.faces.component.style.OutputStyleRenderer - Error in OutputStyleRenderer java.lang.RuntimeException: OutputStyle file attribute must end in .css. Current Value is [/app/javax.faces.resource/tce.css.iface?ln=css] at com.icesoft.faces.component.style.OutputStyleRenderer.encodeEnd(OutputStyleRenderer.java:119) - See more at: http://www.icesoft.org/JForum/posts/list/21306.page#74870
It seems that if you use the #{resource['css:styles.css']} style syntax, the library name is automatically added to the URL. The OutputStyleRenderer is doing a fairly brute force check to see if the URL (rather than the file) ends with .css and bails if it encounters something like /app/javax.faces.resource/styles.css.iface?ln=css.
So we should make the checking a bit smarter in order to allow the use of the #{resource} EL syntax.
http://www.icesoft.org/JForum/posts/list/21716.page#76295
http://www.icesoft.org/JForum/posts/list/21306.page#74870
have noted that they are seeing this being logged:
2012-09-24 14:17:19,339 ERROR com.icesoft.faces.component.style.OutputStyleRenderer - Error in OutputStyleRenderer java.lang.RuntimeException: OutputStyle file attribute must end in .css. Current Value is [/app/javax.faces.resource/tce.css.iface?ln=css] at com.icesoft.faces.component.style.OutputStyleRenderer.encodeEnd(OutputStyleRenderer.java:119) - See more at: http://www.icesoft.org/JForum/posts/list/21306.page#74870
It seems that if you use the #{resource['css:styles.css']} style syntax, the library name is automatically added to the URL. The OutputStyleRenderer is doing a fairly brute force check to see if the URL (rather than the file) ends with .css and bails if it encounters something like /app/javax.faces.resource/styles.css.iface?ln=css.
So we should make the checking a bit smarter in order to allow the use of the #{resource} EL syntax.
Activity
Deryk Sinotte
created issue -
Deryk Sinotte
made changes -
Field | Original Value | New Value |
---|---|---|
Assignee | Ken Fyten [ ken.fyten ] |
Ken Fyten
made changes -
Assignee | Ken Fyten [ ken.fyten ] | yip.ng [ yip.ng ] |
Assignee Priority | P3 [ 10012 ] |
Repository | Revision | Date | User | Message |
ICEsoft Public SVN Repository | #33838 | Thu Mar 07 17:32:10 MST 2013 | yip.ng | |
Files Changed | ||||
MODIFY
/icefaces3/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/style/OutputStyleRenderer.java
|
Ken Fyten
made changes -
Assignee Priority | P3 [ 10012 ] | P1 [ 10010 ] |
yip.ng
made changes -
Attachment | screenshot-01.png [ 15503 ] | |
Attachment | screenshot-02.png [ 15504 ] |
yip.ng
made changes -
Attachment | screenshot-03.png [ 15507 ] |
yip.ng
made changes -
Attachment | liferay.2013-03-15.log [ 15586 ] |
yip.ng
made changes -
Status | Open [ 1 ] | Resolved [ 5 ] |
Resolution | Fixed [ 1 ] |
Ken Fyten
made changes -
Status | Resolved [ 5 ] | Closed [ 6 ] |
It's not enough to just not throw an exception: (as suggested by some forum users, naïvely thinking it is just harmless, unnecessary exception)