[ICE-8970] DOM update of whole body affects states of jQuery component manager singleton - ICEsoft JIRA Issue Tracker

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: None
Fix Version/s: 3.3
Component/s: None
Labels:
None
Environment:
*

Assignee Priority:
P1

Description

jQuery datepicker has singleton manager. Manager initialized on jQuery UI JS load. It has states pointing to HTML, at end of body in this case. (?) Update of body without manager knowing causes it to break.

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Download All

Attachments

Document12.txt

13/Feb/13 6:30 PM

69 kB

yip.ng

screenshot-01.png

272 kB

07/Feb/13 9:56 PM
screenshot-02.png

324 kB

13/Feb/13 5:58 PM
screenshot-03.png

261 kB

13/Feb/13 6:02 PM
screenshot-04.png

320 kB

13/Feb/13 6:09 PM

Issue Links

depends on

ICE-8992 javax_faces_developmentstage_messages causing body update

Open

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

yip.ng added a comment - 07/Feb/13 9:29 PM

Show

yip.ng added a comment - 07/Feb/13 9:29 PM ICE-8562 http://www.icesoft.org/JForum/posts/list/15/21571.page#76187

Hide

Permalink

yip.ng added a comment - 07/Feb/13 9:35 PM - edited

[11:05:34 AM] Ken Fyten: New JIRA to investigate if wrapping body contents in DIV with ID will avoid issues with jQuery widget manager singleton(s) losing references to DOM elements when a BODY level update occurs.

Show

yip.ng added a comment - 07/Feb/13 9:35 PM - edited [11:05:34 AM] Ken Fyten: New JIRA to investigate if wrapping body contents in DIV with ID will avoid issues with jQuery widget manager singleton(s) losing references to DOM elements when a BODY level update occurs.

Hide

Permalink

yip.ng added a comment - 07/Feb/13 9:58 PM

Doesn't work. See screenshot-01.

Show

yip.ng added a comment - 07/Feb/13 9:58 PM Doesn't work. See screenshot-01.

Hide

Permalink

Ted Goddard added a comment - 13/Feb/13 5:00 PM

Is the javax_faces_developmentstage_messages in the page to start? It may be causing the body update, and could possibly be fixed by running in production mode.

Show

Ted Goddard added a comment - 13/Feb/13 5:00 PM Is the javax_faces_developmentstage_messages in the page to start? It may be causing the body update, and could possibly be fixed by running in production mode.

Hide

Permalink

yip.ng added a comment - 13/Feb/13 6:11 PM

Same. See screenshot-02 to -04.

Show

yip.ng added a comment - 13/Feb/13 6:11 PM Same. See screenshot-02 to -04.

Hide

Permalink

Ted Goddard added a comment - 13/Feb/13 6:15 PM

Can you run with diffConfig="debugAB"? That should show us the source of the body update.

Show

Ted Goddard added a comment - 13/Feb/13 6:15 PM Can you run with diffConfig="debugAB"? That should show us the source of the body update.

Hide

Permalink

yip.ng added a comment - 13/Feb/13 6:32 PM

See attached Document12.txt.

Show

yip.ng added a comment - 13/Feb/13 6:32 PM See attached Document12.txt.

Hide

Permalink

Ted Goddard added a comment - 13/Feb/13 7:20 PM

The ID of the form on the page is changing, causing booking_fixviewstate to change to welcome_fixviewstate. We could avoid the body update by including our _fixviewstate scripts inside a common div.

Show

Ted Goddard added a comment - 13/Feb/13 7:20 PM The ID of the form on the page is changing, causing booking_fixviewstate to change to welcome_fixviewstate. We could avoid the body update by including our _fixviewstate scripts inside a common div.

Hide

Permalink

Mircea Toma added a comment - 18/Feb/13 3:32 PM - edited

Instead of using DIVs to avoid having the body element updated it is better to use h:panelGroup-s instead. This way the *_fixviewstate elements will be rendered at the same DOM tree level with the forms their scripts decorate.

<?xml version='1.0' encoding='UTF-8' ?>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml"
	xmlns:ui="http://java.sun.com/jsf/facelets"
	xmlns:h="http://java.sun.com/jsf/html"
	xmlns:ace="http://www.icefaces.org/icefaces/components"
    xmlns:icecore="http://www.icefaces.org/icefaces/core">
<h:head>
	<title>#{title}</title>
	<link rel="stylesheet" type="text/css"
		href="./resources/css/template.css" />
    <icecore:config mandatoryResources="linkButton dateTimeEntry dataTable dialog tabSet"/>
</h:head>
<h:body>
	<h:panelGroup style="display: block;" class="header" align="center">
		<ui:insert name="header">#{companyName}</ui:insert>
	</h:panelGroup>
	<h:panelGroup style="display: block;" class="topMenu">

		<ui:insert name="menuItems" />

	</h:panelGroup>
	<h:panelGroup style="display: block;" class="contentBody">

		<ui:insert name="tabItems" />

	</h:panelGroup>
</h:body>
</html>

In my opinion a fix should be still found for the ace:dateTimeEntry component because body element updates are quite valid and are handled well both in Mojarra and Myfaces.

Show

Mircea Toma added a comment - 18/Feb/13 3:32 PM - edited Instead of using DIVs to avoid having the body element updated it is better to use h:panelGroup-s instead. This way the *_fixviewstate elements will be rendered at the same DOM tree level with the forms their scripts decorate. <?xml version='1.0' encoding='UTF-8' ?> <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd" > <html xmlns= "http://www.w3.org/1999/xhtml" xmlns:ui = "http://java.sun.com/jsf/facelets" xmlns:h = "http://java.sun.com/jsf/html" xmlns:ace = "http://www.icefaces.org/icefaces/components" xmlns:icecore = "http://www.icefaces.org/icefaces/core" > <h:head> <title> #{title} </title> <link rel= "stylesheet" type= "text/css" href= "./resources/css/template.css" /> <icecore:config mandatoryResources= "linkButton dateTimeEntry dataTable dialog tabSet" /> </h:head> <h:body> <h:panelGroup style= "display: block;" class= "header" align= "center" > <ui:insert name= "header" > #{companyName} </ui:insert> </h:panelGroup> <h:panelGroup style= "display: block;" class= "topMenu" > <ui:insert name= "menuItems" /> </h:panelGroup> <h:panelGroup style= "display: block;" class= "contentBody" > <ui:insert name= "tabItems" /> </h:panelGroup> </h:body> </html> In my opinion a fix should be still found for the ace:dateTimeEntry component because body element updates are quite valid and are handled well both in Mojarra and Myfaces.

Hide

Permalink

yip.ng added a comment - 19/Feb/13 4:30 PM

Exactly what I had suggested to the user already: http://www.icesoft.org/JForum/posts/list/15/21571.page#76211.

Show

yip.ng added a comment - 19/Feb/13 4:30 PM Exactly what I had suggested to the user already: http://www.icesoft.org/JForum/posts/list/15/21571.page#76211 .

Hide

Permalink

Ted Goddard added a comment - 19/Feb/13 9:43 PM

Please explain in additional detail how the body tag is being used – is there code that has a reference to the body tag instance, or is there some other mechanism that is broken by the body update?

Show

Ted Goddard added a comment - 19/Feb/13 9:43 PM Please explain in additional detail how the body tag is being used – is there code that has a reference to the body tag instance, or is there some other mechanism that is broken by the body update?

Hide

Permalink

yip.ng added a comment - 19/Feb/13 10:32 PM

No reference to body. There is a <div> appended near the end of body used by calendar manager. This <div> is wiped out indiscriminately by a body update.

Show

yip.ng added a comment - 19/Feb/13 10:32 PM No reference to body. There is a <div> appended near the end of body used by calendar manager. This <div> is wiped out indiscriminately by a body update.

Hide

Permalink

yip.ng added a comment - 06/Aug/13 4:19 PM

~~ICE-9455~~

Show

yip.ng added a comment - 06/Aug/13 4:19 PM ICE-9455

People

Assignee:

yip.ng

Reporter:

yip.ng

Votes:

0 Vote for this issue

Watchers:

3 Start watching this issue

Dates

Created:

07/Feb/13 9:26 PM

Updated:

14/Nov/14 5:39 PM

Resolved:

19/Feb/13 4:30 PM