ICEfaces
  1. ICEfaces
  2. ICE-894

ServletEnvironmentRequest inadvertently clears HttpServletRequest headers

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.5
    • Fix Version/s: 1.6DR#4
    • Component/s: Framework
    • Labels:
      None
    • Environment:
      Operating System: All
      Platform: All

      Description

      This bug is related to ICE-893. When trying to get HttpServletRequest header
      information from a call to
      FacesContext.getCurrentInstance().getExternalContext().getRequest() the header
      information was always null. After tracing the problem from the stack trace
      the method copyServletRequestData() was copying the header information correctly
      then setting it to null for no apparent reason.

      As it turns out the logging api will only be invoked on action or action
      listeners so it will never acually access the header data via the
      ServletEnvironmentRequest object because it is only used by the
      PersistentFacesServlet .

        Activity

        Patrick Corless created issue -
        Hide
        Ted Goddard added a comment -

        icefaces.org can use a modified post-release build. Recommend we address later.

        Show
        Ted Goddard added a comment - icefaces.org can use a modified post-release build. Recommend we address later.
        Icefaces Administrator made changes -
        Field Original Value New Value
        issue.field.bugzillaimportkey 913 12163
        Ken Fyten made changes -
        Affects Version/s 1.5 [ 10027 ]
        Affects Version/s unspecified [ 10021 ]
        Hide
        Ted Goddard added a comment -

        Re-assigning to Patrick to use the desired feature in the application, re-test with the current build, and then assign to Mircea if a fix is necessary.

        Show
        Ted Goddard added a comment - Re-assigning to Patrick to use the desired feature in the application, re-test with the current build, and then assign to Mircea if a fix is necessary.
        Ted Goddard made changes -
        Assignee Ted Goddard [ ted.goddard ] Patrick Corless [ patrick.corless ]
        Ken Fyten made changes -
        Fix Version/s 1.6DR#4 [ 10060 ]
        Fix Version/s 1.6 [ 10031 ]
        Hide
        Patrick Corless added a comment -

        Closing bug.

        As of 1.6 dr3 this bug has been addressed. The refactoring of the core that has taken place between 1.5 and 1.6 has fixed the problem. The only thing to note is that when a call to getHeader(String param) is make the param String must be lower case, for example "content-type" instead of the normal convention "Content-Type".

        I'll recreate a new bug to address cases sensitivity issue with the header name values pairs.

        Show
        Patrick Corless added a comment - Closing bug. As of 1.6 dr3 this bug has been addressed. The refactoring of the core that has taken place between 1.5 and 1.6 has fixed the problem. The only thing to note is that when a call to getHeader(String param) is make the param String must be lower case, for example "content-type" instead of the normal convention "Content-Type". I'll recreate a new bug to address cases sensitivity issue with the header name values pairs.
        Hide
        Patrick Corless added a comment -

        Marking as fixed.

        Show
        Patrick Corless added a comment - Marking as fixed.
        Patrick Corless made changes -
        Status Open [ 1 ] Closed [ 6 ]
        Resolution Fixed [ 1 ]

          People

          • Assignee:
            Patrick Corless
            Reporter:
            Patrick Corless
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: