ICEfaces
  1. ICEfaces
  2. ICE-8944

Remove YUI from ace:linkButton, ace:checkboxButton & ace:pushButton

          Details

          • Type: Improvement Improvement
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: None
          • Fix Version/s: 3.3
          • Component/s: ACE-Components
          • Labels:
            None
          • Environment:
            *
          • Assignee Priority:
            P1

            Description

            These components use the YUI.Button object despite there being no real good reason to.

            It is rather easy to implement the functionality we derive from it, with much greater flexibility and far less overhead.

            These components should also include lazy initialization and clean up using our new mechanisms.

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              Nils Lundquist added a comment -

              Revision #33287
              Committed by nils.lundquist
              Moments ago
              ICE-8944 - Removed YUI from ace:CheckboxButton.

              Component Javascript is massively simplified. Component now renders more leanly as well.

              Show
              Nils Lundquist added a comment - Revision #33287 Committed by nils.lundquist Moments ago ICE-8944 - Removed YUI from ace:CheckboxButton. Component Javascript is massively simplified. Component now renders more leanly as well.
              Hide
              Permalink
              Nils Lundquist added a comment -

              Revision #33382
              Committed by nils.lundquist
              Moments ago
              ICE-8944 - Rewrite ace:checkboxButton styling. Remove global checkbox styling from ace:showcase. Added improved custom styling demo. Removed fake borders from showcase checkbox images.

              Show
              Nils Lundquist added a comment - Revision #33382 Committed by nils.lundquist Moments ago ICE-8944 - Rewrite ace:checkboxButton styling. Remove global checkbox styling from ace:showcase. Added improved custom styling demo. Removed fake borders from showcase checkbox images.
              Hide
              Permalink
              Ken Fyten added a comment -

              The commit for rvn 33300 resulted in the following serious regression failures with showcase sample application (confirmed by QA):

              Showcase (Firefox18, Tomcat7; manual test results with rev# 33376): 
Warnings in tomcat terminal window when clicking on the ace components left-side links:
WARNING: JSF1091: No mime type could be found for file http://wiki.icefaces.org/display/ICE/AutoCompleteEntry.  
To resolve this, add a mime-type mapping to the applications web.xml.

Chart - Dynamic: no chart is generated when clicking on a row in the dataTable.

List - Selection (Ajax): was able to select multiple items from list when 'Multiple Selection' check box was unchecked.

List - Reordering (Ajax): unable to select another item after reordering an item in the list.

SubmitMonitor: After changing the blockUI via the drop down the submitMonitor does not render, need to refresh the page for the blockUI change to take affect. Also ICE-8959 open.

Tooltip - all pages:  tooltip does not render and JS error (all browsers):
FF18:
TypeError: a.replace is not a function
http://localhost:8080/showcase/javax.faces.resource/util/ace-jquery.js.jsf?ln=icefaces.ace&v=3_3_0_130211
Line 436

IE8:
Webpage error details
User Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 6.1; WOW64; Trident/4.0; SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; MDDS; .NET4.0C)
Timestamp: Mon, 11 Feb 2013 18:59:03 UTC

Message: Object doesn't support this property or method
Line: 436
Char: 1264
Code: 0
URI: http://localhost:8080/showcase/javax.faces.resource/util/ace-jquery.js.jsf?ln=icefaces.ace&v=3_3_0_130211

Chrome24:
Uncaught
            TypeError: Object #<Object> has no method 'replace'
          ace-jquery.js.jsf:436
              Show
              Ken Fyten added a comment - The commit for rvn 33300 resulted in the following serious regression failures with showcase sample application (confirmed by QA): Showcase (Firefox18, Tomcat7; manual test results with rev# 33376): Warnings in tomcat terminal window when clicking on the ace components left-side links: WARNING: JSF1091: No mime type could be found for file http: //wiki.icefaces.org/display/ICE/AutoCompleteEntry. To resolve this , add a mime-type mapping to the applications web.xml. Chart - Dynamic: no chart is generated when clicking on a row in the dataTable. List - Selection (Ajax): was able to select multiple items from list when 'Multiple Selection' check box was unchecked. List - Reordering (Ajax): unable to select another item after reordering an item in the list. SubmitMonitor: After changing the blockUI via the drop down the submitMonitor does not render, need to refresh the page for the blockUI change to take affect. Also ICE-8959 open. Tooltip - all pages: tooltip does not render and JS error (all browsers): FF18: TypeError: a.replace is not a function http: //localhost:8080/showcase/javax.faces.resource/util/ace-jquery.js.jsf?ln=icefaces.ace&v=3_3_0_130211 Line 436 IE8: Webpage error details User Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 6.1; WOW64; Trident/4.0; SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; MDDS; .NET4.0C) Timestamp: Mon, 11 Feb 2013 18:59:03 UTC Message: Object doesn't support this property or method Line: 436 Char: 1264 Code: 0 URI: http: //localhost:8080/showcase/javax.faces.resource/util/ace-jquery.js.jsf?ln=icefaces.ace&v=3_3_0_130211 Chrome24: Uncaught TypeError: Object #< Object > has no method 'replace' ace-jquery.js.jsf:436
              Hide
              Permalink
              Nils Lundquist added a comment -

              The warning noted above has nothing to do with my change. I've seen it present prior to the addition of ice.ace.create.

              Show
              Nils Lundquist added a comment - The warning noted above has nothing to do with my change. I've seen it present prior to the addition of ice.ace.create.
              Hide
              Permalink
              Nils Lundquist added a comment -

              Tooltips issue is that it keeps a crazy reference to itself via the function that calls the tooltip creation code. This is a very fragile design that will have to be removed obviously.

              Show
              Nils Lundquist added a comment - Tooltips issue is that it keeps a crazy reference to itself via the function that calls the tooltip creation code. This is a very fragile design that will have to be removed obviously.
              Hide
              Permalink
              Nils Lundquist added a comment -

              Revision #33385
              Committed by nils.lundquist
              A minute ago
              ICE-8944 - List & Chart now update root element when script altered.

              Show
              Nils Lundquist added a comment - Revision #33385 Committed by nils.lundquist A minute ago ICE-8944 - List & Chart now update root element when script altered.
              Hide
              Permalink
              Nils Lundquist added a comment -

              Revision #33386
              Committed by nils.lundquist
              A minute ago
              ICE-8944 - Tooltip now initalizes with homogenous ACE initialization signature.

              Show
              Nils Lundquist added a comment - Revision #33386 Committed by nils.lundquist A minute ago ICE-8944 - Tooltip now initalizes with homogenous ACE initialization signature.
              Hide
              Permalink
              Nils Lundquist added a comment -

              I've confirmed with Mark that the SubmitMonitor issue mentioned above is unrelated.

              Show
              Nils Lundquist added a comment - I've confirmed with Mark that the SubmitMonitor issue mentioned above is unrelated.
              Hide
              Permalink
              Nils Lundquist added a comment -

              Revision #33468
              Committed by nils.lundquist
              Moments ago ICE-8944 - Removed YUI from pushbutton. Improved styling. Cleaned up showcase examples.

              Show
              Nils Lundquist added a comment - Revision #33468 Committed by nils.lundquist Moments ago ICE-8944 - Removed YUI from pushbutton. Improved styling. Cleaned up showcase examples.
              Hide
              Permalink
              Nils Lundquist added a comment -

              These components no longer have any YUI dependencies and are using the new ice.ace.lazy initialization mechanism.

              Show
              Nils Lundquist added a comment - These components no longer have any YUI dependencies and are using the new ice.ace.lazy initialization mechanism.
              Hide
              Permalink
              Nils Lundquist added a comment -

              Revision #34058
              Committed by nils.lundquist
              Moments ago
              ICE-8944 - Added IE7/8 compatibily code to ice.ace.getEvent.

              Can't reproduce error in Chrome.

              Show
              Nils Lundquist added a comment - Revision #34058 Committed by nils.lundquist Moments ago ICE-8944 - Added IE7/8 compatibily code to ice.ace.getEvent. Can't reproduce error in Chrome.

                People

                • Assignee:
                  Nils Lundquist
                  Reporter:
                  Nils Lundquist
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: