ICEfaces
  1. ICEfaces
  2. ICE-8899

Parameters containing “rvn” lost on redirect

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: EE-1.8.2.GA_P04
    • Fix Version/s: EE-1.8.2.GA_P06
    • Component/s: Bridge, Framework
    • Labels:
      None
    • Environment:
      Seam
    • Assignee Priority:
      P1
    • Salesforce Case Reference:

      Description

      Given the following redirect rule specified in pages.xml:
      <redirect view-id="/xhtml/loginator.xhtml">
      <param name="t1" value="hellorvnworld" />
      <param name="t2" value="RkqF3RW4QZzhF0JrlznFr6d99LOIuMW52h3Vp1dPH8R0007XuIsIgoXjaSCuGD6OIOvECogMjt8=" />
      <param name="t3" value="0000000rvn11111111111" />
      <param name="t4" value="rvn" />
      <param name="t5" value="RVN" />
      <param name="t6" value="RkqF3RW4QZzhF0JrlznFr6d99LOIuMW52h3Vp1dPH8Rvn7XuIsIgoXjaSCuGD6OIOvECogMjt8=" />
      </redirect>

      In this example, a parameter with name “t1” gets lost because its value is “hellorvnworld”, which contains “rvn” as a substring. Parameters t1, t3, and t4 will be null when trying to read the http request parameter after redirect.

      This appears to be due to the following code at com.icesoft.util.SeamUtilities:194:
      while(st.hasMoreTokens() ){
      token = st.nextToken();
      if ( (token.indexOf(conversationIdParameter) == -1) &&
      (token.indexOf(conversationParentParameter) == -1) &&
      token.indexOf("rvn") == -1 ) {

      tokenList.add( token );
      }
      }

      which indiscriminately discards request parameters if “rvn” is found anywhere in the value.

      Note, this will also apply to the string “cid” when used as the conversationIdParameter.

        Activity

        Repository Revision Date User Message
        ICEsoft Public SVN Repository #33400 Wed Feb 13 10:59:07 MST 2013 deryk.sinotte ICE-8899: make parameter checking more strict to avoid false positives for reserved names like "rvn"
        Files Changed
        Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/util/SeamUtilities.java

          People

          • Assignee:
            Deryk Sinotte
            Reporter:
            Arran Mccullough
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: