ICEfaces
  1. ICEfaces
  2. ICE-8884

ace:dataExporter - NPE thrown when closing download window in IE

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.2, EE-3.2.0.BETA
    • Fix Version/s: EE-3.2.0.GA, 3.3
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      IE8, IE7
    • Assignee Priority:
      P1
    • Salesforce Case Reference:

      Description

      In older IE browsers, when the dataExporter button is clicked a new window is opened which facilitates the download of the file. Upon clicking the "Close Window" button an NPE is thrown in the server logs:

      java.lang.NullPointerException
      at java.io.ByteArrayInputStream.<init>(ByteArrayInputStream.java:89)
      at org.icefaces.ace.component.dataexporter.ExporterResource.getInputStream(ExporterResource.java:47)
      at org.icefaces.application.ResourceRegistry.handleResourceRequest(ResourceRegistry.java:152)
      at org.icefaces.impl.application.WindowScopeManager.handleSessionAwareResourceRequest(WindowScopeManager.java:69)
      at org.icefaces.impl.application.SessionAwareResourceHandlerWrapper.handleResourceRequest(SessionAwareResourceHandlerWrapper.java:40)
      at javax.faces.application.ResourceHandlerWrapper.handleResourceRequest(ResourceHandlerWrapper.java:125)
      at org.icefaces.impl.application.SessionTimeoutMonitor.handleSessionAwareResourceRequest(SessionTimeoutMonitor.java:71)
      at org.icefaces.impl.application.SessionAwareResourceHandlerWrapper.handleResourceRequest(SessionAwareResourceHandlerWrapper.java:40)

      This doesn't seem to have a function impact. Also if using the windows close button instead of the link, this issue isn't seen.
      1. Case11872Example.zip
        19 kB
        Arran Mccullough
      2. Case11872ExampleWAR.zip
        9.31 MB
        Arran Mccullough

        Activity

        Arran Mccullough created issue -
        Arran Mccullough made changes -
        Field Original Value New Value
        Salesforce Case Reference 5007000000QXtyOAAT
        Hide
        Arran Mccullough added a comment -

        Attached test case that reproduces the issue.

        Steps:

        • Load welcomeICEfaces.jsf in IE8 or IE7.
        • Click the Export button.
        • A new window is opened, click the link to download the file.
        • Save or cancel the download and click the Close Window link.

        Note: With Tomcat, the error doesn't get displayed in the main server logs but is shown in the localhost log file.

        Show
        Arran Mccullough added a comment - Attached test case that reproduces the issue. Steps: Load welcomeICEfaces.jsf in IE8 or IE7. Click the Export button. A new window is opened, click the link to download the file. Save or cancel the download and click the Close Window link. Note: With Tomcat, the error doesn't get displayed in the main server logs but is shown in the localhost log file.
        Arran Mccullough made changes -
        Attachment Case11872Example.zip [ 15346 ]
        Attachment Case11872ExampleWAR.zip [ 15347 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #33072 Wed Jan 16 11:30:00 MST 2013 art.zambrano ICE-8884 prevented sending a resource request again when closing helper window in IE7
        Files Changed
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/dataexporter/dataexporter.js
        Ken Fyten made changes -
        Fix Version/s EE-3.2.0.GA [ 10332 ]
        Fix Version/s 3.3 [ 10370 ]
        Assignee Arturo Zambrano [ artzambrano ]
        Assignee Priority P1 [ 10010 ]
        Hide
        Arturo Zambrano added a comment -

        Committed fix to trunk at revision 33072. Prevented the default behaviour of the anchor element, in order to avoid sending another resource request when clicking the link to close the window.

        Show
        Arturo Zambrano added a comment - Committed fix to trunk at revision 33072. Prevented the default behaviour of the anchor element, in order to avoid sending another resource request when clicking the link to close the window.
        Arturo Zambrano made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Carmen Cristurean added a comment -

        Verified fix with rev# 33095, in IE7. No issues found.

        Show
        Carmen Cristurean added a comment - Verified fix with rev# 33095, in IE7. No issues found.
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Arturo Zambrano
            Reporter:
            Arran Mccullough
          • Votes:
            1 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: