ICEfaces
  1. ICEfaces
  2. ICE-8877

Problem decoding upload / Problem processing uploaded file

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 3.2
          • Fix Version/s: EE-3.2.0.GA, 3.3
          • Component/s: ACE-Components
          • Labels:
            None
          • Environment:
            All

            Description

            When the multi-part form upload is prematurely stopped, it causes several problems. First of all, trying to add the FacesMessage for the issue will cause a NPE due to trying to access the UIViewRoot's Locale when there is not yet a UIViewRoot. Secondly, the logged message can clutter production logs, and isn't particularly informative. Thirdly, the JSF lifecycle typically can't execute due to necessary form fields not being transmitted as well as the browser ceasing the request and not accepting a response, so there is no real way to inform the user of what happened.

              Activity

              Ascending order - Click to sort in descending order
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #33033 Thu Jan 10 22:28:42 MST 2013 mark.collette ICE-8877 : Problem decoding upload / Problem processing uploaded file
              Files Changed
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/fileentry/FileEntryResourceHandler.java
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/fileentry/FileEntryStatuses.java
              Commit graph ADD /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/util/DeferredLocaleFacesMessage.java
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/util/MessageUtils.java
              Mark Collette created issue -
              Hide
              Permalink
              Mark Collette added a comment -

              There's no real working around the fact that the request is aborted and so there is no response, but it might have helped from changing the logging to happen at WARN instead of SEVERE and only when in Development mode. As well, fixing the NPE allows the Locale to be lazily evaluated at render phase, which has the benefit that if the application is some kind of config user interface where the user is specifying their locale, then the FacesMessages will be made using the newly selected locale and not the stale old one.

              icefaces3 trunk
              Subversion 33033

              Show
              Mark Collette added a comment - There's no real working around the fact that the request is aborted and so there is no response, but it might have helped from changing the logging to happen at WARN instead of SEVERE and only when in Development mode. As well, fixing the NPE allows the Locale to be lazily evaluated at render phase, which has the benefit that if the application is some kind of config user interface where the user is specifying their locale, then the FacesMessages will be made using the newly selected locale and not the stale old one. icefaces3 trunk Subversion 33033
              Ken Fyten made changes -
              Field Original Value New Value
              Fix Version/s 3.3 [ 10370 ]
              Ken Fyten made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Unassigned
                  Reporter:
                  Mark Collette
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: