ICEfaces
  1. ICEfaces
  2. ICE-8872

Regression - file-callback tutorial application compile errors

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.2
    • Fix Version/s: EE-3.2.0.GA, 3.3
    • Component/s: Sample Apps
    • Labels:
      None
    • Environment:
      Icefaces3 trunk revision# 32976
      Server: tomcat6
      Browser: all

      Description

      This tutorial application fails to compile (using Ant), see error bellow - this appears to be an older issue (August 24th), a regression introduced by ICE-7748.

      The Icefaces3 Regressions should have caught this issue (this tutorial must have been assigned a 'skipped' status), however it did not.

      compile:
          [javac] Compiling 3 source files to C:\svn\ossrepo\icefaces3\trunk\icefaces\tutorials\file-callback-tutorial\build\c
      lasses
          [javac] C:\svn\ossrepo\icefaces3\trunk\icefaces\tutorials\file-callback-tutorial\src\main\java\org\icefaces\tutorial
      s\ace\faces\listeners\FileMD5EncodingCallback.java:32: package org.apache.commons.io does not exist
          [javac] import org.apache.commons.io.FilenameUtils;
          [javac] ^
          [javac] C:\svn\ossrepo\icefaces3\trunk\icefaces\tutorials\file-callback-tutorial\src\main\java\org\icefaces\tutorial
      s\ace\faces\listeners\FileMD5EncodingCallback.java:76: cannot find symbol
          [javac] symbol : variable FilenameUtils
          [javac] location: class org.icefaces.tutorials.ace.faces.listeners.FileMD5EncodingCallback
          [javac] if (extensionList.contains(FilenameUtils.getExtension(fileEntryInfo.getFileName()))) {
          [javac] ^
          [javac] C:\svn\ossrepo\icefaces3\trunk\icefaces\tutorials\file-callback-tutorial\src\main\java\org\icefaces\tutorial
      s\ace\faces\listeners\FileMD5EncodingCallback.java:149: cannot find symbol
          [javac] symbol : variable FilenameUtils
          [javac] location: class org.icefaces.tutorials.ace.faces.listeners.FileMD5EncodingCallback.InvalidFileStatus
          [javac] FilenameUtils.getExtension(fileInfo.getFileName()));
          [javac] ^
          [javac] Note: C:\svn\ossrepo\icefaces3\trunk\icefaces\tutorials\file-callback-tutorial\src\main\java\org\icefaces\tu
      torials\util\FacesUtils.java uses or overrides a deprecated API.
          [javac] Note: Recompile with -Xlint:deprecation for details.
          [javac] 3 errors

        Activity

        Carmen Cristurean created issue -
        Ken Fyten made changes -
        Field Original Value New Value
        Assignee Mark Collette [ mark.collette ]
        Fix Version/s 3.3 [ 10370 ]
        Assignee Priority P1 [ 10010 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #33029 Thu Jan 10 16:38:37 MST 2013 mark.collette ICE-8872 : Regression - file-callback tutorial application compile errors
        Files Changed
        Commit graph MODIFY /icefaces3/trunk/icefaces/tutorials/file-callback-tutorial/pom.xml
        Commit graph ADD /icefaces3/trunk/icefaces/tutorials/file-callback-tutorial/lib/commons-io-1.4.jar
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #33030 Thu Jan 10 20:02:37 MST 2013 mark.collette ICE-8872 : Regression - file-callback tutorial application compile errors
        Files Changed
        Commit graph ADD /icefaces3/trunk/icefaces/tutorials/file-callback-tutorial/src/main/resources/messages_en.properties
        Commit graph DEL /icefaces3/trunk/icefaces/tutorials/file-callback-tutorial/src/main/java/messages_en.properties
        Hide
        Mark Collette added a comment -

        The FilenameUtils class is from Apache Commons I/O, which does not exist in the icefaces/lib folder, nor this tutorial's lib folder, nor is it mentioned as a dependency in the Maven POM. So, I added it to this tutorial's lib folder and the Maven POM.

        icefaces3 trunk
        Subversion 33029

        Show
        Mark Collette added a comment - The FilenameUtils class is from Apache Commons I/O, which does not exist in the icefaces/lib folder, nor this tutorial's lib folder, nor is it mentioned as a dependency in the Maven POM. So, I added it to this tutorial's lib folder and the Maven POM. icefaces3 trunk Subversion 33029
        Mark Collette made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s EE-3.2.0.GA [ 10332 ]
        Resolution Fixed [ 1 ]
        Mark Collette made changes -
        Security Private [ 10001 ]
        Hide
        Ken Fyten added a comment -

        Please update the .zip tutorial files on the Tutorial wiki page as well.

        Show
        Ken Fyten added a comment - Please update the .zip tutorial files on the Tutorial wiki page as well.
        Ken Fyten made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Hide
        Mark Collette added a comment -

        There was a run-time problem with a messages_en.properties file not being included in the jar by the ant build. This was because it was in the src/main/java folder when it needed to be in the src/main/resources folder.

        icefaces3 trunk
        Subversion 33030

        Show
        Mark Collette added a comment - There was a run-time problem with a messages_en.properties file not being included in the jar by the ant build. This was because it was in the src/main/java folder when it needed to be in the src/main/resources folder. icefaces3 trunk Subversion 33030
        Hide
        Carmen Cristurean added a comment -

        Verified fix with rev# 33030 in all major browsers.

        Show
        Carmen Cristurean added a comment - Verified fix with rev# 33030 in all major browsers.
        Ken Fyten made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Assignee Priority P1 [ 10010 ]
        Resolution Fixed [ 1 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #33047 Sun Jan 13 23:11:55 MST 2013 mark.collette ICE-8872 : Regression - file-callback tutorial application compile errors
        Files Changed
        Commit graph MODIFY /icefaces3/trunk/icefaces/tutorials/file-callback-tutorial/pom.xml
        Hide
        Mark Collette added a comment -

        Updated Maven pom.xml file to use ICEfaces 3.2 and Mojarra 2.1.6

        icefaces3 trunk
        Subversion 33047

        Show
        Mark Collette added a comment - Updated Maven pom.xml file to use ICEfaces 3.2 and Mojarra 2.1.6 icefaces3 trunk Subversion 33047
        Hide
        Mark Collette added a comment -

        Updated the tutorial wiki's attached example to contain the new code.

        http://www.icesoft.org/wiki/display/ICE/Incremental+Upload+Processing+Using+FileEntryCallback

        Show
        Mark Collette added a comment - Updated the tutorial wiki's attached example to contain the new code. http://www.icesoft.org/wiki/display/ICE/Incremental+Upload+Processing+Using+FileEntryCallback
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Mark Collette
            Reporter:
            Carmen Cristurean
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: