ICEfaces
  1. ICEfaces
  2. ICE-8840

icecore:refresh hitting multiple pages

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: EE-3.0.0.GA_P01, 3.2
    • Fix Version/s: EE-3.2.0.GA, 3.3
    • Component/s: ICE-Components
    • Labels:
      None
    • Environment:
      Tomcat 7.0.14, Firefox, Chrome, IE
    • Assignee Priority:
      P1

      Description

      To reproduce:
      1. uncomment icecore:refresh tag on start.xhtml page in attached source code
      2. run sample application
      3. Open for example start.xhtml in Chrome & start2.xhtml in IE or Firefox

      ISSUE: After some time specified in the interval parameter of the tag you should be able to see page refreshes in both browsers due to the presence of icecore:refresh tag on start.xhtml page. (request scoped beans will be re-initialized in both browsers)

      Setting interval="0" duration="0" for the tag does not stop this behavior

        Activity

        Evgheni Sadovoi created issue -
        Evgheni Sadovoi made changes -
        Field Original Value New Value
        Attachment sampleSourceCode.zip [ 15187 ]
        Ken Fyten made changes -
        Fix Version/s EE-3.2.0.GA [ 10332 ]
        Fix Version/s 3.3 [ 10370 ]
        Ken Fyten made changes -
        Assignee Ted Goddard [ ted.goddard ]
        Ken Fyten made changes -
        Assignee Priority P2 [ 10011 ]
        Ted Goddard made changes -
        Assignee Ted Goddard [ ted.goddard ] Jack Van Ooststroom [ jack.van.ooststroom ]
        Hide
        Ted Goddard added a comment -

        Assigning to Jack (to work on after the ICEpush backoff and cloud push implementations).

        Show
        Ted Goddard added a comment - Assigning to Jack (to work on after the ICEpush backoff and cloud push implementations).
        Ken Fyten made changes -
        Assignee Jack Van Ooststroom [ jack.van.ooststroom ] Ted Goddard [ ted.goddard ]
        Assignee Priority P2 [ 10011 ] P1 [ 10010 ]
        Ted Goddard made changes -
        Assignee Ted Goddard [ ted.goddard ] Evgheni Sadovoi [ evgheni.sadovoi ]
        Hide
        Ted Goddard added a comment -

        Please attach a .war file that runs on tomcat and assign back to me.

        Show
        Ted Goddard added a comment - Please attach a .war file that runs on tomcat and assign back to me.
        Hide
        Evgheni Sadovoi added a comment -

        Unzip case11783 file to get deployable .war file

        Show
        Evgheni Sadovoi added a comment - Unzip case11783 file to get deployable .war file
        Evgheni Sadovoi made changes -
        Attachment Case11783.zip [ 15333 ]
        Evgheni Sadovoi made changes -
        Assignee Evgheni Sadovoi [ evgheni.sadovoi ] Ted Goddard [ ted.goddard ]
        Hide
        Ted Goddard added a comment -

        Both start.jsf and start2.jsf are being refreshed: this appears to be working as expected.

        Show
        Ted Goddard added a comment - Both start.jsf and start2.jsf are being refreshed: this appears to be working as expected.
        Ted Goddard made changes -
        Assignee Ted Goddard [ ted.goddard ] Evgheni Sadovoi [ evgheni.sadovoi ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #33039 Fri Jan 11 14:49:41 MST 2013 ted.goddard icecore:refresh taghandler now adding component directly to viewroot (ICE-8840)
        Files Changed
        Commit graph MODIFY /icefaces3/trunk/icefaces/core/src/main/java/org/icefaces/impl/facelets/tag/icefaces/core/RefreshHandler.java
        Hide
        Ted Goddard added a comment -

        The pages are as follows:

        • start.jsf contains an icecore:refresh tag
        • start2.jsf does not contain an icecore:refresh tag

        When start2.jsf is loaded after start.jsf (even in a different browser) start2.jsf will be automatically refreshed.

        Show
        Ted Goddard added a comment - The pages are as follows: start.jsf contains an icecore:refresh tag start2.jsf does not contain an icecore:refresh tag When start2.jsf is loaded after start.jsf (even in a different browser) start2.jsf will be automatically refreshed.
        Hide
        Ted Goddard added a comment -

        RefreshHandler is implemented as an Application Scope SystemEvent listener, causing it to be incorrectly applied to all pages once activated.

        Show
        Ted Goddard added a comment - RefreshHandler is implemented as an Application Scope SystemEvent listener, causing it to be incorrectly applied to all pages once activated.
        Hide
        Ted Goddard added a comment -

        The following fix is checked in: rather than add a JavaScript output component from a global SystemEventListener, the TagHandler for this feature is now adding a transient component directly to the ViewRoot. The TagHandler has been modified so that different instances should pick up different configuration parameters, but this suspected bug in the original implementation has not been confirmed or tested. The fixed implementation has been verified to work as desired with the provided test case.

        Show
        Ted Goddard added a comment - The following fix is checked in: rather than add a JavaScript output component from a global SystemEventListener, the TagHandler for this feature is now adding a transient component directly to the ViewRoot. The TagHandler has been modified so that different instances should pick up different configuration parameters, but this suspected bug in the original implementation has not been confirmed or tested. The fixed implementation has been verified to work as desired with the provided test case.
        Ted Goddard made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Evgheni Sadovoi
            Reporter:
            Evgheni Sadovoi
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: