ICEfaces
  1. ICEfaces
  2. ICE-8833

Session leak in SessionMonitors

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: EE-1.8.2.GA_P05
    • Fix Version/s: EE-1.8.2.GA_P06
    • Component/s: None
    • Labels:
      None
    • Environment:
      icefaces-1.8.2 revision 32630 from trunk, tomcat 6.0.32, jdk 1.6_027
    • Assignee Priority:
      P2

      Description

      SessionDispatcher do not remove invalidated sessions from Map.
      In worst case users notice thousands of unused session objects (some old Jira issues I saw here).
      I attached file SessionDispatcher.java with additional logger messages.

      Test case.
      Prepare app with form-login for basic authentication and logout button.
      If you logon and logout few times 'Session Monitor session count' grows and many 'session already invalidated' messages occurs every 10 seconds..

      The main reason is line:
         iterator = new ArrayList(SessionMonitors.values()).iterator();
      Session cleaner do not clean correct list.
      After change to
         iterator = SessionMonitors.values().iterator();
      everything seems to be ok and sessions are removed.
      1. SessionDispatcher.java
        21 kB
        Krashan Brahmanjara
      2. SessionDispatcher.java
        20 kB
        Krashan Brahmanjara
      3. SessionDispatcher.java
        20 kB
        Krashan Brahmanjara
      4. sessionerrors.txt
        4 kB
        Krashan Brahmanjara
      5. sessionlog.txt
        2 kB
        Krashan Brahmanjara
      6. sessionlog2.txt
        3 kB
        Krashan Brahmanjara
      7. sessionlog3.txt
        3 kB
        Krashan Brahmanjara
      8. web.xml
        11 kB
        Krashan Brahmanjara
      1. sessionproblems.PNG
        85 kB

        Activity

        Krashan Brahmanjara created issue -
        Krashan Brahmanjara made changes -
        Field Original Value New Value
        Attachment SessionDispatcher.java [ 15126 ]
        Krashan Brahmanjara made changes -
        Attachment sessionlog.txt [ 15127 ]
        Krashan Brahmanjara made changes -
        Attachment sessionlog2.txt [ 15128 ]
        Krashan Brahmanjara made changes -
        Attachment SessionDispatcher.java [ 15129 ]
        Krashan Brahmanjara made changes -
        Attachment sessionlog3.txt [ 15130 ]
        Krashan Brahmanjara made changes -
        Attachment sessionproblems.PNG [ 15131 ]
        Ken Fyten made changes -
        Affects Version/s EE-1.8.2.GA_P05 [ 10331 ]
        Ken Fyten made changes -
        Assignee Mircea Toma [ mircea.toma ]
        Assignee Priority P2 [ 10011 ]
        Mircea Toma made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Krashan Brahmanjara made changes -
        Attachment sessionerrors.txt [ 15302 ]
        Krashan Brahmanjara made changes -
        Attachment SessionDispatcher.java [ 15303 ]
        Deryk Sinotte made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Krashan Brahmanjara made changes -
        Attachment web.xml [ 15309 ]
        Ken Fyten made changes -
        Fix Version/s EE-1.8.2.GA_P06 [ 10470 ]
        Mircea Toma made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Mircea Toma
            Reporter:
            Krashan Brahmanjara
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: