ICEfaces
  1. ICEfaces
  2. ICE-8780

ace:tabSet label facet ace:pushButton causes second submit

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.2
    • Fix Version/s: 3.3
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      All browsers

      Description


      In the QA tabSet test app, with page facet/serverSideFacets.xhtml the third tabPane uses an ace:pushButton in the label facet, and when it is clicked, it causes two submits, the first for the pushButton and the second for changing to that tabPane.

        Activity

        Repository Revision Date User Message
        ICEsoft Public SVN Repository #32217 Mon Nov 19 05:54:34 MST 2012 mark.collette ICE-8780 : ace:tabSet label facet ace:pushButton causes second submit
        Files Changed
        Commit graph MODIFY /icefaces3/trunk/icefaces/compat/core/src/main/javascript/extras/extras.js
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/util/util.js
        Migration created issue -
        Hide
        Mark Collette added a comment - - edited

        Initially I thought that the label facet might be missing functionality called toggleOnInput=false in other components, which is when a clickable area in a container component may contain other components, and those include input or command components, then the click on the input or command component should not cause the activation of the container's clickable area. But it turned out that this functionality was in place, it just had an oversight of not handling the ace:pushButton case, which is for the element to be of type 'button'. Other compat code, that provides similar functionality for ice:panelCollapsible and ice:rowSelector, was found to be similarly deficient, by code auditing. Both the ACE and ICE codes were fixed to handle 'button' elements.
        icefaces3 trunk
        Subversion 32217

        Show
        Mark Collette added a comment - - edited Initially I thought that the label facet might be missing functionality called toggleOnInput=false in other components, which is when a clickable area in a container component may contain other components, and those include input or command components, then the click on the input or command component should not cause the activation of the container's clickable area. But it turned out that this functionality was in place, it just had an oversight of not handling the ace:pushButton case, which is for the element to be of type 'button'. Other compat code, that provides similar functionality for ice:panelCollapsible and ice:rowSelector, was found to be similarly deficient, by code auditing. Both the ACE and ICE codes were fixed to handle 'button' elements. icefaces3 trunk Subversion 32217
        Hide
        Mark Collette added a comment - - edited

        Assignee: Mark Collette
        Resolution: Fixed

        Show
        Mark Collette added a comment - - edited Assignee: Mark Collette Resolution: Fixed
        Migration made changes -
        Field Original Value New Value
        Reporter Migration [ remote ] Mark Collette [ mark.collette ]
        Migration made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Mark Collette
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: