ICEfaces
  1. ICEfaces
  2. ICE-8778

Contents of menu components are visible before initializing component

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.2
    • Fix Version/s: EE-3.2.0.GA, 3.3
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      Any
    • Salesforce Case Reference:

      Description


      On slow browsers, such as IE8, and/or if the page has too many contents, the raw markup of the menu components, defining menu items and submenus, is initially visible until the browser gets to the point of running the initialization script for the menu, where all the styling and behaviour are applied. This could be prevented by simply rendering the markup initially invisible and then remove such styling during the initialization of the component in the client.

        Activity

        Migration created issue -
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #32232 Mon Nov 19 17:00:42 MST 2012 art.zambrano ICE-8778 the menu renderers were modified to always render the markup with 'display:none;', in order to avoid showing the raw unordered list on the page before it's initialized by the script; the scripts were modified to remove this piece of styling once the components have been initialized
        Files Changed
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/menu/MenuRenderer.java
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/menu/menu.js
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/contextmenu/ContextMenuRenderer.java
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/menubar/MenuBarRenderer.java
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/menubutton/MenuButtonRenderer.java
        Hide
        Arturo Zambrano added a comment - - edited

        Committed fix to trunk at revision 32232.
        The menu renderers were modified to always render the markup with 'display:none;', in order to avoid showing the raw unordered list on the page before it's initialized by the script; the scripts were modified to remove this piece of styling once the components have been initialized.

        Show
        Arturo Zambrano added a comment - - edited Committed fix to trunk at revision 32232. The menu renderers were modified to always render the markup with 'display:none;', in order to avoid showing the raw unordered list on the page before it's initialized by the script; the scripts were modified to remove this piece of styling once the components have been initialized.
        Hide
        Arturo Zambrano added a comment - - edited

        Testing notes: Just make sure that everything keeps working normally for all the 4 menu components and that there are no regressions in all browsers.
        Also, the raw unordered list that represents the structure of the menu should not be visible as such (i.e. without styling) when first loading the page, since that was the motivation of this JIRA. Actually, I was never able to see this problem on my machine or on the test machines. I also tried to reproduce this on the Williams POC, and it didn't happen. If Williams reports this issue again, then we'll know that it might be related to something they are doing on their application or pages.
        (Restricted to icesoft-internal-developers group)

        Show
        Arturo Zambrano added a comment - - edited Testing notes: Just make sure that everything keeps working normally for all the 4 menu components and that there are no regressions in all browsers. Also, the raw unordered list that represents the structure of the menu should not be visible as such (i.e. without styling) when first loading the page, since that was the motivation of this JIRA. Actually, I was never able to see this problem on my machine or on the test machines. I also tried to reproduce this on the Williams POC, and it didn't happen. If Williams reports this issue again, then we'll know that it might be related to something they are doing on their application or pages. (Restricted to icesoft-internal-developers group)
        Migration made changes -
        Field Original Value New Value
        Reporter Migration [ remote ] Arturo Zambrano [ artzambrano ]
        Migration made changes -
        Assignee Arturo Zambrano [ artzambrano ]
        Migration made changes -
        Fix Version/s EE-3.2.0.GA [ 10332 ]
        Affects Version/s 3.2 [ 10338 ]
        Migration made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Migration made changes -
        Fix Version/s 3.3 [ 10370 ]
        Fix Version/s EE-3.2.0.GA [ 10332 ]
        Migration made changes -
        Fix Version/s EE-3.2.0.GA [ 10332 ]
        Fix Version/s 3.3 [ 10370 ]
        Migration made changes -
        Fix Version/s 3.3 [ 10370 ]
        Fix Version/s EE-3.2.0.GA [ 10332 ]
        Arran Mccullough made changes -
        Salesforce Case Reference 5007000000PVfRnAAL
        Ken Fyten made changes -
        Fix Version/s EE-3.2.0.GA [ 10332 ]
        Ken Fyten made changes -
        Issue Type Improvement [ 4 ] Bug [ 1 ]
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Arturo Zambrano
            Reporter:
            Arturo Zambrano
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: