Details
-
Type: Improvement
-
Status: Closed
-
Priority: Major
-
Resolution: Fixed
-
Affects Version/s: 3.2
-
Fix Version/s: 3.3
-
Component/s: ACE-Components
-
Labels:None
-
Environment:ICEfaces
-
Assignee Priority:P2
Description
Many components make use of complex JavaScript in addition to HTML and CSS. The use of this JavaScript and its initialization and cleanup should be optimized, particularly for components that are used repeatedly in a datatable.
Activity
Migration
created issue -
Migration
made changes -
Field | Original Value | New Value |
---|---|---|
Reporter | Migration [ remote ] | Ted Goddard [ ted.goddard ] |
Migration
made changes -
Fix Version/s | EE-3.2.0.GA [ 10332 ] |
Ken Fyten
made changes -
Fix Version/s | 3.3 [ 10370 ] | |
Fix Version/s | EE-3.2.0.GA [ 10332 ] |
Ken Fyten
made changes -
Summary | Optimize component initialization and cleanup | Optimize onElementUpdate implementation |
Ken Fyten
made changes -
Assignee | Mircea Toma [ mircea.toma ] | |
Assignee Priority | P2 [ 10011 ] |
Repository | Revision | Date | User | Message |
ICEsoft Public SVN Repository | #33253 | Mon Jan 28 15:39:15 MST 2013 | mircea.toma | |
Files Changed | ||||
MODIFY
/icefaces3/trunk/icefaces/core/src/main/javascript/application.js
|
Mircea Toma
made changes -
Status | Open [ 1 ] | Resolved [ 5 ] |
Resolution | Fixed [ 1 ] |
Ken Fyten
made changes -
Status | Resolved [ 5 ] | Closed [ 6 ] |
The current cleanup code contains the following which Mark has observed has an unnecessary var element = document.getElementById(id). This has not been removed, however, since it is possible that idCallbackTuple.handler assumes the existence of the element:
elementUpdateListeners = reject(elementUpdateListeners, function(idCallbackTuple) {
var id = idCallbackTuple.identifier;
var element = document.getElementById(id);
//test if inner element still exists, sometimes client side code can remove DOM fragments
if (element) {
var updated = (-1 !=
idCallbackTuple.ancestors.indexOf(" " + updatedElementId + " "));
if (updated) {
var callback = idCallbackTuple.handler;