ICEfaces
  1. ICEfaces
  2. ICE-8752

Add ARIA role and attributes to SliderEntry

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: EE-3.2.0.BETA, EE-3.2.0.GA, 3.3
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      ACE Components.
    • Affects:
      Documentation (User Guide, Ref. Guide, etc.), Compatibility/Configuration

      Description

      Add ARIA role and attributes to SliderEntry.

      For faces-qa:

      Testing instructions: http://jira.icesoft.org/browse/ICE-8695?focusedCommentId=44147&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-44147

      Complications: http://jira.icesoft.org/browse/ICE-8695?focusedCommentId=43470&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-43470

      Implemented attributes: role, aria-orientation, aria-valuemax, aria-valuemin, aria-valuenow, aria-valuetext.
                              (Restricted to icesoft-internal-developers group)

        Activity

        Repository Revision Date User Message
        ICEsoft Public SVN Repository #32028 Tue Nov 06 15:40:23 MST 2012 yip.ng ICE-8752: Add ARIA role and attributes to SliderEntry.
        Files Changed
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/jquery/ui/jquery-ui.js
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/sliderentry/SliderEntryRenderer.java
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/jquery/ui/readme.txt
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #32048 Wed Nov 07 15:56:41 MST 2012 yip.ng ICE-8752: Add ARIA role and attributes to SliderEntry.
        Files Changed
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/sliderentry/SliderEntryRenderer.java
        Hide
        Carmen Cristurean added a comment - - edited

        The change made to this file: http://server.ice:8888/svn/ossrepo/icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/jquery/ui/jquery-ui.js
        causes 1) all ACE components, and 2) all tutorials tests to fail in automation (Selenium TestRunner), screen shot and server log attached:
        1) New failures: All ACE components (All Browsers) - when selenium initially loads the testsuite for each ace component, the first test fails due to an HTTP 500 error (see attached image and server log txt file); Passes when running on selenium IDE or re-running manually; all other tests in testSuites pass except for the aforementioned failing first test.
        2) Tutorial test results
        New failures: All tutorials (Chrome Browser): when selenium initially loads the testsuite for each ace component, the first test fails due to an http 500 error (see attached image and server log txt file); Passes when running on selenium IDE or re-running manually; note that the failure affects the first browser to run the application, in which most cases, Google Chrome. This is verified as most of the tutorials' results in IE and FF have passed.
        For the ACE tests failures, the server side error that occurs when the first test is loaded in TestRunner is:
        Nov 7, 2012 10:29:51 AM org.apache.catalina.core.StandardWrapperValve invoke
        SEVERE: Servlet.service() for servlet Faces Servlet threw exception
        java.lang.NullPointerException
        at javax.faces.component.UIViewRoot$ViewMap.clear(UIViewRoot.java:1779)
        at com.sun.faces.config.InitFacesContext.release(InitFacesContext.java:239)
        at javax.faces.webapp.FacesServlet.service(FacesServlet.java:577)
        at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290)
        at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
        at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233)
        at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:191)
        at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:127)
        at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102)
        at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109)
        at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:298)
        at org.apache.coyote.http11.Http11AprProcessor.process(Http11AprProcessor.java:859)
        at org.apache.coyote.http11.Http11AprProtocol$Http11ConnectionHandler.process(Http11AprProtocol.java:579)
        at org.apache.tomcat.util.net.AprEndpoint$Worker.run(AprEndpoint.java:1555)
        at java.lang.Thread.run(Thread.java:619)

        Show
        Carmen Cristurean added a comment - - edited The change made to this file: http://server.ice:8888/svn/ossrepo/icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/jquery/ui/jquery-ui.js causes 1) all ACE components, and 2) all tutorials tests to fail in automation (Selenium TestRunner), screen shot and server log attached: 1) New failures: All ACE components (All Browsers) - when selenium initially loads the testsuite for each ace component, the first test fails due to an HTTP 500 error (see attached image and server log txt file); Passes when running on selenium IDE or re-running manually; all other tests in testSuites pass except for the aforementioned failing first test. 2) Tutorial test results New failures: All tutorials (Chrome Browser): when selenium initially loads the testsuite for each ace component, the first test fails due to an http 500 error (see attached image and server log txt file); Passes when running on selenium IDE or re-running manually; note that the failure affects the first browser to run the application, in which most cases, Google Chrome. This is verified as most of the tutorials' results in IE and FF have passed. For the ACE tests failures, the server side error that occurs when the first test is loaded in TestRunner is: Nov 7, 2012 10:29:51 AM org.apache.catalina.core.StandardWrapperValve invoke SEVERE: Servlet.service() for servlet Faces Servlet threw exception java.lang.NullPointerException at javax.faces.component.UIViewRoot$ViewMap.clear(UIViewRoot.java:1779) at com.sun.faces.config.InitFacesContext.release(InitFacesContext.java:239) at javax.faces.webapp.FacesServlet.service(FacesServlet.java:577) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233) at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:191) at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:127) at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102) at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109) at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:298) at org.apache.coyote.http11.Http11AprProcessor.process(Http11AprProcessor.java:859) at org.apache.coyote.http11.Http11AprProtocol$Http11ConnectionHandler.process(Http11AprProtocol.java:579) at org.apache.tomcat.util.net.AprEndpoint$Worker.run(AprEndpoint.java:1555) at java.lang.Thread.run(Thread.java:619)
        Hide
        yip.ng added a comment - - edited

        The changes in jquery-ui.js just add some extra ARIA attributes to the slider handle element. Don't see how it can cause ViewRoot exception. Don't know where to start looking if I can't reproduce it on my machine.

        Show
        yip.ng added a comment - - edited The changes in jquery-ui.js just add some extra ARIA attributes to the slider handle element. Don't see how it can cause ViewRoot exception. Don't know where to start looking if I can't reproduce it on my machine.
        Migration created issue -
        Migration made changes -
        Field Original Value New Value
        Attachment ACE regrs selenium error.JPG [ 14927 ]
        Migration made changes -
        Assignee Carmen Cristurean [ ccristurean ]
        Migration made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Ken Fyten made changes -
        Summary Placeholder issue Add ARIA role and attributes to SliderEntry
        Issue Type Bug [ 1 ] Improvement [ 4 ]
        Security Private [ 10001 ]
        Fix Version/s EE-3.2.0.GA [ 10332 ]
        Fix Version/s 3.3 [ 10370 ]
        Reporter Migration [ remote ] Ken Fyten [ ken.fyten ]
        Environment Test ACE Components.
        Description Placeholder issue Add ARIA role and attributes to SliderEntry.
        Component/s ACE-Components [ 10050 ]
        Ken Fyten made changes -
        Description Add ARIA role and attributes to SliderEntry. Add ARIA role and attributes to SliderEntry.

        For faces-qa:

        Testing instructions: http://jira.icesoft.org/browse/ICE-8695?focusedCommentId=44147&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-44147

        Complications: http://jira.icesoft.org/browse/ICE-8695?focusedCommentId=43470&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-43470

        Implemented attributes: role, aria-orientation, aria-valuemax, aria-valuemin, aria-valuenow, aria-valuetext.
                                (Restricted to icesoft-internal-developers group)
        Affects Documentation (User Guide, Ref. Guide, etc.),Compatibility/Configuration [ 10003, 10002 ]
        yip.ng made changes -
        Link This issue blocks ICE-8695 [ ICE-8695 ]
        Ken Fyten made changes -
        Fix Version/s EE-3.2.0.BETA [ 10573 ]
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Carmen Cristurean
            Reporter:
            Ken Fyten
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: