ICEfaces
  1. ICEfaces
  2. ICE-8714

Showcase: ace:gMap - Directions (deltaSubmit specific failure)

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Won't Fix
    • Affects Version/s: 3.2.BETA1
    • Fix Version/s: EE-3.2.0.GA, 3.3
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      Icefaces3/trunk revision# 31809
    • Affects:
      Compatibility/Configuration

      Description


      1) Load showcase sample application configured with org.icefaces.deltaSubmit = true.
      2) Navigate to ace:gMap - Directions page
      3) Type some new directions into the field and submit
      The map and the direction list are not updated.

        Activity

        Migration created issue -
        Migration made changes -
        Field Original Value New Value
        Reporter Migration [ remote ] Cruz Miraback [ cmiraback ]
        Ken Fyten made changes -
        Assignee Mircea Toma [ mircea.toma ]
        Security Private [ 10001 ]
        Fix Version/s EE-3.2.0.GA [ 10332 ]
        Fix Version/s 3.3 [ 10370 ]
        Assignee Priority P2 [ 10011 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #32938 Wed Jan 02 12:31:55 MST 2013 mircea.toma ICE-8714 Modified DOMResponseWriter.write() method to try to parse the passed in string since some renderers write directly to the outputstream. Also changed the calculation of previous parameters for select elements to pick the first option in case none of the options are marked as selected thus matching browser's behaviour.
        Files Changed
        Commit graph MODIFY /icefaces3/trunk/icefaces/core/src/main/java/org/icefaces/impl/event/DeltaSubmitPhaseListener.java
        Commit graph MODIFY /icefaces3/trunk/icefaces/core/src/main/java/org/icefaces/impl/context/DOMResponseWriter.java
        Hide
        Mircea Toma added a comment -

        The issue caused by the MenuRenderer who is rendering the option tags directly to the output stream. Because of that DeltaSubmitPhaseListener cannot calculate the previous parameters off the 'select' elements.

        Modified DOMResponseWriter.write() method to try to parse the passed in string since some renderers write directly to the outputstream. Also changed the calculation of previous parameters for select elements to pick the first option in case none of the options are marked as selected thus matching browser's behaviour.

        Show
        Mircea Toma added a comment - The issue caused by the MenuRenderer who is rendering the option tags directly to the output stream. Because of that DeltaSubmitPhaseListener cannot calculate the previous parameters off the 'select' elements. Modified DOMResponseWriter.write() method to try to parse the passed in string since some renderers write directly to the outputstream. Also changed the calculation of previous parameters for select elements to pick the first option in case none of the options are marked as selected thus matching browser's behaviour.
        Mircea Toma made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #32997 Tue Jan 08 15:53:33 MST 2013 mircea.toma ICE-8714 Revert changes made to DOMResponseWRiter.write method.
        Files Changed
        Commit graph MODIFY /icefaces3/trunk/icefaces/core/src/main/java/org/icefaces/impl/context/DOMResponseWriter.java
        Hide
        Ken Fyten added a comment -

        It has been determined that adding this much complexity and potential performance hit simple to support the poorly implemented h:selectOneMenu component when in deltaSubmit mode doesn't make much sense.

        Instead, we will document that the h:selectOneMenu component isn't supported in deltaSubmit=true mode, and offer alternatives.

        Show
        Ken Fyten added a comment - It has been determined that adding this much complexity and potential performance hit simple to support the poorly implemented h:selectOneMenu component when in deltaSubmit mode doesn't make much sense. Instead, we will document that the h:selectOneMenu component isn't supported in deltaSubmit=true mode, and offer alternatives.
        Ken Fyten made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Assignee Priority P2 [ 10011 ] P1 [ 10010 ]
        Ken Fyten made changes -
        Link This issue blocks ICE-8867 [ ICE-8867 ]
        Hide
        Mircea Toma added a comment -

        Reverted changes made to DOMresponseWriter.write method, the method will not try to parse the paseed in string anymore.

        Show
        Mircea Toma added a comment - Reverted changes made to DOMresponseWriter.write method, the method will not try to parse the paseed in string anymore.
        Mircea Toma made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Ken Fyten made changes -
        Link This issue blocks ICE-8856 [ ICE-8856 ]
        Ken Fyten made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Hide
        Ken Fyten added a comment -

        As this issue is a result of none-standard rendering technique employed by the h:selectOneMenu component, and the solution is too complex, inefficient, and fragile to justify given that the issue only affects h:selectOneMenu when used in deltaSubmit=true mode, we will not fix this issue.

        Work-arounds are to use another component such as ace:list or ice:selectOneMenu instead. This has been documented as a Known Issue in the 3.2 release notes.

        We will also not modify the gmap demo at this time to accommodate.

        Show
        Ken Fyten added a comment - As this issue is a result of none-standard rendering technique employed by the h:selectOneMenu component, and the solution is too complex, inefficient, and fragile to justify given that the issue only affects h:selectOneMenu when used in deltaSubmit=true mode, we will not fix this issue. Work-arounds are to use another component such as ace:list or ice:selectOneMenu instead. This has been documented as a Known Issue in the 3.2 release notes. We will also not modify the gmap demo at this time to accommodate.
        Ken Fyten made changes -
        Status Reopened [ 4 ] Closed [ 6 ]
        Affects Compatibility/Configuration [ 10002 ]
        Assignee Priority P1 [ 10010 ]
        Resolution Won't Fix [ 2 ]
        Security Private [ 10001 ]

          People

          • Assignee:
            Mircea Toma
            Reporter:
            Cruz Miraback
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: