ICEfaces
  1. ICEfaces
  2. ICE-8655

New ace:message and ace:messages components

          Details

          • Type: New Feature New Feature
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 3.2.BETA1
          • Fix Version/s: 3.3
          • Component/s: ACE-Components
          • Labels:
            None
          • Environment:
            ICEfaces
          • Assignee Priority:
            P1
          • Affects:
            Documentation (User Guide, Ref. Guide, etc.), Sample App./Tutorial

            Description


            By providing ace:message and ace:messages it would be possible to both offer new features (such as improved styling for messages) and corrected behavior (such as always rendering an HTML root node with the clientID).

            1. Text File
              Document3.txt
              27 kB
              yip.ng
            1. screenshot-01.png
              20 kB
            2. screenshot-02.png
              309 kB
            3. screenshot-03.png
              160 kB
            4. screenshot-04.png
              239 kB
            5. screenshot-05.png
              114 kB
            6. screenshot-06.png
              222 kB
            7. screenshot-07.png
              249 kB
            8. screenshot-08.png
              117 kB
            9. screenshot-09.png
              239 kB
            10. screenshot-10.png
              315 kB

              Activity

              Ascending order - Click to sort in descending order
              Migration created issue -
              Migration made changes -
              Field Original Value New Value
              Reporter Migration [ remote ] Ted Goddard [ ted.goddard ]
              Migration made changes -
              Assignee Ken Fyten [ ken.fyten ]
              Migration made changes -
              Fix Version/s 3.3 [ 10370 ]
              Ken Fyten made changes -
              Assignee Ken Fyten [ ken.fyten ] Mark Collette [ mark.collette ]
              Affects Documentation (User Guide, Ref. Guide, etc.),Sample App./Tutorial [ 10003, 10001 ]
              Assignee Priority P2 [ 10011 ]
              Ken Fyten made changes -
              Link This issue blocks ICE-8863 [ ICE-8863 ]
              Ken Fyten made changes -
              Assignee Priority P2 [ 10011 ] P1 [ 10010 ]
              Ken Fyten made changes -
              Assignee Mark Collette [ mark.collette ] yip.ng [ yip.ng ]
              Hide
              Permalink
              yip.ng added a comment - - edited

              Decisions from meeting:

              • Forget about Mojarra classes (HtmlMessage, HtmlMessages, MessageRenderer, MessagesRenderer, HtmlBasicRenderer) and start from scratch. (In 1.8 we had our own DomBasicRenderer. We just extended the component classes and copied the renderer classes to make essential changes.)
              • Ignore the accessory methods and logic from HtmlBasicRenderer and focus on rendering the messages.
              • Styling should use style sheets as created by ThemeRoller, not user-specified style classes, i.e. abandon attributes like errorClass, errorStyle, infoClass, infoStyle, etc.
              Show
              yip.ng added a comment - - edited Decisions from meeting: Forget about Mojarra classes (HtmlMessage, HtmlMessages, MessageRenderer, MessagesRenderer, HtmlBasicRenderer) and start from scratch. (In 1.8 we had our own DomBasicRenderer. We just extended the component classes and copied the renderer classes to make essential changes.) Ignore the accessory methods and logic from HtmlBasicRenderer and focus on rendering the messages. Styling should use style sheets as created by ThemeRoller, not user-specified style classes, i.e. abandon attributes like errorClass, errorStyle, infoClass, infoStyle, etc.
              yip.ng made changes -
              Attachment screenshot-01.png [ 15385 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #33255 Mon Jan 28 16:48:22 MST 2013 yip.ng ICE-8655: ace:message and ace:messages.
              Files Changed
              Commit graph ADD /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/message
              Commit graph ADD /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/message/MessageMeta.java
              Commit graph ADD /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/message/MessageRenderer.java
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/themes/sam/theme.css
              Commit graph ADD /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/message/Message.java
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/themes/rime/theme.css
              yip.ng made changes -
              Attachment screenshot-02.png [ 15391 ]
              Hide
              Permalink
              yip.ng added a comment - - edited

              ace:message first iteration done as per decisions from meeting. Essential logic based on Mojarra MessageRenderer, but with cleaner code than some clumsy code in Mojarra, e.g. using message ordinal and array indexing instead of multiple if statements. See screenshot-02 for the jQuery styling.

              A: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\message#33255
              A: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\message\Message.java#33255
              A: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\message\MessageMeta.java#33255
              A: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\message\MessageRenderer.java#33255
              M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\resources\icefaces.ace\themes\sam\theme.css#33255
              M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\resources\icefaces.ace\themes\rime\theme.css#33255

              Show
              yip.ng added a comment - - edited ace:message first iteration done as per decisions from meeting. Essential logic based on Mojarra MessageRenderer, but with cleaner code than some clumsy code in Mojarra, e.g. using message ordinal and array indexing instead of multiple if statements. See screenshot-02 for the jQuery styling. A: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\message#33255 A: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\message\Message.java#33255 A: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\message\MessageMeta.java#33255 A: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\message\MessageRenderer.java#33255 M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\resources\icefaces.ace\themes\sam\theme.css#33255 M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\resources\icefaces.ace\themes\rime\theme.css#33255
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #33280 Wed Jan 30 16:42:58 MST 2013 yip.ng ICE-8655: ace:message and ace:messages.
              Files Changed
              Commit graph ADD /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/messages/MessagesMeta.java
              Commit graph ADD /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/messages/Messages.java
              Commit graph ADD /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/messages/MessagesRenderer.java
              Commit graph ADD /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/messages
              yip.ng made changes -
              Attachment Document3.txt [ 15408 ]
              Hide
              Permalink
              yip.ng added a comment - - edited

              Showcase broken (when navigating from landing demo of a component to another demo) after svn update. See attached Document3.txt for the exceptions. Had to spend time tracking down the last working revision (33243) before I could do any testing.

              ace:messages first iteration done as per decisions from meeting. Essential logic based on Mojarra MessagesRenderer, but with cleaner code than some clumsy code in Mojarra, e.g. using message ordinal and array indexing instead of multiple if statements.

              A: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\messages#33280
              A: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\messages\Messages.java#33280
              A: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\messages\MessagesMeta.java#33280
              A: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\messages\MessagesRenderer.java#33280

              Show
              yip.ng added a comment - - edited Showcase broken (when navigating from landing demo of a component to another demo) after svn update. See attached Document3.txt for the exceptions. Had to spend time tracking down the last working revision (33243) before I could do any testing. ace:messages first iteration done as per decisions from meeting. Essential logic based on Mojarra MessagesRenderer, but with cleaner code than some clumsy code in Mojarra, e.g. using message ordinal and array indexing instead of multiple if statements. A: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\messages#33280 A: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\messages\Messages.java#33280 A: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\messages\MessagesMeta.java#33280 A: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\messages\MessagesRenderer.java#33280
              Hide
              Permalink
              Ken Fyten added a comment - - edited

              After reviewing the available icon options provided by ThemeRoller, I think we should just use the following:

              • Info: ui-icon-notice w/ ui-state-highlight css
              • Warn: ui-icon-info w/ ui-state-highlight css
              • Error: ui-icon-alert w/ ui-state-error css
              • Fatal: ui-icon-alert w/ ui-state-error css

              In addition, the message(s) should render a border with rounded rectangles, with the icon inside the border, with appropriate padding, and in the case of ace:message, without resorting to block layout.

              Show
              Ken Fyten added a comment - - edited After reviewing the available icon options provided by ThemeRoller, I think we should just use the following: Info: ui-icon-notice w/ ui-state-highlight css Warn: ui-icon-info w/ ui-state-highlight css Error: ui-icon-alert w/ ui-state-error css Fatal: ui-icon-alert w/ ui-state-error css In addition, the message(s) should render a border with rounded rectangles, with the icon inside the border, with appropriate padding, and in the case of ace:message, without resorting to block layout.
              Ken Fyten made changes -
              Comment [ Based on the picture #2 on this JIRA, it looks like the message component text needs some padding between it and the border. Should be based on the Themeroller styling, shouldn't it? ]
              yip.ng made changes -
              Attachment screenshot-03.png [ 15415 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #33320 Mon Feb 04 18:09:16 MST 2013 yip.ng ICE-8655: ace:message and ace:messages.
              Files Changed
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/message/MessageMeta.java
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/message/MessageRenderer.java
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/themes/sam/theme.css
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/messages/MessagesMeta.java
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/themes/rime/theme.css
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/messages/MessagesRenderer.java
              yip.ng made changes -
              Attachment screenshot-04.png [ 15416 ]
              yip.ng made changes -
              Attachment screenshot-05.png [ 15417 ]
              yip.ng made changes -
              Attachment screenshot-06.png [ 15418 ]
              yip.ng made changes -
              Attachment screenshot-06.png [ 15418 ]
              yip.ng made changes -
              Attachment screenshot-06.png [ 15423 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #33334 Tue Feb 05 15:52:35 MST 2013 yip.ng ICE-8655: ace:message and ace:messages.
              Files Changed
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/message/MessageRenderer.java
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/themes/sam/theme.css
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/messages/MessagesMeta.java
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/themes/rime/theme.css
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/messages/MessagesRenderer.java
              Hide
              Permalink
              yip.ng added a comment - - edited

              Theme Roller example uses <div> and <p> as containers, and padding is provided by them, not the theme ui-state. See screenshot-04. <ace:message> should use <span> (as in Mojarra) because users expect to be able to just put a message adjacent to an input field.

              Using <span> creates complications. See screenshot-03. Therefore, must resort to more complicated positioning and spacing techniques. <ace:messages> are in a <table> or <ul>, so they can use the same approach as in the Theme Roller example. But even then, the icon appears a bit off position when in a <li> under <ul>. See screenshot-06.

              And in IE7 the icon is a bit off position no matter what, even after applying a known CSS hack (zoom to set hasLayout). Same in Theme Roller example. See screenshot-05 and -08.

              Another side effect: when <ace:message>'s are stacked vertically, e.g. in a table as in showcase, the border and padding overlap. See screenshot-07. In this layout scenario the user has to allow more space in the wrapping container in the app.?

              Or do we want to abandon <span> and use <div> as well for <ace:message>, and let the user figure out their positioning needs?

              M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\message\MessageMeta.java#33320
              M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\message\MessageRenderer.java#33320
              M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\messages\MessagesMeta.java#33320
              M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\messages\MessagesRenderer.java#33320
              M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\resources\icefaces.ace\themes\sam\theme.css#33320
              M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\resources\icefaces.ace\themes\rime\theme.css#33320

              Show
              yip.ng added a comment - - edited Theme Roller example uses <div> and <p> as containers, and padding is provided by them, not the theme ui-state. See screenshot-04. <ace:message> should use <span> (as in Mojarra) because users expect to be able to just put a message adjacent to an input field. Using <span> creates complications. See screenshot-03. Therefore, must resort to more complicated positioning and spacing techniques. <ace:messages> are in a <table> or <ul>, so they can use the same approach as in the Theme Roller example. But even then, the icon appears a bit off position when in a <li> under <ul>. See screenshot-06. And in IE7 the icon is a bit off position no matter what, even after applying a known CSS hack (zoom to set hasLayout). Same in Theme Roller example. See screenshot-05 and -08. Another side effect: when <ace:message>'s are stacked vertically, e.g. in a table as in showcase, the border and padding overlap. See screenshot-07. In this layout scenario the user has to allow more space in the wrapping container in the app.? Or do we want to abandon <span> and use <div> as well for <ace:message>, and let the user figure out their positioning needs? M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\message\MessageMeta.java#33320 M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\message\MessageRenderer.java#33320 M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\messages\MessagesMeta.java#33320 M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\messages\MessagesRenderer.java#33320 M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\resources\icefaces.ace\themes\sam\theme.css#33320 M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\resources\icefaces.ace\themes\rime\theme.css#33320
              yip.ng made changes -
              Attachment screenshot-07.png [ 15424 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #33343 Tue Feb 05 17:56:30 MST 2013 yip.ng ICE-8655: ace:message and ace:messages.
              Files Changed
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/message/MessageMeta.java
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/message/MessageRenderer.java
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/messages/MessagesMeta.java
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/messages/MessagesRenderer.java
              yip.ng made changes -
              Attachment screenshot-08.png [ 15425 ]
              Hide
              Permalink
              yip.ng added a comment -

              Decisions form meeting:

              • get rid of layout attribute in <ace:messages>, just output <div>
              • add style and styleClass attributes
              • add ARIA attributes
              Show
              yip.ng added a comment - Decisions form meeting: get rid of layout attribute in <ace:messages>, just output <div> add style and styleClass attributes add ARIA attributes
              Hide
              Permalink
              yip.ng added a comment -

              layout attribute removed. Messages rendered in <div>'s only.

              M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\message\MessageRenderer.java#33334
              M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\messages\MessagesMeta.java#33334
              M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\messages\MessagesRenderer.java#33334
              M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\resources\icefaces.ace\themes\sam\theme.css#33334
              M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\resources\icefaces.ace\themes\rime\theme.css#33334

              Show
              yip.ng added a comment - layout attribute removed. Messages rendered in <div>'s only. M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\message\MessageRenderer.java#33334 M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\messages\MessagesMeta.java#33334 M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\messages\MessagesRenderer.java#33334 M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\resources\icefaces.ace\themes\sam\theme.css#33334 M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\resources\icefaces.ace\themes\rime\theme.css#33334
              Hide
              Permalink
              yip.ng added a comment -

              style and styleClass attributes added.

              M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\message\MessageMeta.java#33343
              M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\message\MessageRenderer.java#33343
              M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\messages\MessagesMeta.java#33343
              M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\messages\MessagesRenderer.java#33343

              Show
              yip.ng added a comment - style and styleClass attributes added. M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\message\MessageMeta.java#33343 M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\message\MessageRenderer.java#33343 M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\messages\MessagesMeta.java#33343 M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\messages\MessagesRenderer.java#33343
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #33348 Wed Feb 06 14:05:16 MST 2013 yip.ng ICE-8655: ace:message and ace:messages.
              Files Changed
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/message/MessageRenderer.java
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/messages/MessagesRenderer.java
              Hide
              Permalink
              yip.ng added a comment -

              ARIA attributes added: role, aria-atomic, aria-live, aria-relevant.

              M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\message\MessageRenderer.java#33348
              M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\messages\MessagesRenderer.java#33348

              Show
              yip.ng added a comment - ARIA attributes added: role, aria-atomic, aria-live, aria-relevant. M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\message\MessageRenderer.java#33348 M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\messages\MessagesRenderer.java#33348
              yip.ng made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Hide
              Permalink
              Ken Fyten added a comment -

              Let's add a new showcase demo for ace:message(s) that shows each component in a separate demo panel.

              Show
              Ken Fyten added a comment - Let's add a new showcase demo for ace:message(s) that shows each component in a separate demo panel.
              Ken Fyten made changes -
              Resolution Fixed [ 1 ]
              Status Resolved [ 5 ] Reopened [ 4 ]
              Hide
              Permalink
              yip.ng added a comment -

              From Cruz:

              When using ace:message without the 'for' attribute specified and
              triggering a message (via a required input) no messages will be
              displayed at all. If doing the same with ace:messages, the message will
              display. I think a good way to 'fix' this behaviour would be to make the
              for attribute of the ace:message component required.

              Show
              yip.ng added a comment - From Cruz: When using ace:message without the 'for' attribute specified and triggering a message (via a required input) no messages will be displayed at all. If doing the same with ace:messages, the message will display. I think a good way to 'fix' this behaviour would be to make the for attribute of the ace:message component required.
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #33520 Tue Feb 19 18:06:22 MST 2013 yip.ng ICE-8655: ace:message and ace:messages.
              Files Changed
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/message/MessageMeta.java
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/message/MessageRenderer.java
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/messages/MessagesMeta.java
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/messages/MessagesRenderer.java
              Hide
              Permalink
              yip.ng added a comment - - edited

              - "for" attribute marked required in message meta class.
              - Added checking for empty id. (findComponent() would throw exception. null or non-existent id had already been checked before.)
              - Log warning and skip rendering, as in Mojarra. (Decision from meeting. Had been rendering empty span.)

              Note that null is valid value in <ace:messages> to output global messages, therefore only empty and non-existent ids are error cases.

              M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\message\MessageMeta.java#33520
              M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\message\MessageRenderer.java#33520
              M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\messages\MessagesMeta.java#33520
              M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\messages\MessagesRenderer.java#33520

              Show
              yip.ng added a comment - - edited - "for" attribute marked required in message meta class. - Added checking for empty id. (findComponent() would throw exception. null or non-existent id had already been checked before.) - Log warning and skip rendering, as in Mojarra. (Decision from meeting. Had been rendering empty span.) Note that null is valid value in <ace:messages> to output global messages, therefore only empty and non-existent ids are error cases. M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\message\MessageMeta.java#33520 M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\message\MessageRenderer.java#33520 M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\messages\MessagesMeta.java#33520 M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\messages\MessagesRenderer.java#33520
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #33543 Wed Feb 20 18:07:26 MST 2013 yip.ng ICE-8655: ace:message and ace:messages.
              Files Changed
              Commit graph ADD /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/message
              Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/java/org/icefaces/samples/showcase/view/navigation/AceMenu.java
              Commit graph ADD /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/java/org/icefaces/samples/showcase/example/ace/message/MessageBean.java
              Commit graph ADD /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/message/message.xhtml
              Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/resources/org/icefaces/samples/showcase/view/resources/messages.properties
              Commit graph ADD /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/java/org/icefaces/samples/showcase/example/ace/message
              Commit graph ADD /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/java/org/icefaces/samples/showcase/ace/documentationResources/MessageResources.java
              yip.ng made changes -
              Attachment screenshot-09.png [ 15464 ]
              Hide
              Permalink
              yip.ng added a comment -

              Demo done. See screenhot-09.

              M: C:\svn\ossrepo\icefaces3\trunk\icefaces\samples\showcase\showcase\src\main\java\org\icefaces\samples\showcase\view\navigation\AceMenu.java#33543
              A: C:\svn\ossrepo\icefaces3\trunk\icefaces\samples\showcase\showcase\src\main\webapp\resources\examples\ace\message#33543
              A: C:\svn\ossrepo\icefaces3\trunk\icefaces\samples\showcase\showcase\src\main\java\org\icefaces\samples\showcase\example\ace\message#33543
              A: C:\svn\ossrepo\icefaces3\trunk\icefaces\samples\showcase\showcase\src\main\webapp\resources\examples\ace\message\message.xhtml#33543
              A: C:\svn\ossrepo\icefaces3\trunk\icefaces\samples\showcase\showcase\src\main\java\org\icefaces\samples\showcase\example\ace\message\MessageBean.java#33543
              A: C:\svn\ossrepo\icefaces3\trunk\icefaces\samples\showcase\showcase\src\main\java\org\icefaces\samples\showcase\ace\documentationResources\MessageResources.java#33543
              M: C:\svn\ossrepo\icefaces3\trunk\icefaces\samples\showcase\showcase\src\main\resources\org\icefaces\samples\showcase\view\resources\messages.properties#33543

              Show
              yip.ng added a comment - Demo done. See screenhot-09. M: C:\svn\ossrepo\icefaces3\trunk\icefaces\samples\showcase\showcase\src\main\java\org\icefaces\samples\showcase\view\navigation\AceMenu.java#33543 A: C:\svn\ossrepo\icefaces3\trunk\icefaces\samples\showcase\showcase\src\main\webapp\resources\examples\ace\message#33543 A: C:\svn\ossrepo\icefaces3\trunk\icefaces\samples\showcase\showcase\src\main\java\org\icefaces\samples\showcase\example\ace\message#33543 A: C:\svn\ossrepo\icefaces3\trunk\icefaces\samples\showcase\showcase\src\main\webapp\resources\examples\ace\message\message.xhtml#33543 A: C:\svn\ossrepo\icefaces3\trunk\icefaces\samples\showcase\showcase\src\main\java\org\icefaces\samples\showcase\example\ace\message\MessageBean.java#33543 A: C:\svn\ossrepo\icefaces3\trunk\icefaces\samples\showcase\showcase\src\main\java\org\icefaces\samples\showcase\ace\documentationResources\MessageResources.java#33543 M: C:\svn\ossrepo\icefaces3\trunk\icefaces\samples\showcase\showcase\src\main\resources\org\icefaces\samples\showcase\view\resources\messages.properties#33543
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #33558 Thu Feb 21 17:02:45 MST 2013 yip.ng ICE-8655: ace:message and ace:messages.
              Files Changed
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/message/MessageRenderer.java
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/messages/MessagesMeta.java
              Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/message/message.xhtml
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/messages/MessagesRenderer.java
              Ken Fyten made changes -
              Summary ace:message and ace:messages New ace:message and ace:messages components
              Hide
              Permalink
              Ken Fyten added a comment -

              For ace:messages only, let's add support for a new "@all" for keyword that will be treated the same as the null case (required to support EL expressions that can't return null).

              Future consideration for adding additional keyword support such as "@parent", "@form", and also a space-delimited list of ids, etc. (currently out of scope).

              Show
              Ken Fyten added a comment - For ace:messages only, let's add support for a new "@all" for keyword that will be treated the same as the null case (required to support EL expressions that can't return null). Future consideration for adding additional keyword support such as "@parent", "@form", and also a space-delimited list of ids, etc. (currently out of scope).
              Hide
              Permalink
              yip.ng added a comment -

              Done.

              M: C:\svn\ossrepo\icefaces3\trunk\icefaces\samples\showcase\showcase\src\main\webapp\resources\examples\ace\message\message.xhtml#33558
              M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\message\MessageRenderer.java#33558
              M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\messages\MessagesMeta.java#33558
              M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\messages\MessagesRenderer.java#33558

              Show
              yip.ng added a comment - Done. M: C:\svn\ossrepo\icefaces3\trunk\icefaces\samples\showcase\showcase\src\main\webapp\resources\examples\ace\message\message.xhtml#33558 M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\message\MessageRenderer.java#33558 M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\messages\MessagesMeta.java#33558 M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\messages\MessagesRenderer.java#33558
              yip.ng made changes -
              Status Reopened [ 4 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              yip.ng made changes -
              Resolution Fixed [ 1 ]
              Status Resolved [ 5 ] Reopened [ 4 ]
              yip.ng made changes -
              Comment [ [10:39:20 AM] Ken Fyten: themeSelector needs to respect Theme Roller styling, just like the ace:simpleSelectOneMenu does.

              Also:
              # use div as in simpleSelectOneMenu, not span
              # remove theme value from backing bean ]
              yip.ng made changes -
              Status Reopened [ 4 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Hide
              Permalink
              yip.ng added a comment - - edited

              wiki done.

              M: C:\svn\ossrepo\icefaces3\trunk\icefaces\samples\showcase\showcase\src\main\java\org\icefaces\samples\showcase\ace\documentationResources\MessageResources.java#33938

              Show
              yip.ng added a comment - - edited wiki done. M: C:\svn\ossrepo\icefaces3\trunk\icefaces\samples\showcase\showcase\src\main\java\org\icefaces\samples\showcase\ace\documentationResources\MessageResources.java#33938
              yip.ng made changes -
              Resolution Fixed [ 1 ]
              Status Resolved [ 5 ] Reopened [ 4 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #33938 Thu Mar 14 09:57:01 MDT 2013 yip.ng ICE-8655: ace:message and ace:messages.
              Files Changed
              Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/java/org/icefaces/samples/showcase/ace/documentationResources/MessageResources.java
              yip.ng made changes -
              Status Reopened [ 4 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Hide
              Permalink
              Ken Fyten added a comment - - edited

              Additional Changes:

              Add the following attributes:

              • escape
              • lang
              • title
              Show
              Ken Fyten added a comment - - edited Additional Changes: Add the following attributes: escape lang title
              Ken Fyten made changes -
              Resolution Fixed [ 1 ]
              Status Resolved [ 5 ] Reopened [ 4 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #33986 Tue Mar 19 16:59:37 MDT 2013 yip.ng ICE-8655: ace:message and ace:messages.
              Files Changed
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/message/MessageMeta.java
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/message/MessageRenderer.java
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/messages/MessagesMeta.java
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/messages/MessagesRenderer.java
              yip.ng made changes -
              Attachment screenshot-10.png [ 15594 ]
              Hide
              Permalink
              yip.ng added a comment -

              Done: screenshot-10.png.

              M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\message\MessageMeta.java#33986
              M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\message\MessageRenderer.java#33986
              M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\messages\MessagesMeta.java#33986
              M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\messages\MessagesRenderer.java#33986

              Show
              yip.ng added a comment - Done: screenshot-10.png . M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\message\MessageMeta.java#33986 M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\message\MessageRenderer.java#33986 M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\messages\MessagesMeta.java#33986 M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\messages\MessagesRenderer.java#33986
              yip.ng made changes -
              Status Reopened [ 4 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  yip.ng
                  Reporter:
                  Ted Goddard
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: