[ICE-8594] ace:dataTable enhancement - cancel sort / filter if validation fails - ICEsoft JIRA Issue Tracker

Details

Type: Improvement
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 3.2
Fix Version/s: EE-3.2.0.BETA, EE-3.2.0.GA, 3.3
Component/s: ACE-Components
Labels:
None
Environment:
IF 3.x

Description

Revert the state of the DataTable to the previous sort, if the during this request a component fails validation.

Activity

Ascending order - Click to sort in descending order

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#31048	Mon Sep 24 16:57:47 MDT 2012	nils.lundquist	~~ICE-8594~~ - ace:dataTable revert client state if validation fails during the sort request.
				Files Changed
				MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/datatable/datatable.js

Migration created issue - 24/Sep/12 5:01 PM

Hide

Permalink

Nils Lundquist added a comment - 24/Sep/12 5:20 PM - edited

This is currently implemented correctly on the server, however a callback will need to be implemented on the client to revert the internal state changes that resulted from the sort action. The same will need to be done for filter- the filter value needs to be cleared on the client by the failed validation.

Show

Nils Lundquist added a comment - 24/Sep/12 5:20 PM - edited This is currently implemented correctly on the server, however a callback will need to be implemented on the client to revert the internal state changes that resulted from the sort action. The same will need to be done for filter- the filter value needs to be cleared on the client by the failed validation.

Hide

Permalink

Arran Mccullough added a comment - 25/Sep/12 5:53 PM - edited

Support case #11501

Show

Arran Mccullough added a comment - 25/Sep/12 5:53 PM - edited Support case #11501

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#31089	Wed Sep 26 11:45:44 MDT 2012	nils.lundquist	~~ICE-8594~~ - Implement serializable for SortState / FilterState.
				Files Changed
				MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/datatable/FilterState.java MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/datatable/SortState.java

Hide

Permalink

Ken Fyten added a comment - 26/Sep/12 5:37 PM - edited

Assignee Priority: P1
Recent commit for this JIRA is resulting in the following exception during session serialization. SortState needs to be made Serializable, or transient as applicable.

showcase (FF14, tomcat7):
Manual Test Results:
DataTable - Overview - clicking to sort items on this page causes a java.io.NotSerializableException in server log (after this, all left-side links become non-functional):
SEVERE: Exiting serializeView - Could not serialize state: org.icefaces.ace.comp
onent.datatable.SortState
java.io.NotSerializableException: org.icefaces.ace.component.datatable.SortState
        at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1164)
        at java.io.ObjectOutputStream.writeObject(ObjectOutputStream.java:330)
        at java.util.HashMap.writeObject(HashMap.java:1001)
        at sun.reflect.GeneratedMethodAccessor46.invoke(Unknown Source)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAcces
sorImpl.java:25)
        at java.lang.reflect.Method.invoke(Method.java:597)...

Show

Ken Fyten added a comment - 26/Sep/12 5:37 PM - edited Assignee Priority: P1 Recent commit for this JIRA is resulting in the following exception during session serialization. SortState needs to be made Serializable, or transient as applicable. showcase (FF14, tomcat7): Manual Test Results: DataTable - Overview - clicking to sort items on this page causes a java.io.NotSerializableException in server log (after this , all left-side links become non-functional): SEVERE: Exiting serializeView - Could not serialize state: org.icefaces.ace.comp onent.datatable.SortState java.io.NotSerializableException: org.icefaces.ace.component.datatable.SortState at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1164) at java.io.ObjectOutputStream.writeObject(ObjectOutputStream.java:330) at java.util.HashMap.writeObject(HashMap.java:1001) at sun.reflect.GeneratedMethodAccessor46.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAcces sorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597)...

Migration made changes - 29/Nov/12 10:01 PM

Field	Original Value	New Value
Reporter	Migration [ remote ]	Nils Lundquist [ nils.lundquist ]

Migration made changes - 29/Nov/12 10:01 PM

Assignee

Nils Lundquist [ nils.lundquist ]

Migration made changes - 29/Nov/12 10:01 PM

Summary

Williams ace:dataTable enhancement - cancel sort / filter if validation fails

ace:dataTable enhancement - cancel sort / filter if validation fails (was: Williams ace:dataTable enhancement - cancel sort / filter if validation fails)

Migration made changes - 29/Nov/12 10:10 PM

Status	Open [ 1 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

Migration made changes - 29/Nov/12 10:11 PM

Resolution	Fixed [ 1 ]
Status	Resolved [ 5 ]	Reopened [ 4 ]

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#32615	Tue Dec 04 13:26:57 MST 2012	nils.lundquist	~~ICE-8594~~ - SortState/FilterState now transient fields of the DataTable instance rather than state saved fields of the DataTable component.
				Files Changed
				MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/datatable/DataTable.java MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/datatable/DataTableDecoder.java MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/datatable/FilterState.java MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/datatable/DataTableRenderer.java MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/datatable/DataTableMeta.java MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/datatable/SortState.java

Hide

Permalink

Nils Lundquist added a comment - 04/Dec/12 8:27 PM

Revision #32615
Committed by nils.lundquist
A minute ago
~~ICE-8594~~ - SortState/FilterState now transient fields of the DataTable instance rather than state saved fields of the DataTable component.

Show

Nils Lundquist added a comment - 04/Dec/12 8:27 PM Revision #32615 Committed by nils.lundquist A minute ago ICE-8594 - SortState/FilterState now transient fields of the DataTable instance rather than state saved fields of the DataTable component.

Nils Lundquist made changes - 04/Dec/12 8:27 PM

Status	Reopened [ 4 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

Nils Lundquist made changes - 07/Dec/12 8:31 PM

Fix Version/s		3.3 [ 10370 ]
Affects Version/s		3.2 [ 10338 ]
Component/s		ACE-Components [ 10050 ]

Ken Fyten made changes - 07/Dec/12 10:51 PM

Fix Version/s

EE-3.2.0.GA [ 10332 ]

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#32684	Mon Dec 10 10:37:30 MST 2012	nils.lundquist	~~ICE-8594~~ - Don't required decoded filter state to process filters, one won't exist during 'global' filter requests.
				Files Changed
				MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/datatable/DataTable.java

Ken Fyten made changes - 20/Dec/12 5:11 PM

Fix Version/s

EE-3.2.0.BETA [ 10573 ]

Ken Fyten made changes - 25/Jan/13 8:58 PM

Summary

ace:dataTable enhancement - cancel sort / filter if validation fails (was: Williams ace:dataTable enhancement - cancel sort / filter if validation fails)

ace:dataTable enhancement - cancel sort / filter if validation fails

Ken Fyten made changes - 14/Nov/14 5:39 PM

Status

Resolved [ 5 ]

Closed [ 6 ]

People

Assignee:

Nils Lundquist

Reporter:

Nils Lundquist

Votes:

0 Vote for this issue

Watchers:

2 Start watching this issue

Dates

Created:

24/Sep/12 5:01 PM

Updated:

14/Nov/14 5:39 PM

Resolved:

04/Dec/12 8:27 PM