ICEfaces
  1. ICEfaces
  2. ICE-8509

Apply Prototype memory leak fixes

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: EE-3.0.0.GA, 3.1
          • Fix Version/s: EE-3.0.0.GA_P01, 3.2
          • Component/s: Bridge
          • Labels:
            None
          • Environment:
            supported browsers

            Activity

            Ascending order - Click to sort in descending order
            Mircea Toma created issue -
            Mircea Toma made changes -
            Field Original Value New Value
            Assignee Mircea Toma [ mircea.toma ]
            Ken Fyten made changes -
            Salesforce Case []
            Security Private [ 10001 ]
            Hide
            Permalink
            Ken Fyten added a comment -

            These should also be applied to the icefaces3/trunk for inclusion in 3.2.

            Are there any performance ramifications that would warrant us making their use configurable?

            Show
            Ken Fyten added a comment - These should also be applied to the icefaces3/trunk for inclusion in 3.2. Are there any performance ramifications that would warrant us making their use configurable?
            Repository Revision Date User Message
            ICEsoft Public SVN Repository #30635 Wed Aug 29 11:36:38 MDT 2012 mircea.toma ICE-8509 Applied Prototype patches that fix memory leaks generated when Element.observe method is used.
            Files Changed
            Commit graph MODIFY /icefaces3/trunk/icefaces/compat/core/src/main/javascript/prototype/prototype.js
            Hide
            Permalink
            Mircea Toma added a comment -

            Applied patches to trunk.

            Show
            Mircea Toma added a comment - Applied patches to trunk.
            Mircea Toma made changes -
            Status Open [ 1 ] Resolved [ 5 ]
            Resolution Fixed [ 1 ]
            Hide
            Permalink
            Mircea Toma added a comment -

            I don't think there are any drawbacks to be using these patches all the time.

            Show
            Mircea Toma added a comment - I don't think there are any drawbacks to be using these patches all the time.
            Hide
            Permalink
            Ken Fyten added a comment -

            Let's add these to the icefaces-3.0.x-maintenance branch also.

            Show
            Ken Fyten added a comment - Let's add these to the icefaces-3.0.x-maintenance branch also.
            Ken Fyten made changes -
            Resolution Fixed [ 1 ]
            Status Resolved [ 5 ] Reopened [ 4 ]
            Assignee Priority P1
            Ken Fyten made changes -
            Salesforce Case []
            Fix Version/s EE-3.0.0.GA_P01 [ 10327 ]
            Affects Version/s EE-3.0.0.GA [ 10262 ]
            Description Apply Prototype memory leak fixes to Hamburg Sud's branch:

            https://github.com/kir/prototype/commit/8153deb7066cf93eab1064fa8bb535843c37be4d
            https://github.com/kir/prototype/commit/c7926bc122830c2063baf0c46b78935f4dacd5e1

            More information about what causes the leaks is here:

            https://prototype.lighthouseapp.com/projects/8886/tickets/789-observestopobserving-cause-memory-leaks-in-ie
            		 Apply documented but not officially supported (by Prototype) Prototype library memory leak fixes:

            https://github.com/kir/prototype/commit/8153deb7066cf93eab1064fa8bb535843c37be4d
            https://github.com/kir/prototype/commit/c7926bc122830c2063baf0c46b78935f4dacd5e1

            More information about what causes the leaks is here:

            https://prototype.lighthouseapp.com/projects/8886/tickets/789-observestopobserving-cause-memory-leaks-in-ie
            Security Private [ 10001 ]
            Ken Fyten made changes -
            Link This issue blocks ICE-8500 [ ICE-8500 ]
            Repository Revision Date User Message
            ICEsoft Public SVN Repository #30652 Thu Aug 30 15:49:42 MDT 2012 mircea.toma ICE-8509 Applied Prototype patches that fix memory leaks generated when Element.observe method is used.
            Files Changed
            Commit graph MODIFY /icefaces3/trunk/icefaces/compat/core/src/main/javascript/prototype/prototype.js
            Repository Revision Date User Message
            ICEsoft Public SVN Repository #30653 Thu Aug 30 15:49:53 MDT 2012 mircea.toma ICE-8509 Applied Prototype patches that fix memory leaks generated when Element.observe method is used.
            Files Changed
            Commit graph MODIFY /icefaces3/branches/icefaces-3.0.x-maintenance/icefaces/compat/core/src/main/javascript/prototype/prototype.js
            Ken Fyten made changes -
            Status Reopened [ 4 ] Resolved [ 5 ]
            Resolution Fixed [ 1 ]
            Ken Fyten made changes -
            Status Resolved [ 5 ] Closed [ 6 ]
            Assignee Priority P1 [ 10010 ]

              People

              • Assignee:
                Mircea Toma
                Reporter:
                Mircea Toma
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: