Case ICE-8749 has been opened for this issue and a fix checked into the current ICEfaces 3 trunk for future releases.

problem: this yields a NPE when passing an empty param value!
protected static String getJavascriptHiddenFieldSetters(
FacesContext facesContext,
UICommand uiCommand, Map parameters) {
StringBuffer buffer;
buffer = new StringBuffer("var form=formOf(this);form['");
buffer.append(deriveCommonHiddenFieldName(facesContext, uiCommand));
buffer.append("'].value='");
buffer.append(uiCommand.getClientId(facesContext));
buffer.append("';");
Iterator parameterKeys = parameters.keySet().iterator();
while (parameterKeys.hasNext())

return buffer.toString();
}

I added a function to escape single quotes in the renderer and run each parameter through it. I applied and tested this on both ICEfaces 1.8.x and 3.x and both test cases now work - properly submitting the form.

The problem is in the com.icesoft.faces.renderkit.dom_html_basic.CommandLinkRenderer. Part of it's job is to render out the onclick handler. The script for that handler is responsible for setting and then clearing the parameters and looks something like this:

<a class="iceCmdLnk"
href="javascript:;"
id="iceForm:j_idt9"
onblur="setFocus('');"
onclick= "var form=formOf(this);

//Set the values
form['iceForm:j_idcl'].value='iceForm:j_idt9';
form['name'].value='ICEfaces's Issue';

//Submit the form
iceSubmit(form,this,event);

//Clear the values
form['iceForm:j_idcl'].value='';
form['name'].value='';
return false;"
onfocus="setFocus(this.id);">

The problem is obvious as when an apostrophe is included, it's not properly escaped with a backslash (\') which leads to invalid JavaScript. I don't believe this requires the full escaping that is done via DOMUtils.escapeAnsi() as the contents are simply a valid JavaScript string. Instead, we just need to properly escape the single quote.

Attached test case that shows this is still and issue in ICEfaces 3.1.0

Attached test case that shows issue.

Steps:

• Load welcomeICEfaces.iface
• Click on the "ICEface's Issue" Link, nothing happens and a JS error is thrown in the console.