ICEfaces
  1. ICEfaces
  2. ICE-8401

Selection in scrollable datatable

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: EE-3.0.0.GA, 3.1
    • Fix Version/s: EE-3.0.0.GA_P01, 3.2
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      Chrome, Firefox, IE9, IE8

      Description

      To reproduce use the source code attached, then:

      1. load application in WebKit browser to reproduce misalignment issue demonstrated in attached screenshot.
      2. load in any browser mentioned in Environment section to reproduce "growth" effect.

      NOTES:
      It appears to me that growth usually continues until certain criteria have been met. (table growth stops after different number of selection/deselection events in different browsers)
      This behavior is not applicable to IE7.

      1. sourceCode.rar
        7 kB
        Evgheni Sadovoi
      1. case11485.jpg
        166 kB

        Activity

        Evgheni Sadovoi created issue -
        Evgheni Sadovoi made changes -
        Field Original Value New Value
        Attachment sampleSourceCode.rar [ 14731 ]
        Attachment case11485.jpg [ 14732 ]
        Evgheni Sadovoi made changes -
        Attachment case11485.jpg [ 14733 ]
        Evgheni Sadovoi made changes -
        Attachment case11485.jpg [ 14732 ]
        Evgheni Sadovoi made changes -
        Salesforce Case [5007000000NHWKV]
        Evgheni Sadovoi made changes -
        Description To reproduce use the source code attached then

        1. load it in WebKit browser to reproduce misalignment issue demonstrated in attached screenshot.
        2. load in any browser mentioned in Environment section to reproduce "growth" effect.

        NOTES:
        It appears to me that growth usually continues until certain criteria have been met. (table growth stops after different number of selection/deselection events in different browsers)
        This behavior is not applicable to IE7.

        To reproduce use the source code attached, then:

        1. load application in WebKit browser to reproduce misalignment issue demonstrated in attached screenshot.
        2. load in any browser mentioned in Environment section to reproduce "growth" effect.

        NOTES:
        It appears to me that growth usually continues until certain criteria have been met. (table growth stops after different number of selection/deselection events in different browsers)
        This behavior is not applicable to IE7.

        Evgheni Sadovoi made changes -
        Summary Selection in scrollable datatables Selection in scrollable datatable
        Ken Fyten made changes -
        Fix Version/s EE-3.0.0.GA_P01 [ 10327 ]
        Fix Version/s 3.2 [ 10338 ]
        Assignee Priority P2
        Assignee Nils Lundquist [ nils.lundquist ]
        Evgheni Sadovoi made changes -
        Affects Version/s 3.1 [ 10312 ]
        Affects Version/s 3.1.0.RC1 [ 10337 ]
        Affects Version/s EE-3.0.0.GA [ 10262 ]
        Evgheni Sadovoi made changes -
        Affects Version/s EE-3.0.0.GA [ 10262 ]
        Hide
        Nils Lundquist added a comment -

        This issue doesn't accurately describe the issue observed. The bug can't be reproduced in simple 3.1 cases where the deselect and select ajax events execute and rerender the table, regardless of the application of the ace:ajax workaround suggested for the previous issue. As described this issue should be visible in the showcase scrollable table example by modifying it to rerender the table on select/deselect, however this is not the case.

        Reassigning to Evgheni for clarification of the bug conditions and linking to the previous test case / JIRA where we suggested the use of explicit resizeScrolling onSuccess.

        Show
        Nils Lundquist added a comment - This issue doesn't accurately describe the issue observed. The bug can't be reproduced in simple 3.1 cases where the deselect and select ajax events execute and rerender the table, regardless of the application of the ace:ajax workaround suggested for the previous issue. As described this issue should be visible in the showcase scrollable table example by modifying it to rerender the table on select/deselect, however this is not the case. Reassigning to Evgheni for clarification of the bug conditions and linking to the previous test case / JIRA where we suggested the use of explicit resizeScrolling onSuccess.
        Nils Lundquist made changes -
        Assignee Nils Lundquist [ nils.lundquist ] Evgheni Sadovoi [ evgheni.sadovoi ]
        Evgheni Sadovoi made changes -
        Attachment sourceCode.rar [ 14756 ]
        Evgheni Sadovoi made changes -
        Attachment sampleSourceCode.rar [ 14731 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #30352 Wed Aug 01 11:36:34 MDT 2012 nils.lundquist ICE-8401 - Removed table-layout:fixed from all scrollable table resizing code paths but IE7, doesn't appear required since scrolling alterations. Resolves issues with Webkit in particular border cases. Though tests have been performed, a possible regression risk to cases where subtle resizing is done without calling DataTable.resizeScrolling().
        Files Changed
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/datatable/datatable.js
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #30353 Wed Aug 01 12:19:09 MDT 2012 nils.lundquist ICE-8401 - Removed 1px tweak that was resulting in 'growth' during repeat resizeScrolling calls.
        Files Changed
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/datatable/datatable.js
        Hide
        Nils Lundquist added a comment -

        Revision #30352
        Committed by nils.lundquist
        Moments ago
        ICE-8401 - Removed table-layout:fixed from all scrollable table resizing code paths but IE7, doesn't appear required since scrolling alterations. Resolves issues with Webkit in particular border cases. Though tests have been performed, a possible regression risk to cases where subtle resizing is done without calling DataTable.resizeScrolling().

        Show
        Nils Lundquist added a comment - Revision #30352 Committed by nils.lundquist Moments ago ICE-8401 - Removed table-layout:fixed from all scrollable table resizing code paths but IE7, doesn't appear required since scrolling alterations. Resolves issues with Webkit in particular border cases. Though tests have been performed, a possible regression risk to cases where subtle resizing is done without calling DataTable.resizeScrolling().
        Hide
        Nils Lundquist added a comment -

        Revision #30353
        Committed by nils.lundquist
        Moments ago
        ICE-8401 - Removed 1px tweak that was resulting in 'growth' during repeat resizeScrolling calls.

        Show
        Nils Lundquist added a comment - Revision #30353 Committed by nils.lundquist Moments ago ICE-8401 - Removed 1px tweak that was resulting in 'growth' during repeat resizeScrolling calls.
        Nils Lundquist made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Nils Lundquist added a comment -

        Reopening issue to back port growth change to client maintenance branch.

        Show
        Nils Lundquist added a comment - Reopening issue to back port growth change to client maintenance branch.
        Nils Lundquist made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Hide
        Nils Lundquist added a comment -

        Revision #30357
        Committed by nils.lundquist
        2 minutes ago
        ICE-8401 - Backported removal of 1px adjustment responsible for growth effect. Also restricted Safari specific bug handling to versions lower than 6.

        Show
        Nils Lundquist added a comment - Revision #30357 Committed by nils.lundquist 2 minutes ago ICE-8401 - Backported removal of 1px adjustment responsible for growth effect. Also restricted Safari specific bug handling to versions lower than 6.
        Nils Lundquist made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Assignee Priority P2 [ 10011 ]

          People

          • Assignee:
            Evgheni Sadovoi
            Reporter:
            Evgheni Sadovoi
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: