ICEfaces
  1. ICEfaces
  2. ICE-8371

Support for JSF 2 javax.faces.SEPARATOR_CHAR missing for some component classes

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: EE-3.0.0.GA
          • Fix Version/s: 3.1, EE-3.0.0.GA_P01
          • Component/s: ICE-Components
          • Labels:
            None
          • Environment:
            All
          • Assignee Priority:
            P1

            Description

            The following component classes do not use the javax.faces.component.UINamingContainer#getSeparatorChar(FacesContext) method and therefore have some issues documented below:

            DataTable
            Tag:
            <ice:dataTable />
            Java (Error):
            com.icesoft.faces.component.ext.renderkit.TableRenderer.encodeChildren(FacesContext, UIComponent)
            com.icesoft.faces.component.ext.renderkit.TableRenderer.renderFacet(FacesContext, UIComponent, DOMContext, boolean)

            Impact:
            (only thead und tbody)

            <table id="form-carTable">
            <thead id="form-carTable:thead">
            ...
            </thead>
            <tbody id="form-carTable:tbody">
            ...
            </tbody>
            </table>

            SelectInputText
            Tag:
            <ice:selectInputText />
            Java
            com.icesoft.faces.component.selectinputtext.SelectInputText.getClientId(FacesContext)

            Impact:
            Only if the index >= 0


            CoreComponentUtils
            Java
            com.icesoft.util.CoreComponentUtils.getFocusId(FacesContext)

            Impact
            Returns an empty instead of the id to focus on.

              Activity

              Ascending order - Click to sort in descending order
              Arran Mccullough created issue -
              Arran Mccullough made changes -
              Field Original Value New Value
              Issue Type Improvement [ 4 ] Bug [ 1 ]
              Salesforce Case [5007000000NH06N]
              Hide
              Permalink
              Ken Fyten added a comment -

              We will want to audit all ICE and ACE components to ensure we do not have any hardcoded separators in use.

              Show
              Ken Fyten added a comment - We will want to audit all ICE and ACE components to ensure we do not have any hardcoded separators in use.
              Ken Fyten made changes -
              Fix Version/s EE-3.0.0.GA_P01 [ 10327 ]
              Fix Version/s 3.2 [ 10338 ]
              Assignee Priority P1
              Assignee yip.ng [ yip.ng ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #30135 Thu Jul 19 16:01:16 MDT 2012 yip.ng ICE-8371: Support for JSF 2 javax.faces.SEPARATOR_CHAR missing for some component classes.
              Files Changed
              Commit graph MODIFY /icefaces3/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/panelpositioned/PanelPositionedRenderer.java
              Commit graph MODIFY /icefaces3/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/selectinputdate/SelectInputDateRenderer.java
              Commit graph MODIFY /icefaces3/trunk/icefaces/compat/core/src/main/java/com/icesoft/faces/renderkit/dom_html_basic/DomBasicRenderer.java
              Commit graph MODIFY /icefaces3/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/ext/renderkit/GroupRenderer.java
              Commit graph MODIFY /icefaces3/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/menubar/MenuItemRenderer.java
              Commit graph MODIFY /icefaces3/trunk/icefaces/compat/core/src/main/java/com/icesoft/util/CoreComponentUtils.java
              Commit graph MODIFY /icefaces3/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/paneltabset/PanelTabSetRenderer.java
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/util/CoreComponentUtils.java
              Commit graph MODIFY /icefaces3/trunk/icefaces/core/src/main/java/org/icefaces/util/FocusController.java
              Commit graph MODIFY /icefaces3/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/util/CustomComponentUtils.java
              Commit graph MODIFY /icefaces3/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/ext/renderkit/TableRenderer.java
              Commit graph MODIFY /icefaces3/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/paneltabset/PanelTabSet.java
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/autocompleteentry/AutoCompleteEntry.java
              Commit graph MODIFY /icefaces3/trunk/icefaces/compat/core/src/main/java/com/icesoft/faces/renderkit/dom_html_basic/CommandLinkRenderer.java
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/roweditor/RowEditorRenderer.java
              Commit graph MODIFY /icefaces3/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/selectinputtext/SelectInputText.java
              Hide
              Permalink
              yip.ng added a comment -

              Modified: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\autocompleteentry\AutoCompleteEntry.java
              Modified: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\roweditor\RowEditorRenderer.java
              Modified: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\util\CoreComponentUtils.java
              Modified: C:\svn\ossrepo\icefaces3\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\ext\renderkit\GroupRenderer.java
              Modified: C:\svn\ossrepo\icefaces3\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\ext\renderkit\TableRenderer.java
              Modified: C:\svn\ossrepo\icefaces3\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\menubar\MenuItemRenderer.java
              Modified: C:\svn\ossrepo\icefaces3\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\panelpositioned\PanelPositionedRenderer.java
              Modified: C:\svn\ossrepo\icefaces3\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\paneltabset\PanelTabSet.java
              Modified: C:\svn\ossrepo\icefaces3\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\paneltabset\PanelTabSetRenderer.java
              Modified: C:\svn\ossrepo\icefaces3\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\selectinputdate\SelectInputDateRenderer.java
              Modified: C:\svn\ossrepo\icefaces3\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\selectinputtext\SelectInputText.java
              Modified: C:\svn\ossrepo\icefaces3\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\util\CustomComponentUtils.java
              Modified: C:\svn\ossrepo\icefaces3\trunk\icefaces\compat\core\src\main\java\com\icesoft\faces\renderkit\dom_html_basic\CommandLinkRenderer.java
              Modified: C:\svn\ossrepo\icefaces3\trunk\icefaces\compat\core\src\main\java\com\icesoft\faces\renderkit\dom_html_basic\DomBasicRenderer.java
              Modified: C:\svn\ossrepo\icefaces3\trunk\icefaces\compat\core\src\main\java\com\icesoft\util\CoreComponentUtils.java
              Modified: C:\svn\ossrepo\icefaces3\trunk\icefaces\core\src\main\java\org\icefaces\util\FocusController.java
              Completed: At revision: 30135

              Show
              yip.ng added a comment - Modified: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\autocompleteentry\AutoCompleteEntry.java Modified: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\roweditor\RowEditorRenderer.java Modified: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\util\CoreComponentUtils.java Modified: C:\svn\ossrepo\icefaces3\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\ext\renderkit\GroupRenderer.java Modified: C:\svn\ossrepo\icefaces3\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\ext\renderkit\TableRenderer.java Modified: C:\svn\ossrepo\icefaces3\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\menubar\MenuItemRenderer.java Modified: C:\svn\ossrepo\icefaces3\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\panelpositioned\PanelPositionedRenderer.java Modified: C:\svn\ossrepo\icefaces3\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\paneltabset\PanelTabSet.java Modified: C:\svn\ossrepo\icefaces3\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\paneltabset\PanelTabSetRenderer.java Modified: C:\svn\ossrepo\icefaces3\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\selectinputdate\SelectInputDateRenderer.java Modified: C:\svn\ossrepo\icefaces3\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\selectinputtext\SelectInputText.java Modified: C:\svn\ossrepo\icefaces3\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\util\CustomComponentUtils.java Modified: C:\svn\ossrepo\icefaces3\trunk\icefaces\compat\core\src\main\java\com\icesoft\faces\renderkit\dom_html_basic\CommandLinkRenderer.java Modified: C:\svn\ossrepo\icefaces3\trunk\icefaces\compat\core\src\main\java\com\icesoft\faces\renderkit\dom_html_basic\DomBasicRenderer.java Modified: C:\svn\ossrepo\icefaces3\trunk\icefaces\compat\core\src\main\java\com\icesoft\util\CoreComponentUtils.java Modified: C:\svn\ossrepo\icefaces3\trunk\icefaces\core\src\main\java\org\icefaces\util\FocusController.java Completed: At revision: 30135
              yip.ng made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #30146 Thu Jul 19 17:30:33 MDT 2012 yip.ng ICE-8371: Support for JSF 2 javax.faces.SEPARATOR_CHAR missing for some component classes.
              Files Changed
              Commit graph MODIFY /icefaces3/branches/icefaces-3.0.x-maintenance/icefaces/compat/core/src/main/java/com/icesoft/util/CoreComponentUtils.java
              Commit graph MODIFY /icefaces3/branches/icefaces-3.0.x-maintenance/icefaces/compat/components/src/main/java/com/icesoft/faces/component/paneltabset/PanelTabSetRenderer.java
              Commit graph MODIFY /icefaces3/branches/icefaces-3.0.x-maintenance/icefaces/compat/components/src/main/java/com/icesoft/faces/component/paneltabset/PanelTabSet.java
              Commit graph MODIFY /icefaces3/branches/icefaces-3.0.x-maintenance/icefaces/compat/components/src/main/java/com/icesoft/faces/component/selectinputtext/SelectInputText.java
              Commit graph MODIFY /icefaces3/branches/icefaces-3.0.x-maintenance/icefaces/compat/core/src/main/java/com/icesoft/faces/renderkit/dom_html_basic/DomBasicRenderer.java
              Commit graph MODIFY /icefaces3/branches/icefaces-3.0.x-maintenance/icefaces/compat/components/src/main/java/com/icesoft/faces/component/selectinputdate/SelectInputDateRenderer.java
              Commit graph MODIFY /icefaces3/branches/icefaces-3.0.x-maintenance/icefaces/core/src/main/java/org/icefaces/util/FocusController.java
              Commit graph MODIFY /icefaces3/branches/icefaces-3.0.x-maintenance/icefaces/compat/components/src/main/java/com/icesoft/faces/component/util/CustomComponentUtils.java
              Commit graph MODIFY /icefaces3/branches/icefaces-3.0.x-maintenance/icefaces/compat/core/src/main/java/com/icesoft/faces/renderkit/dom_html_basic/CommandLinkRenderer.java
              Commit graph MODIFY /icefaces3/branches/icefaces-3.0.x-maintenance/icefaces/ace/component/src/org/icefaces/ace/component/roweditor/RowEditorRenderer.java
              Commit graph MODIFY /icefaces3/branches/icefaces-3.0.x-maintenance/icefaces/compat/components/src/main/java/com/icesoft/faces/component/panelpositioned/PanelPositionedRenderer.java
              Commit graph MODIFY /icefaces3/branches/icefaces-3.0.x-maintenance/icefaces/compat/components/src/main/java/com/icesoft/faces/component/ext/renderkit/GroupRenderer.java
              Commit graph MODIFY /icefaces3/branches/icefaces-3.0.x-maintenance/icefaces/compat/components/src/main/java/com/icesoft/faces/component/menubar/MenuItemRenderer.java
              Commit graph MODIFY /icefaces3/branches/icefaces-3.0.x-maintenance/icefaces/compat/components/src/main/java/com/icesoft/faces/component/ext/renderkit/TableRenderer.java
              Ken Fyten made changes -
              Fix Version/s 3.1 [ 10312 ]
              Fix Version/s 3.2 [ 10338 ]
              Ken Fyten made changes -
              Resolution Fixed [ 1 ]
              Status Resolved [ 5 ] Reopened [ 4 ]
              Hide
              Permalink
              yip.ng added a comment -

              Modified: C:\svn\ossrepo\icefaces3\branches\icefaces-3.0.x-maintenance\icefaces\ace\component\src\org\icefaces\ace\component\roweditor\RowEditorRenderer.java
              Modified: C:\svn\ossrepo\icefaces3\branches\icefaces-3.0.x-maintenance\icefaces\compat\components\src\main\java\com\icesoft\faces\component\ext\renderkit\GroupRenderer.java
              Modified: C:\svn\ossrepo\icefaces3\branches\icefaces-3.0.x-maintenance\icefaces\compat\components\src\main\java\com\icesoft\faces\component\ext\renderkit\TableRenderer.java
              Modified: C:\svn\ossrepo\icefaces3\branches\icefaces-3.0.x-maintenance\icefaces\compat\components\src\main\java\com\icesoft\faces\component\menubar\MenuItemRenderer.java
              Modified: C:\svn\ossrepo\icefaces3\branches\icefaces-3.0.x-maintenance\icefaces\compat\components\src\main\java\com\icesoft\faces\component\panelpositioned\PanelPositionedRenderer.java
              Modified: C:\svn\ossrepo\icefaces3\branches\icefaces-3.0.x-maintenance\icefaces\compat\components\src\main\java\com\icesoft\faces\component\paneltabset\PanelTabSet.java
              Modified: C:\svn\ossrepo\icefaces3\branches\icefaces-3.0.x-maintenance\icefaces\compat\components\src\main\java\com\icesoft\faces\component\paneltabset\PanelTabSetRenderer.java
              Modified: C:\svn\ossrepo\icefaces3\branches\icefaces-3.0.x-maintenance\icefaces\compat\components\src\main\java\com\icesoft\faces\component\selectinputdate\SelectInputDateRenderer.java
              Modified: C:\svn\ossrepo\icefaces3\branches\icefaces-3.0.x-maintenance\icefaces\compat\components\src\main\java\com\icesoft\faces\component\selectinputtext\SelectInputText.java
              Modified: C:\svn\ossrepo\icefaces3\branches\icefaces-3.0.x-maintenance\icefaces\compat\components\src\main\java\com\icesoft\faces\component\util\CustomComponentUtils.java
              Modified: C:\svn\ossrepo\icefaces3\branches\icefaces-3.0.x-maintenance\icefaces\compat\core\src\main\java\com\icesoft\faces\renderkit\dom_html_basic\CommandLinkRenderer.java
              Modified: C:\svn\ossrepo\icefaces3\branches\icefaces-3.0.x-maintenance\icefaces\compat\core\src\main\java\com\icesoft\faces\renderkit\dom_html_basic\DomBasicRenderer.java
              Modified: C:\svn\ossrepo\icefaces3\branches\icefaces-3.0.x-maintenance\icefaces\compat\core\src\main\java\com\icesoft\util\CoreComponentUtils.java
              Modified: C:\svn\ossrepo\icefaces3\branches\icefaces-3.0.x-maintenance\icefaces\core\src\main\java\org\icefaces\util\FocusController.java
              Completed: At revision: 30146

              Show
              yip.ng added a comment - Modified: C:\svn\ossrepo\icefaces3\branches\icefaces-3.0.x-maintenance\icefaces\ace\component\src\org\icefaces\ace\component\roweditor\RowEditorRenderer.java Modified: C:\svn\ossrepo\icefaces3\branches\icefaces-3.0.x-maintenance\icefaces\compat\components\src\main\java\com\icesoft\faces\component\ext\renderkit\GroupRenderer.java Modified: C:\svn\ossrepo\icefaces3\branches\icefaces-3.0.x-maintenance\icefaces\compat\components\src\main\java\com\icesoft\faces\component\ext\renderkit\TableRenderer.java Modified: C:\svn\ossrepo\icefaces3\branches\icefaces-3.0.x-maintenance\icefaces\compat\components\src\main\java\com\icesoft\faces\component\menubar\MenuItemRenderer.java Modified: C:\svn\ossrepo\icefaces3\branches\icefaces-3.0.x-maintenance\icefaces\compat\components\src\main\java\com\icesoft\faces\component\panelpositioned\PanelPositionedRenderer.java Modified: C:\svn\ossrepo\icefaces3\branches\icefaces-3.0.x-maintenance\icefaces\compat\components\src\main\java\com\icesoft\faces\component\paneltabset\PanelTabSet.java Modified: C:\svn\ossrepo\icefaces3\branches\icefaces-3.0.x-maintenance\icefaces\compat\components\src\main\java\com\icesoft\faces\component\paneltabset\PanelTabSetRenderer.java Modified: C:\svn\ossrepo\icefaces3\branches\icefaces-3.0.x-maintenance\icefaces\compat\components\src\main\java\com\icesoft\faces\component\selectinputdate\SelectInputDateRenderer.java Modified: C:\svn\ossrepo\icefaces3\branches\icefaces-3.0.x-maintenance\icefaces\compat\components\src\main\java\com\icesoft\faces\component\selectinputtext\SelectInputText.java Modified: C:\svn\ossrepo\icefaces3\branches\icefaces-3.0.x-maintenance\icefaces\compat\components\src\main\java\com\icesoft\faces\component\util\CustomComponentUtils.java Modified: C:\svn\ossrepo\icefaces3\branches\icefaces-3.0.x-maintenance\icefaces\compat\core\src\main\java\com\icesoft\faces\renderkit\dom_html_basic\CommandLinkRenderer.java Modified: C:\svn\ossrepo\icefaces3\branches\icefaces-3.0.x-maintenance\icefaces\compat\core\src\main\java\com\icesoft\faces\renderkit\dom_html_basic\DomBasicRenderer.java Modified: C:\svn\ossrepo\icefaces3\branches\icefaces-3.0.x-maintenance\icefaces\compat\core\src\main\java\com\icesoft\util\CoreComponentUtils.java Modified: C:\svn\ossrepo\icefaces3\branches\icefaces-3.0.x-maintenance\icefaces\core\src\main\java\org\icefaces\util\FocusController.java Completed: At revision: 30146
              yip.ng made changes -
              Status Reopened [ 4 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  yip.ng
                  Reporter:
                  Arran Mccullough
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: