ICEfaces
  1. ICEfaces
  2. ICE-8275

Optimise generated Base code for IceClientBehaviorHolder implementation

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.1.0.BETA1
    • Fix Version/s: 3.1.0.RC1, 3.1
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      ACE
    • Assignee Priority:
      P1

      Description

      ClientBehaviorHolder Base classes should generate getEventNames(), getDefaultRender(-), getDefaultExecute(-) methods that return static immutable collections, much like how Panel has this:

      private static final Collection<String> EVENT_NAMES = Collections.unmodifiableCollection(Arrays.asList(DEFAULT_EVENT));

      And Panel shouldn't be overriding this, it should just be in PanelBase.

        Activity

        Hide
        Mark Collette added a comment -

        Committed the generator change and Panel cleanup.

        trunk
        Subversion 29665

        Show
        Mark Collette added a comment - Committed the generator change and Panel cleanup. trunk Subversion 29665
        Hide
        Mark Collette added a comment -

        Cleaned up Dialog as well.

        icefaces3 trunk
        Subversion 29797

        Show
        Mark Collette added a comment - Cleaned up Dialog as well. icefaces3 trunk Subversion 29797

          People

          • Assignee:
            Mark Collette
            Reporter:
            Mark Collette
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: