ICEfaces
  1. ICEfaces
  2. ICE-8275

Optimise generated Base code for IceClientBehaviorHolder implementation

          Details

          • Type: Improvement Improvement
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 3.1.0.BETA1
          • Fix Version/s: 3.1.0.RC1, 3.1
          • Component/s: ACE-Components
          • Labels:
            None
          • Environment:
            ACE
          • Assignee Priority:
            P1

            Description

            ClientBehaviorHolder Base classes should generate getEventNames(), getDefaultRender(-), getDefaultExecute(-) methods that return static immutable collections, much like how Panel has this:

            private static final Collection<String> EVENT_NAMES = Collections.unmodifiableCollection(Arrays.asList(DEFAULT_EVENT));

            And Panel shouldn't be overriding this, it should just be in PanelBase.

              Activity

              Ascending order - Click to sort in descending order
              Mark Collette created issue -
              Ken Fyten made changes -
              Field Original Value New Value
              Salesforce Case []
              Fix Version/s 3.1.0.RC1 [ 10337 ]
              Fix Version/s 3.1 [ 10312 ]
              Assignee Priority P1
              Assignee Mark Collette [ mark.collette ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #29665 Fri Jun 22 23:44:49 MDT 2012 mark.collette ICE-8275 : Optimise generated Base code for IceClientBehaviorHolder implementation
              Files Changed
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/panel/Panel.java
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/generator/src/org/icefaces/ace/generator/behavior/ClientBehaviorHolder.java
              Hide
              Permalink
              Mark Collette added a comment -

              Committed the generator change and Panel cleanup.

              trunk
              Subversion 29665

              Show
              Mark Collette added a comment - Committed the generator change and Panel cleanup. trunk Subversion 29665
              Mark Collette made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #29797 Tue Jul 03 22:22:54 MDT 2012 mark.collette ICE-8275 : Optimise generated Base code for IceClientBehaviorHolder implementation
              Files Changed
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/dialog/Dialog.java
              Hide
              Permalink
              Mark Collette added a comment -

              Cleaned up Dialog as well.

              icefaces3 trunk
              Subversion 29797

              Show
              Mark Collette added a comment - Cleaned up Dialog as well. icefaces3 trunk Subversion 29797
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Mark Collette
                  Reporter:
                  Mark Collette
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: