ICEfaces
  1. ICEfaces
  2. ICE-8263

Add new icecore:setEventPhase component

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.1
    • Component/s: Framework
    • Labels:
      None
    • Environment:
      ICEfaces core components
    • Assignee Priority:
      P1
    • Affects:
      Documentation (User Guide, Ref. Guide, etc.), Sample App./Tutorial, Compatibility/Configuration

      Description

      The ice:setEventPhase component is a useful utility with any other components, ice:, h:, ace:, etc. As such, we should move it to core so that applications can make use of it with all other components, without needing to include compat. It would then be in the icecore: namespace.

      For backwards compatibility, we should probably leave a sub-class in compat, and keep that accessible using the ice: namespace.

        Activity

        Mark Collette created issue -
        Hide
        Mark Collette added a comment -

        I've noticed a regression jira about setEventPhase. We should probably fix ICE-8233 before moving it to core.

        Also, I noticed that with ICE-4983 a fix for setEventPhase was made to icefaces trunk but not to icefaces3 trunk. We should probably incorporate that fix into icefaces3.

        Show
        Mark Collette added a comment - I've noticed a regression jira about setEventPhase. We should probably fix ICE-8233 before moving it to core. Also, I noticed that with ICE-4983 a fix for setEventPhase was made to icefaces trunk but not to icefaces3 trunk. We should probably incorporate that fix into icefaces3.
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #29552 Tue Jun 19 17:34:07 MDT 2012 ted.goddard icecore:setEventPhase component (ICE-8263)
        Files Changed
        Commit graph MODIFY /icefaces3/trunk/icefaces/core/src/main/resources/META-INF/core.taglib.xml
        Commit graph MODIFY /icefaces3/trunk/icefaces/core/src/main/resources/META-INF/core.tld
        Commit graph ADD /icefaces3/trunk/icefaces/core/src/main/java/org/icefaces/impl/component/SetEventPhase.java
        Ken Fyten made changes -
        Field Original Value New Value
        Summary Move compat setEventPhase to core Add new icecore:setEventPhase component
        Environment ICEfaces core, ACE ICEfaces core components
        Salesforce Case []
        Component/s Framework [ 10013 ]
        Component/s Components [ 10012 ]
        Fix Version/s 3.1 [ 10312 ]
        Affects [Documentation (User Guide, Ref. Guide, etc.), Sample App./Tutorial, Compatibility/Configuration]
        Assignee Priority P1
        Affects Version/s 3.1.0.BETA1 [ 10335 ]
        Description The setEventPhase component is a useful utility with any other components, ice:, h:, ace:, etc. As such, we should move it to core so that applications can make use of it with all other components, without needing to include compat. It would then be in the icecore: namespace.

        For backwards compatibility, we should probably leave a sub-class in compat, and keep that accessible using the ice: namespace.
        The ice:setEventPhase component is a useful utility with any other components, ice:, h:, ace:, etc. As such, we should move it to core so that applications can make use of it with all other components, without needing to include compat. It would then be in the icecore: namespace.

        For backwards compatibility, we should probably leave a sub-class in compat, and keep that accessible using the ice: namespace.
        Assignee Ted Goddard [ ted.goddard ]
        Ken Fyten made changes -
        Salesforce Case []
        Fix Version/s 3.1.0.RC1 [ 10337 ]
        Hide
        Ted Goddard added a comment -

        Component is moved into core, but ICE-4983 has not been applied.
        No test case exists for the component in the new namespace.

        Show
        Ted Goddard added a comment - Component is moved into core, but ICE-4983 has not been applied. No test case exists for the component in the new namespace.
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #29584 Wed Jun 20 14:37:29 MDT 2012 ted.goddard showcase now using icecore:setEventPhase (ICE-8263)
        Files Changed
        Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/compat/eventphase/eventphase.xhtml
        Commit graph MODIFY /icefaces3/trunk/icefaces/core/src/main/resources/META-INF/faces-config.xml
        Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/compat/eventphase/eventphaseChange.xhtml
        Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/compat/eventphase/eventphaseAction.xhtml
        Hide
        Ted Goddard added a comment -

        The fix in ICE-4983 has not been applied since it is specific to a compat component. The showcase demo is now using the icecore component.

        Show
        Ted Goddard added a comment - The fix in ICE-4983 has not been applied since it is specific to a compat component. The showcase demo is now using the icecore component.
        Ted Goddard made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Ken Fyten made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Assignee Ted Goddard [ ted.goddard ] Mark Collette [ mark.collette ]
        Ken Fyten made changes -
        Salesforce Case []
        Assignee Priority P1 P2
        Ken Fyten made changes -
        Salesforce Case []
        Assignee Priority P2 P1
        Ken Fyten made changes -
        Fix Version/s 3.1.0.RC1 [ 10337 ]
        Hide
        Mark Collette added a comment -

        ICE-4983 touches on the issue that any UIData / UIRepeat container will wrap a FacesEvent, that bubbles up the queueEvent chain from within it, inside a new custom FacesEvent that includes the row information for the container. Unfortunately, with UIData and UIRepeat, those custom events are not public classes, and so there is no means to inspect the event that they wrap. So when setEventPhase tries to filter events by their type, for which it will operate on, the wrapper type is what it will find, and not the underlying true event type. ICE-4983 allowed for deep inspecting a single compat wrapper event, but didn't account for ACE containers nor the stock containers. I think it's best that we simply don't try to provide this very limited deep inspection, and instead document that the events property of setEventPhase can only be specific of the event type when directly wrapping a component, and needs to be generic ("javax.faces.event.FacesEvent" / "FacesEvent") when wrapping a container that wraps events.

        Show
        Mark Collette added a comment - ICE-4983 touches on the issue that any UIData / UIRepeat container will wrap a FacesEvent, that bubbles up the queueEvent chain from within it, inside a new custom FacesEvent that includes the row information for the container. Unfortunately, with UIData and UIRepeat, those custom events are not public classes, and so there is no means to inspect the event that they wrap. So when setEventPhase tries to filter events by their type, for which it will operate on, the wrapper type is what it will find, and not the underlying true event type. ICE-4983 allowed for deep inspecting a single compat wrapper event, but didn't account for ACE containers nor the stock containers. I think it's best that we simply don't try to provide this very limited deep inspection, and instead document that the events property of setEventPhase can only be specific of the event type when directly wrapping a component, and needs to be generic ("javax.faces.event.FacesEvent" / "FacesEvent") when wrapping a container that wraps events.
        Hide
        Mark Collette added a comment -
        Show
        Mark Collette added a comment - Wiki documentation added: http://wiki.icesoft.org/display/ICE/setEventPhase
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #29854 Sat Jul 07 18:03:38 MDT 2012 mark.collette ICE-8263 : Add new icecore:setEventPhase component
        Files Changed
        Commit graph MODIFY /icefaces3/trunk/icefaces/core/src/main/resources/META-INF/core.taglib.xml
        Commit graph MODIFY /icefaces3/trunk/icefaces/core/src/main/resources/META-INF/core.tld
        Hide
        Mark Collette added a comment -

        Added some documentation for the limitations found in ICE-4983, where events are wrapped by UIData and UIRepeat containers, so the events property won't match on their original class name.

        icefaces3 trunk
        Subversion 29854

        Show
        Mark Collette added a comment - Added some documentation for the limitations found in ICE-4983 , where events are wrapped by UIData and UIRepeat containers, so the events property won't match on their original class name. icefaces3 trunk Subversion 29854
        Mark Collette made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Mark Collette
            Reporter:
            Mark Collette
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: