ICEfaces
  1. ICEfaces
  2. ICE-8241

ACE menu components lose styling after dynamic updates

    Details

    • Assignee Priority:
      P1

      Description

      ace:menu, ace:menuButton and ace:contextMenu lose their styling after dynamic updates that change the structure of the menu (i.e. adding, removing or modifying a menu item or submenu). This is caused by having a client id in the root <ul> element, so when the structure of the menu changes the dom diff only sends an update starting from this <ul> element, and it doesn't send an update for the <script> tag that re-runs the initialization function that ultimately applies all the styling in the client. This is somehow related to ICE-7816. The problem was initially reported in ICE-7323.

      Steps to reproduce:

      1. Build and deploy the test application located at http://server.ice:8888/svn/repo/qa/trunk/Regression-Icefaces2/Sparkle/Nightly/menu/
      2. Go to the menuDynAttribute.jsf test page
      3. Checking the 'rendered' box first and then check the 'tiered' box
      4. See how the menu loses all it styling and looks like a plain HTML list.

      ICE-7323 also describes how to reproduce the problem using the menuDisable.xhtml test page of the same application..

        Issue Links

          Activity

          Repository Revision Date User Message
          ICEsoft Public SVN Repository #29467 Tue Jun 12 12:46:01 MDT 2012 art.zambrano ICE-8241 fix to prevent the menus from losing their styling after dynamic updates
          Files Changed
          Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/menu/MenuRenderer.java
          Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/menu/menu.js
          Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/contextmenu/ContextMenuRenderer.java
          Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/menubutton/MenuButtonRenderer.java
          Arturo Zambrano created issue -
          Arturo Zambrano made changes -
          Field Original Value New Value
          Assignee Arturo Zambrano [ artzambrano ]
          Arturo Zambrano made changes -
          Link This issue blocks ICE-7323 [ ICE-7323 ]
          Hide
          Arturo Zambrano added a comment -

          Committed fix at revision 29467.

          Removed the client id from the root <ul> element, placed the script tag inside the root container, and adjusted jquery selectors in the client.

          Show
          Arturo Zambrano added a comment - Committed fix at revision 29467. Removed the client id from the root <ul> element, placed the script tag inside the root container, and adjusted jquery selectors in the client.
          Ken Fyten made changes -
          Salesforce Case []
          Fix Version/s 3.1 [ 10312 ]
          Assignee Priority P1
          Ken Fyten made changes -
          Salesforce Case []
          Fix Version/s EE-3.0.0.GA_P01 [ 10327 ]
          Affects Version/s EE-3.0.0.GA [ 10262 ]
          Affects Version/s 3.0.1 [ 10282 ]
          Affects Version/s 3.1.0.BETA2 [ 10336 ]
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #29497 Wed Jun 13 17:29:38 MDT 2012 art.zambrano ICE-8241 fix to prevent the menus from losing their styling after dynamic updates
          Files Changed
          Commit graph MODIFY /icefaces3/branches/icefaces-3.0.x-maintenance/icefaces/ace/component/src/org/icefaces/ace/component/menu/MenuRenderer.java
          Commit graph MODIFY /icefaces3/branches/icefaces-3.0.x-maintenance/icefaces/ace/component/src/org/icefaces/ace/component/menubutton/MenuButtonRenderer.java
          Commit graph MODIFY /icefaces3/branches/icefaces-3.0.x-maintenance/icefaces/ace/component/resources/icefaces.ace/menu/menu.js
          Commit graph MODIFY /icefaces3/branches/icefaces-3.0.x-maintenance/icefaces/ace/component/src/org/icefaces/ace/component/contextmenu/ContextMenuRenderer.java
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #29498 Wed Jun 13 17:41:11 MDT 2012 art.zambrano ICE-8241 prevented bullets from appearing in child submenus of tiered ace:menu
          Files Changed
          Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/wijmo/wijmo.css
          Hide
          Arturo Zambrano added a comment -

          Applied fix to maintenance branch at revision 29497.

          Also committed a fix for preventing the bullets from appearing in child submenus of tiered ace:menu's.

          Show
          Arturo Zambrano added a comment - Applied fix to maintenance branch at revision 29497. Also committed a fix for preventing the bullets from appearing in child submenus of tiered ace:menu's.
          Arturo Zambrano made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Ken Fyten made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              Arturo Zambrano
              Reporter:
              Arturo Zambrano
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: