[ICE-8240] Clicking enter key in an ice:inputText field causes two submits to occur - ICEsoft JIRA Issue Tracker

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: EE-1.8.2.GA_P04
Fix Version/s: EE-3.0.0.GA_P01, 3.2, EE-1.8.2.GA_P05
Component/s: ICE-Components
Labels:
None
Environment:
ICEfaces EE 1.8.2 P04

Description

When the enter key is pressed in an ice:inputText field, two submits are sent to the server. In addition to this there is an ice:selectInputDate component on the page. When the enter key is pressed the date popup is opened.

This is not an issue with the ICEfaces EE 1.8.2 P03 release.

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Download All

Attachments

Hide
Case11504Example.war

01/Aug/12 4:03 PM

6.66 MB

Arran Mccullough
META-INF/MANIFEST.MF 0.1 kB

META-INF/context.xml 0.1 kB

WEB-INF/classes/com/.../example/Item.class 0.3 kB

WEB-INF/classes/.../example/TestBean.class 0.6 kB

WEB-INF/faces-config.xml 0.8 kB

WEB-INF/lib/FastInfoset.jar 285 kB

WEB-INF/lib/backport-util-concurrent.jar 319 kB

WEB-INF/lib/commons-beanutils.jar 226 kB

WEB-INF/lib/commons-collections.jar 558 kB

WEB-INF/lib/commons-digester.jar 140 kB

WEB-INF/lib/commons-discovery.jar 75 kB

WEB-INF/lib/commons-fileupload.jar 56 kB

WEB-INF/lib/commons-lang.jar 240 kB

WEB-INF/lib/commons-logging.jar 52 kB

WEB-INF/lib/icefaces-comps.jar 1.76 MB

WEB-INF/lib/icefaces-facelets.jar 596 kB

WEB-INF/lib/icefaces.jar 1.23 MB

WEB-INF/lib/jsf-api-1.2.jar 355 kB

WEB-INF/lib/jsf-impl-1.2.jar 837 kB

WEB-INF/web.xml 4 kB

welcomeICEfaces.xhtml 0.8 kB

Download Zip
Show

Case11504Example.war

01/Aug/12 4:03 PM

6.66 MB

Arran Mccullough
Case11504Example.zip

01/Aug/12 4:03 PM

20 kB

Arran Mccullough

Activity

Ascending order - Click to sort in descending order

Arran Mccullough created issue - 12/Jun/12 10:39 AM

Hide

Permalink

Arran Mccullough added a comment - 12/Jun/12 10:42 AM

Attaced test case that reproduces the issue.

Steps:

Load welcomeICEfaces.iface
Focus into the input field and hit the enter key.
In the console logs two updates are seen and the selectInputDate popup is shown.

Show

Arran Mccullough added a comment - 12/Jun/12 10:42 AM Attaced test case that reproduces the issue. Steps: Load welcomeICEfaces.iface Focus into the input field and hit the enter key. In the console logs two updates are seen and the selectInputDate popup is shown.

Arran Mccullough made changes - 12/Jun/12 10:42 AM

Field	Original Value	New Value
Attachment		Case11345Example.war [ 14560 ]
Attachment		Case11345Example.zip [ 14561 ]

Ken Fyten made changes - 13/Jun/12 10:09 AM

Salesforce Case		[]
Fix Version/s		EE-1.8.2.GA_P05 [ 10331 ]
Assignee Priority		P1
Assignee		Arturo Zambrano [ artzambrano ]

Ken Fyten made changes - 13/Jun/12 10:10 AM

Salesforce Case		[]
Assignee	Arturo Zambrano [ artzambrano ]	Mircea Toma [ mircea.toma ]

Arran Mccullough made changes - 13/Jun/12 10:10 AM

Salesforce Case

[5007000000MHrE4]

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#29800	Wed Jul 04 10:01:24 MDT 2012	mircea.toma	~~ICE-8240~~ Cancel the default action during the keypress event to prevent the 'click' event from being sintetically generated during the form submission triggered by the enter key.
				Files Changed
				MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/ext/renderkit/InputTextRenderer.java

Hide

Permalink

Mircea Toma added a comment - 04/Jul/12 11:04 AM

Indeed the changes for ~~ICE-7186~~ created this regression. The 'key press' event had its default action canceled when iceSubmit was invoked. Once the iceSubmit call was moved to the 'onkeyup' handler the default action is not canceled anymore.

The applied fix changes the renderer to write out the 'onkeypress' handler that will cancels the default action during the key press event. This will prevent the 'click' event from being sintetically generated during the form submission triggered by the enter key.

Show

Mircea Toma added a comment - 04/Jul/12 11:04 AM Indeed the changes for ICE-7186 created this regression. The 'key press' event had its default action canceled when iceSubmit was invoked. Once the iceSubmit call was moved to the 'onkeyup' handler the default action is not canceled anymore. The applied fix changes the renderer to write out the 'onkeypress' handler that will cancels the default action during the key press event. This will prevent the 'click' event from being sintetically generated during the form submission triggered by the enter key.

Mircea Toma made changes - 04/Jul/12 11:04 AM

Status	Open [ 1 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

Arran Mccullough made changes - 31/Jul/12 11:59 AM

Salesforce Case

[5007000000MHrE4]

[5007000000MHrE4, 5007000000NI0pi]

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#30348	Wed Aug 01 08:17:27 MDT 2012	mircea.toma	~~ICE-8240~~ Lookup view state element by its name, only when it fails try searching it among the form elements.
				Files Changed
				MODIFY /icefaces3/trunk/icefaces/core/src/main/javascript/application.js

Arran Mccullough made changes - 01/Aug/12 4:01 PM

Attachment

Case11345Example.war [ 14560 ]

Arran Mccullough made changes - 01/Aug/12 4:01 PM

Attachment

Case11345Example.zip [ 14561 ]

Hide

Permalink

Arran Mccullough added a comment - 01/Aug/12 4:02 PM

The changes made are preventing any inputs into the ice:inputText component.

Show

Arran Mccullough added a comment - 01/Aug/12 4:02 PM The changes made are preventing any inputs into the ice:inputText component.

Arran Mccullough made changes - 01/Aug/12 4:02 PM

Resolution	Fixed [ 1 ]
Status	Resolved [ 5 ]	Reopened [ 4 ]

Hide

Permalink

Arran Mccullough added a comment - 01/Aug/12 4:03 PM

Attached test case that demonstrates the recent issue. Typing into an inputText field does nothing.

Show

Arran Mccullough added a comment - 01/Aug/12 4:03 PM Attached test case that demonstrates the recent issue. Typing into an inputText field does nothing.

Arran Mccullough made changes - 01/Aug/12 4:03 PM

Attachment		Case11504Example.war [ 14769 ]
Attachment		Case11504Example.zip [ 14770 ]

Hide

Permalink

Arran Mccullough added a comment - 08/Aug/12 11:50 AM

Another customer is also seeing this issue in ICEfaces EE 3.0.0, if the fixes for this could be made to the 3.x branch/trunk also.

Show

Arran Mccullough added a comment - 08/Aug/12 11:50 AM Another customer is also seeing this issue in ICEfaces EE 3.0.0, if the fixes for this could be made to the 3.x branch/trunk also.

Ken Fyten made changes - 13/Aug/12 4:04 PM

Fix Version/s		EE-3.0.0.GA_P01 [ 10327 ]
Fix Version/s		3.2 [ 10338 ]

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#30484	Tue Aug 14 05:24:03 MDT 2012	mircea.toma	~~ICE-8240~~ Cancel default action only when Enter key is pressed.
				Files Changed
				MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/ext/renderkit/InputTextRenderer.java

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#30485	Tue Aug 14 05:29:24 MDT 2012	mircea.toma	~~ICE-8240~~ Cancel default action only when Enter key is pressed.
				Files Changed
				MODIFY /icefaces3/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/ext/renderkit/InputTextRenderer.java

Hide

Permalink

Mircea Toma added a comment - 14/Aug/12 6:30 AM

The latest fix makes sure to cancel default action only when Enter key is pressed.

Show

Mircea Toma added a comment - 14/Aug/12 6:30 AM The latest fix makes sure to cancel default action only when Enter key is pressed.

Mircea Toma made changes - 14/Aug/12 6:30 AM

Status	Reopened [ 4 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

Ken Fyten made changes - 14/Aug/12 10:31 AM

Resolution	Fixed [ 1 ]
Status	Resolved [ 5 ]	Reopened [ 4 ]

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#30488	Tue Aug 14 12:18:28 MDT 2012	mircea.toma	~~ICE-8240~~ Cancel default action only when Enter key is pressed.
				Files Changed
				MODIFY /icefaces3/branches/icefaces-3.0.x-maintenance/icefaces/compat/components/src/main/java/com/icesoft/faces/component/ext/renderkit/InputTextRenderer.java

Hide

Permalink

Mircea Toma added a comment - 14/Aug/12 1:19 PM

Applied fix to maintenance branch as well.

Show

Mircea Toma added a comment - 14/Aug/12 1:19 PM Applied fix to maintenance branch as well.

Mircea Toma made changes - 14/Aug/12 1:19 PM

Status	Reopened [ 4 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#30521	Thu Aug 16 10:47:27 MDT 2012	mircea.toma	ICE-8470 Introduced ice.cancelEnterKeyEvent public function that use by InputTextRenderer to cancel the keypress events in ICEfaces3. This is a follow up fix for ~~ICE-8240~~, unlike ICEfaces 1.8 the event functions are publicly exposed hence the JS error seen previously.
				Files Changed
				MODIFY /icefaces3/trunk/icefaces/compat/core/src/main/javascript/compat.js MODIFY /icefaces3/trunk/icefaces/compat/core/build.javascript.xml MODIFY /icefaces3/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/ext/renderkit/InputTextRenderer.java

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#30522	Thu Aug 16 10:47:38 MDT 2012	mircea.toma	ICE-8470 Introduced ice.cancelEnterKeyEvent public function that use by InputTextRenderer to cancel the keypress events in ICEfaces3. This is a follow up fix for ~~ICE-8240~~, unlike ICEfaces 1.8 the event functions are publicly exposed hence the JS error seen previously.
				Files Changed
				MODIFY /icefaces3/branches/icefaces-3.0.x-maintenance/icefaces/compat/core/build.javascript.xml MODIFY /icefaces3/branches/icefaces-3.0.x-maintenance/icefaces/compat/core/src/main/javascript/compat.js MODIFY /icefaces3/branches/icefaces-3.0.x-maintenance/icefaces/compat/components/src/main/java/com/icesoft/faces/component/ext/renderkit/InputTextRenderer.java

Ken Fyten made changes - 30/Nov/12 11:46 PM

Status	Resolved [ 5 ]	Closed [ 6 ]
Assignee Priority	P1 [ 10010 ]

People

Assignee:

Mircea Toma

Reporter:

Arran Mccullough

Votes:

0 Vote for this issue

Watchers:

0 Start watching this issue

Dates

Created:

12/Jun/12 10:39 AM

Updated:

30/Nov/12 11:46 PM

Resolved:

14/Aug/12 1:19 PM