[ICE-8229] ICEfaces3 MyFaces Regression - sample - fajax toggle count - ICEsoft JIRA Issue Tracker

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 3.1.0.BETA2
Fix Version/s: 3.1.0.RC1, 3.1
Component/s: QA, Sample Apps
Labels:
None
Environment:
Icefaces3.0 trunk revision# 29330
Server: tomcat6
Browser: IE7
Last Known Working Revision#:29228

Assignee Priority:
P1
Affects:

Compatibility/Configuration

Description

fajax:
Fails manually in IE - toggle counts stops after 2 toggle counts, exception below causes User Session Expired error (see attached image)
WARNING: queued exception
javax.faces.application.ViewExpiredException: /index.xhtmlNo saved view state could be found for the view identifier: /index.xhtml
    at org.apache.myfaces.lifecycle.RestoreViewExecutor.execute(RestoreViewExecutor.java:132)
    at org.apache.myfaces.lifecycle.LifecycleImpl.executePhase(LifecycleImpl.java:170)
    at org.apache.myfaces.lifecycle.LifecycleImpl.execute(LifecycleImpl.java:117)
    at javax.faces.webapp.FacesServlet.service(FacesServlet.java:197)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
    at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233)
    at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:191)
    at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:127)
    at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102)
    at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109)
    at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:298)
    at org.apache.coyote.http11.Http11AprProcessor.process(Http11AprProcessor.java:859)
    at org.apache.coyote.http11.Http11AprProtocol$Http11ConnectionHandler.process(Http11AprProtocol.java:579)
    at org.apache.tomcat.util.net.AprEndpoint$Worker.run(AprEndpoint.java:1555)
    at java.lang.Thread.run(Thread.java:619)

To reproduce:
click on any of the toggle buttons more that two times. Toggle count gets stuck at 2.

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Download All

Attachments

Hide
fajax.war

13/Jun/12 10:36 AM

4.26 MB

Jerome Ruzol
META-INF/MANIFEST.MF 0.1 kB

WEB-INF/sun-web.xml 1 kB

WEB-INF/web.xml 2 kB

disabledCommandButtons.xhtml 4 kB

disabledCommandLinks.xhtml 4 kB

index.xhtml 5 kB

WEB-INF/lib/icefaces.jar 309 kB

WEB-INF/lib/icepush.jar 323 kB

WEB-INF/lib/jstl.jar 20 kB

WEB-INF/lib/commons-beanutils-1.8.3.jar 227 kB

WEB-INF/lib/commons-codec-1.4.jar 57 kB

WEB-INF/lib/commons-collections-3.2.jar 558 kB

WEB-INF/lib/commons-digester-2.1.jar 192 kB

WEB-INF/lib/commons-logging-1.1.1.jar 59 kB

WEB-INF/.../myfaces-api-2.1.7-ice-7899.jar 1.12 MB

WEB-INF/.../myfaces-impl-2.1.7-ice-7899.jar 1.89 MB

WEB-INF/classes/org/.../ajax/AjaxBean.class 2 kB

Download Zip
Show

fajax.war

13/Jun/12 10:36 AM

4.26 MB

Jerome Ruzol
ICE-8229.patch

21/Jun/12 4:29 PM

1 kB

Mircea Toma

Issue Links

blocks

ICE-8290 MyFaces 2.1.7 patches

Closed

Activity

Ascending order - Click to sort in descending order

Jerome Ruzol created issue - 07/Jun/12 5:30 PM

Ken Fyten made changes - 07/Jun/12 6:10 PM

Field	Original Value	New Value
Salesforce Case		[]
Fix Version/s		3.1.0.RC1 [ 10337 ]
Fix Version/s		3.1 [ 10312 ]
Assignee Priority		P1
Assignee		Mircea Toma [ mircea.toma ]

Hide

Permalink

Mircea Toma added a comment - 12/Jun/12 3:29 PM

I cannot reproduce the issue when using the trunk code.

Show

Mircea Toma added a comment - 12/Jun/12 3:29 PM I cannot reproduce the issue when using the trunk code.

Mircea Toma made changes - 12/Jun/12 3:29 PM

Status	Open [ 1 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

Jerome Ruzol made changes - 13/Jun/12 10:36 AM

Attachment

fajax.war [ 14569 ]

Hide

Permalink

Jerome Ruzol added a comment - 13/Jun/12 10:45 AM

The same error still exist; in addition, a random failure in which the increment pass over 2, but stops after some random number. I have attached the fajax war file that has the error. Please deploy app on tomcat6 and run in IE7.

Show

Jerome Ruzol added a comment - 13/Jun/12 10:45 AM The same error still exist; in addition, a random failure in which the increment pass over 2, but stops after some random number. I have attached the fajax war file that has the error. Please deploy app on tomcat6 and run in IE7.

Jerome Ruzol made changes - 13/Jun/12 10:45 AM

Resolution	Fixed [ 1 ]
Status	Resolved [ 5 ]	Reopened [ 4 ]

Hide

Permalink

Mircea Toma added a comment - 13/Jun/12 5:58 PM

I retested using the attached war. I still cannot reproduce the issue. Maybe you can use another machine for testing, just to make sure that it is not something else in your environment causing the problem to occur.

Show

Mircea Toma added a comment - 13/Jun/12 5:58 PM I retested using the attached war. I still cannot reproduce the issue. Maybe you can use another machine for testing, just to make sure that it is not something else in your environment causing the problem to occur.

Hide

Permalink

Jerome Ruzol added a comment - 14/Jun/12 1:04 PM

Tested on another machine with Internet Explorer ver 7 with application deployed to tomcat v6.26, able to reproduce error. Confirmed that the issue does not exist on IE8 or IE9.

Show

Jerome Ruzol added a comment - 14/Jun/12 1:04 PM Tested on another machine with Internet Explorer ver 7 with application deployed to tomcat v6.26, able to reproduce error. Confirmed that the issue does not exist on IE8 or IE9.

Hide

Permalink

Mircea Toma added a comment - 21/Jun/12 4:29 PM

The regression can be reproduce only with a freshly opened IE7 instance. Once the page is reloaded the problem is gone.

The issue resides in the Myfaces code that updates the javax.faces.ViewState key in the hidden input elements found in the page. During the second update the lookup for the 'javax.faces.ViewState' named input element fails. The element[name] syntax is used for the lookup which is known to fail for elements with complex names (such as 'javax.faces.ViewState').
When the lookup fails Myfaces will create a second input element which will contain the new javax.faces.ViewState value. The next submit will send two 'javax.faces.ViewState' parameters but only the first one (the oldest) is read by the server state manager . This old key is not known to the server anymore, hence the ViewExpired exception.

Show

Mircea Toma added a comment - 21/Jun/12 4:29 PM The regression can be reproduce only with a freshly opened IE7 instance. Once the page is reloaded the problem is gone. The issue resides in the Myfaces code that updates the javax.faces.ViewState key in the hidden input elements found in the page. During the second update the lookup for the 'javax.faces.ViewState' named input element fails. The element [name] syntax is used for the lookup which is known to fail for elements with complex names (such as 'javax.faces.ViewState'). When the lookup fails Myfaces will create a second input element which will contain the new javax.faces.ViewState value. The next submit will send two 'javax.faces.ViewState' parameters but only the first one (the oldest) is read by the server state manager . This old key is not known to the server anymore, hence the ViewExpired exception.

Mircea Toma made changes - 21/Jun/12 4:29 PM

Attachment

ICE-8229.patch [ 14621 ]

Hide

Permalink

Mircea Toma added a comment - 21/Jun/12 4:30 PM

The attached patch replaces the element[name] lookup with a loop that iterates over the form elements to find the input element that needs to have its value updated.

Show

Mircea Toma added a comment - 21/Jun/12 4:30 PM The attached patch replaces the element [name] lookup with a loop that iterates over the form elements to find the input element that needs to have its value updated.

Hide

Permalink

Mircea Toma added a comment - 21/Jun/12 4:44 PM

Created issue in Myfaces' JIRA system: https://issues.apache.org/jira/browse/MYFACES-3574 .

Show

Mircea Toma added a comment - 21/Jun/12 4:44 PM Created issue in Myfaces' JIRA system: https://issues.apache.org/jira/browse/MYFACES-3574 .

Mircea Toma made changes - 21/Jun/12 4:48 PM

Assignee

Mircea Toma [ mircea.toma ]

Deryk Sinotte [ deryk.sinotte ]

Deryk Sinotte made changes - 21/Jun/12 4:58 PM

Link

This issue blocks ~~ICE-8290~~ [ ~~ICE-8290~~ ]

Hide

Permalink

Deryk Sinotte added a comment - 21/Jun/12 6:20 PM

I have patched MyFaces and committed the new libs to the trunk of the repository. Resolving as fixed.

Show

Deryk Sinotte added a comment - 21/Jun/12 6:20 PM I have patched MyFaces and committed the new libs to the trunk of the repository. Resolving as fixed.

Deryk Sinotte made changes - 21/Jun/12 6:20 PM

Status	Reopened [ 4 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#29685	Tue Jun 26 11:31:48 MDT 2012	deryk.sinotte	~~ICE-8018~~: updated to MyFaces 2.1.8 release with patch for ~~ICE-8229~~ applied
				Files Changed
				ADD /icefaces3/trunk/icefaces/lib/myfaces/myfaces-impl-2.1.8-ice-8229.jar ADD /icefaces3/trunk/icefaces/lib/myfaces/myfaces-api-2.1.8-ice-8229.jar DEL /icefaces3/trunk/icefaces/lib/myfaces/myfaces-api-2.1.7-ice-8290.jar DEL /icefaces3/trunk/icefaces/lib/myfaces/myfaces-impl-2.1.7-ice-8290.jar

Ken Fyten made changes - 27/Jun/12 5:26 PM

Salesforce Case		[]
Affects		[Compatibility/Configuration]
Security	Private [ 10001 ]

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#30936	Wed Sep 19 15:33:08 MDT 2012	ken.fyten	Publishing MyFaces 2.1.8-ice-8229 library to maven snapshots repo (patched MyFaces 2.1.8).
				Files Changed
				ADD /maven2/snapshots/org/apache/myfaces/core/myfaces-api/2.1.8-ice-8229/myfaces-api-2.1.8-ice-8229.jar ADD /maven2/snapshots/org/apache/myfaces/core/myfaces-impl/2.1.8-ice-8229 ADD /maven2/snapshots/org/apache/myfaces/core/myfaces-api/2.1.8-ice-8229/myfaces-api-2.1.8-ice-8229.pom ADD /maven2/snapshots/org/apache/myfaces/core/myfaces-impl/2.1.8-ice-8229/myfaces-impl-2.1.8-ice-8229.pom ADD /maven2/snapshots/org/apache/myfaces/core/myfaces-impl/2.1.8-ice-8229/myfaces-impl-2.1.8-ice-8229.jar ADD /maven2/snapshots/org/apache/myfaces/core/myfaces-api/2.1.8-ice-8229

Ken Fyten made changes - 14/Nov/14 5:36 PM

Status

Resolved [ 5 ]

Closed [ 6 ]

People

Assignee:

Deryk Sinotte

Reporter:

Jerome Ruzol

Votes:

0 Vote for this issue

Watchers:

0 Start watching this issue

Dates

Created:

07/Jun/12 5:30 PM

Updated:

14/Nov/14 5:36 PM

Resolved:

21/Jun/12 6:20 PM