ICEfaces
  1. ICEfaces
  2. ICE-8178

Remove dependency on "javax.portlet.faces.bridgeContext" request attribute in FileEntryPhaseListener (was: Remove depedency on "javax.portlet.faces.bridgeContext" request attribute in FileEntryPhaseListener)

          Details

          • Type: Improvement Improvement
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 3.1.0.BETA1
          • Fix Version/s: EE-3.3.0.GA_P02, 4.0
          • Component/s: ACE-Components
          • Labels:
            None
          • Environment:
            Portlets

            Description

            The FileEntryPhaseListener#setPortletRequestWrapper(Object) method contains some workarounds for some things that should be fixed in the bridge. One such hack is getting the BridgeContext instance by calling PortletRequest.getAttribute("javax.portlet.faces.bridgeContext") so that the setPortletRequest(PortletRequest) method can be called.

            I think the latest version of Liferay Faces Bridge may have fixed all the problems that these workarounds are there to solve. In addition, the following issue documents that the "javax.portlet.faces.bridgeContext" request attribute has been deprecated:
            http://issues.liferay.com/browse/FACES-1253

              Activity

              Repository Revision Date User Message
              ICEsoft Public SVN Repository #40478 Fri Mar 28 11:31:40 MDT 2014 deryk.sinotte ICE-8178: implement getPart* methods in our ProxyHttpServletRequest to allow FileEntryResourceHandler to work and remove the check for the deprecated 'javax.portlet.faces.bridgeContext' attribute as noted in the original description of the case
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/fileentry/FileEntryResourceHandler.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/core/src/main/java/org/icefaces/impl/push/servlet/ProxyHttpServletRequest.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #40475 Thu Mar 27 18:03:15 MDT 2014 deryk.sinotte ICE-8178: turn off the namespacing requirement for all portlets
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase-portlet/src/main/webapp/WEB-INF/liferay-portlet.xml
              Commit graph MODIFY /icefaces4/trunk/icefaces/samples/core/chat-portlet/src/main/webapp/WEB-INF/liferay-portlet.xml
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #40451 Thu Mar 27 14:16:26 MDT 2014 deryk.sinotte ICE-8178: update Liferay config files
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/samples/core/chat-portlet/src/main/webapp/WEB-INF/portlet.xml
              Commit graph MODIFY /icefaces4/trunk/icefaces/samples/core/chat-portlet/src/main/webapp/WEB-INF/liferay-portlet.xml
              Commit graph MODIFY /icefaces4/trunk/icefaces/samples/core/chat-portlet/src/main/webapp/WEB-INF/liferay-display.xml
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #40442 Thu Mar 27 11:48:21 MDT 2014 deryk.sinotte ICE-8178: use safe method for retrieving the session so that portlets don't blow up
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/core/src/main/java/org/icefaces/util/ClientDescriptor.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #40441 Thu Mar 27 11:45:28 MDT 2014 deryk.sinotte ICE-8178: remove old bridge listeners and turn off resource coalescing for portlet examples
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase-portlet/src/main/webapp/WEB-INF/web.xml
              Commit graph MODIFY /icefaces4/trunk/icefaces/samples/core/chat-portlet/src/main/webapp/WEB-INF/web.xml
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #40440 Thu Mar 27 11:35:43 MDT 2014 deryk.sinotte ICE-8178: update poms to use recommended version of LiferayFaces Bridge and to use the same encoding as Ant when compiling files with Trois Riviere (ISO-8859-1 instead of UTF-8)
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/samples/pom.xml
              Commit graph MODIFY /icefaces4/trunk/icefaces/pom.xml

                People

                • Assignee:
                  Deryk Sinotte
                  Reporter:
                  Neil Griffin
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  4 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: