[ICE-8163] Application specific CSS classes are loaded before ICEfaces CSS when you disable automatic theme loading - ICEsoft JIRA Issue Tracker

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 3.0.1
Fix Version/s: 3.2
Component/s: None
Labels:
None
Environment:
Glassfish 3.1, Tomcat 7, Chrome, Firefox, Internet Explorer 9

Workaround Exists:

Yes
Workaround Description:

Hide
A formal fix for this issue depends on a new resource ordering capability in either JSF itself, or possibly ICEfaces. In the meantime, there are two possible workarounds for this issue:

1. Move the application-level CSS stylesheets into the top of the body region of the page, and out of the head. This will ensure that they are always loaded after the core icefaces stylesheets.

2. Possibly you could create a custom ThemeRoller theme with essentially empty style sheets and specify that using the org.icefaces.ace.theme config. param.

Show
A formal fix for this issue depends on a new resource ordering capability in either JSF itself, or possibly ICEfaces. In the meantime, there are two possible workarounds for this issue: 1. Move the application-level CSS stylesheets into the top of the body region of the page, and out of the head. This will ensure that they are always loaded after the core icefaces stylesheets. 2. Possibly you could create a custom ThemeRoller theme with essentially empty style sheets and specify that using the org.icefaces.ace.theme config. param.

Description

Based on http://wiki.icesoft.org/display/ICE/ace.theme you need to set the following parameter to none in order to disable automatic theme loading:

<context-param>
<param-name>org.icefaces.ace.theme</param-name>
<param-value>none</param-value>
</context-param>

When you do this, custom application style sheets are loaded first.

If you remove this parameter custom CSS will appear at the end of the header as specified in release notes:
http://wiki.icesoft.org/display/ICE/ICEfaces+3.0.1+Release+Notes

See screen shots for details.
To reproduce use attached source code.

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Download All

Attachments

Hide
Case11246Example.zip

25/May/12 3:04 PM

16 kB

Evgheni Sadovoi
Case11246Example/build.xml 3 kB

Case11246Example/.../ant-deploy.xml 4 kB

Case11246Example/.../build-impl.xml 46 kB

Case11246Example/.../genfiles.properties 0.5 kB

Case11246Example/.../private.properties 0.3 kB

Case11246Example/.../project.properties 3 kB

Case11246Example/nbproject/project.xml 0.9 kB

Case11246Example/web/.../context.xml 0.1 kB

Case11246Example/web/.../css/style.css 0.1 kB

Case11246Example/web/WEB-INF/sun-web.xml 0.5 kB

Case11246Example/web/WEB-INF/web.xml 2 kB

Case11246Example/.../welcomeICEfaces.xhtml 2 kB

Download Zip
Show

Case11246Example.zip

25/May/12 3:04 PM

16 kB

Evgheni Sadovoi
Hide
Case11246Example.fixed.zip

07/Aug/12 3:57 PM

25 kB

Mircea Toma
build.xml 3 kB

__MACOSX/._build.xml 0.2 kB

nbproject/ant-deploy.xml 4 kB

__MACOSX/nbproject/._ant-deploy.xml 0.2 kB

nbproject/build-impl.xml 46 kB

__MACOSX/nbproject/._build-impl.xml 0.2 kB

nbproject/genfiles.properties 0.5 kB

__MACOSX/nbproject/._genfiles.properties 0.2 kB

nbproject/private/private.properties 0.3 kB

__MACOSX/nbproject/.../._private.properties 0.2 kB

__MACOSX/nbproject/._private 0.2 kB

nbproject/project.properties 3 kB

__MACOSX/nbproject/._project.properties 0.2 kB

nbproject/project.xml 0.9 kB

__MACOSX/nbproject/._project.xml 0.2 kB

__MACOSX/._nbproject 0.2 kB

web/.DS_Store 6 kB

__MACOSX/web/._.DS_Store 0.1 kB

web/META-INF/context.xml 0.1 kB

__MACOSX/web/META-INF/._context.xml 0.2 kB

__MACOSX/web/._META-INF 0.2 kB

web/WEB-INF/.DS_Store 6 kB

__MACOSX/web/WEB-INF/._.DS_Store 0.1 kB

web/WEB-INF/classes/.DS_Store 6 kB

__MACOSX/web/WEB-INF/classes/._.DS_Store 0.1 kB

web/WEB-INF/.../resource-dependency.xml 0.4 kB

web/WEB-INF/sun-web.xml 0.5 kB

__MACOSX/web/WEB-INF/._sun-web.xml 0.2 kB

web/WEB-INF/web.xml 2 kB

__MACOSX/web/WEB-INF/._web.xml 0.2 kB

Showing 30 of 37 items Download Zip
Show

Case11246Example.fixed.zip

07/Aug/12 3:57 PM

25 kB

Mircea Toma

theme-none-absent.jpg

147 kB

25/May/12 3:04 PM
theme-none-present.jpg

131 kB

25/May/12 3:04 PM

Issue Links

depends on

ICE-8171 Implement resource ordering based on declared resource interdependencies

Closed

Activity

Ascending order - Click to sort in descending order

Evgheni Sadovoi created issue - 25/May/12 3:03 PM

Evgheni Sadovoi made changes - 25/May/12 3:04 PM

Field	Original Value	New Value
Attachment		theme-none-absent.jpg [ 14462 ]

Evgheni Sadovoi made changes - 25/May/12 3:04 PM

Attachment

theme-none-present.jpg [ 14463 ]

Evgheni Sadovoi made changes - 25/May/12 3:04 PM

Attachment

Case11246Example.zip [ 14464 ]

Evgheni Sadovoi made changes - 25/May/12 3:05 PM

Salesforce Case

[5007000000MFoXr]

Evgheni Sadovoi made changes - 25/May/12 3:05 PM

Assignee

Ken Fyten [ ken.fyten ]

Evgheni Sadovoi made changes - 25/May/12 3:11 PM

Description

Based on http://wiki.icesoft.org/display/ICE/ace.theme you need to set the following parameter to none in order to disable automatic theme loading:

<context-param>
<param-name>org.icefaces.ace.theme</param-name>
<param-value>none</param-value>
</context-param>

When you do this, custom application style sheets are loaded first.

If you remove this parameter custom CSS will appear at the end of the header as specified in release notes:
http://wiki.icesoft.org/display/ICE/ICEfaces+3.0.1+Release+Notes

If an application rely on custom styling instead of the default one this regression of ~~ICE-7761~~ will cause problems when the parameter is removed from web.xml

See screen shots for details.
To reproduce use attached source code.

Hide

Permalink

Evgheni Sadovoi added a comment - 25/May/12 3:20 PM

This JIRA is related to the changes we introduced in ~~ICE-7761~~

Show

Evgheni Sadovoi added a comment - 25/May/12 3:20 PM This JIRA is related to the changes we introduced in ICE-7761

Ken Fyten made changes - 25/May/12 3:54 PM

Fix Version/s		3.1.0.BETA2 [ 10336 ]
Fix Version/s		3.1 [ 10312 ]
Assignee Priority		P1
Affects Version/s		3.0.1 [ 10282 ]
Assignee	Ken Fyten [ ken.fyten ]	Arturo Zambrano [ artzambrano ]

Ken Fyten made changes - 25/May/12 4:54 PM

Assignee

Arturo Zambrano [ artzambrano ]

Mircea Toma [ mircea.toma ]

Mircea Toma made changes - 29/May/12 9:11 AM

Link

This issue depends on ~~ICE-8171~~ [ ~~ICE-8171~~ ]

Hide

Permalink

Mircea Toma added a comment - 29/May/12 9:12 AM

Chances are that ~~ICE-8171~~ resolution will fix this issue as well.

Show

Mircea Toma added a comment - 29/May/12 9:12 AM Chances are that ICE-8171 resolution will fix this issue as well.

Ken Fyten made changes - 29/May/12 5:16 PM

Assignee Priority

Ken Fyten made changes - 06/Jun/12 1:06 PM

Fix Version/s		3.1.0.RC1 [ 10337 ]
Fix Version/s	3.1.0.BETA2 [ 10336 ]

Ken Fyten made changes - 13/Jun/12 11:45 AM

Workaround Description		A formal fix for this issue depends on a new resource ordering capability in either JSF itself, or possibly ICEfaces. In the meantime, there are two possible workarounds for this issue: 1. Move the application-level CSS stylesheets into the top of the body region of the page, and out of the head. This will ensure that they are always loaded after the core icefaces stylesheets. 2. Possibly you could create a custom ThemeRoller theme with essentially empty style sheets and specify that using the org.icefaces.ace.theme config. param.
Workaround Exists		[Yes]
Fix Version/s		3.2 [ 10338 ]
Fix Version/s	3.1 [ 10312 ]
Fix Version/s	3.1.0.RC1 [ 10337 ]
Assignee Priority	P2

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#30402	Tue Aug 07 14:50:15 MDT 2012	mircea.toma	~~ICE-8163~~ Modified HeadRenderer to add theme related CSS resources to the component tree before render phase. This way the resource ordering can be properly applied to all the resources that need to be rendered in the page. Added resource dependency metadata for the themes to make sure they get loaded after the component related CSS styles.
				Files Changed
				MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/META-INCLUDE/resource-dependency.xml MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/renderkit/HeadRenderer.java

Hide

Permalink

Mircea Toma added a comment - 07/Aug/12 3:50 PM - edited

Modified HeadRenderer to add theme related CSS resources to the component tree before render phase (modeled after h:outputStylesheet renderer). This way the resource ordering can be properly applied to all the resources that need to be rendered in the page. Added resource dependency metadata for the themes to make sure they get loaded after the component related CSS styles.

Show

Mircea Toma added a comment - 07/Aug/12 3:50 PM - edited Modified HeadRenderer to add theme related CSS resources to the component tree before render phase (modeled after h:outputStylesheet renderer). This way the resource ordering can be properly applied to all the resources that need to be rendered in the page. Added resource dependency metadata for the themes to make sure they get loaded after the component related CSS styles.

Mircea Toma made changes - 07/Aug/12 3:50 PM

Status	Open [ 1 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

Hide

Permalink

Mircea Toma added a comment - 07/Aug/12 3:57 PM

Modified attached test case to use h:outputStylesheet tag instead of the HTML 'link' tag, this way the resource is added to the head. Later on the resource is ordered based on the resource dependency metadata saved in WEB-INF/classes/META-INF/resource-dependency.xml file.

Show

Mircea Toma added a comment - 07/Aug/12 3:57 PM Modified attached test case to use h:outputStylesheet tag instead of the HTML 'link' tag, this way the resource is added to the head. Later on the resource is ordered based on the resource dependency metadata saved in WEB-INF/classes/META-INF/resource-dependency.xml file.

Mircea Toma made changes - 07/Aug/12 3:57 PM

Attachment

Case11246Example.fixed.zip [ 14781 ]

Ken Fyten made changes - 30/Nov/12 11:47 PM

Status

Resolved [ 5 ]

Closed [ 6 ]

People

Assignee:

Mircea Toma

Reporter:

Evgheni Sadovoi

Votes:

0 Vote for this issue

Watchers:

0 Start watching this issue

Dates

Created:

25/May/12 3:03 PM

Updated:

30/Nov/12 11:47 PM

Resolved:

07/Aug/12 3:50 PM