ICEfaces
  1. ICEfaces
  2. ICE-8070

ace:resizable resizeListener throwing JS error

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Duplicate
    • Affects Version/s: 3.0.1
    • Fix Version/s: 3.1
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      Any

      Description

      Working on ICE-7895, I noticed a Javascript error being thrown. It turned out not to be caused by the jQuery update. The bug was introduced with the ICE-7501 improvements. The wrong function is being called when supplying additional parameters to the ajax request function. In resizable.js we have the following lines of code:

          if (behaviour) {
              ice.ace.ab(ice.ace.extendAjaxArguments(
                      behaviour,
                      ice.ace.extendAjaxArguments(options))
              );
          } else ice.ace.AjaxRequest(options);

      So, ice.ace.extendAjaxArguments() is being called again and with not enough arguments. The Javascript error is thrown because an expect argument is undefined. The correct code would look like this:

          if (behaviour) {
              ice.ace.ab(ice.ace.extendAjaxArguments(
                      behaviour,
                      ice.ace.removeExecuteRenderOptions(options))
              );
          } else ice.ace.AjaxRequest(options);

      This can be reproduced with the listener demo if ace:resizable in the ICEfaces showcase app.

      This problem can also be seen in progresbar.js at two different points. Possibly this problem could also be present in other .js files, so it would be necessary to survey all files.

        Activity

        Arturo Zambrano created issue -
        Arturo Zambrano made changes -
        Field Original Value New Value
        Salesforce Case []
        Description Working on ICE-7895, I noticed a Javascript error being thrown. It turned out not to be caused by the jQuery update. The bug was introduced with the ICE-7501 improvements. The wrong function is being called when supplying additional parameters to the ajax request function. In resizable.js we have the following lines of code:

            if (behaviour) {
                ice.ace.ab(ice.ace.extendAjaxArguments(
                        behaviour,
                        ice.ace.extendAjaxArguments(options))
                );
            } else ice.ace.AjaxRequest(options);

        So, ice.ace.extendAjaxArguments() is being called again and with not enough arguments. The Javascript error is thrown because an expect argument is undefined. The correct code would look like this:

            if (behaviour) {
                ice.ace.ab(ice.ace.extendAjaxArguments(
                        behaviour,
                        ice.ace.removeExecuteRenderOptions(options))
                );
            } else ice.ace.AjaxRequest(options);

        This problem can also be seen in progresbar.js at two different points. Possibly this problem could also be present in other .js files, so it would be necessary to survey all files.
        Working on ICE-7895, I noticed a Javascript error being thrown. It turned out not to be caused by the jQuery update. The bug was introduced with the ICE-7501 improvements. The wrong function is being called when supplying additional parameters to the ajax request function. In resizable.js we have the following lines of code:

            if (behaviour) {
                ice.ace.ab(ice.ace.extendAjaxArguments(
                        behaviour,
                        ice.ace.extendAjaxArguments(options))
                );
            } else ice.ace.AjaxRequest(options);

        So, ice.ace.extendAjaxArguments() is being called again and with not enough arguments. The Javascript error is thrown because an expect argument is undefined. The correct code would look like this:

            if (behaviour) {
                ice.ace.ab(ice.ace.extendAjaxArguments(
                        behaviour,
                        ice.ace.removeExecuteRenderOptions(options))
                );
            } else ice.ace.AjaxRequest(options);

        This can be reproduced with the listener demo if ace:resizable in the ICEfaces showcase app.

        This problem can also be seen in progresbar.js at two different points. Possibly this problem could also be present in other .js files, so it would be necessary to survey all files.
        Arturo Zambrano made changes -
        Link This issue duplicates ICE-8036 [ ICE-8036 ]
        Hide
        Arturo Zambrano added a comment -

        This issue duplicates ICE-8036.

        Show
        Arturo Zambrano added a comment - This issue duplicates ICE-8036.
        Arturo Zambrano made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Duplicate [ 3 ]
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Arturo Zambrano
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: