ICEfaces
  1. ICEfaces
  2. ICE-8059

Scrollable ace:dataTable - columns become misaligned after changing Row State visibility

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: EE-3.0.0.GA, 3.1
          • Fix Version/s: 3.1.0.BETA1, 3.1, EE-3.0.0.GA_P01
          • Component/s: ACE-Components
          • Labels:
            None
          • Environment:
            Firefox, IE8, IE9
          • Assignee Priority:
            P3
          • Affects:
            Compatibility/Configuration

            Description

            When changing the visiblity of a row via its row state, the columns become misaligned in an scrollable ace:dataTable.
            1. Zip Archive
              Case11168Example.zip
              19 kB
              Arran Mccullough
            2. Zip Archive
              Case11168ExampleWAR.zip
              9.30 MB
              Arran Mccullough

              Activity

              Ascending order - Click to sort in descending order
              Arran Mccullough created issue -
              Arran Mccullough made changes -
              Field Original Value New Value
              Salesforce Case [5007000000LHfcY]
              Hide
              Permalink
              Arran Mccullough added a comment -

              Attached test case that show issue. Steps to reproduce:

              • Select a row in the table.
              • Click on the Disable Visibility For Selected button.
              • Columns become misaligned.
              Show
              Arran Mccullough added a comment - Attached test case that show issue. Steps to reproduce: Select a row in the table. Click on the Disable Visibility For Selected button. Columns become misaligned.
              Arran Mccullough made changes -
              Attachment Case11168Example.zip [ 14365 ]
              Attachment Case11168ExampleWAR.zip [ 14366 ]
              Ken Fyten made changes -
              Fix Version/s 3.1.0.BETA1 [ 10335 ]
              Fix Version/s 3.1 [ 10312 ]
              Assignee Priority P1
              Assignee Nils Lundquist [ nils.lundquist ]
              Ken Fyten made changes -
              Fix Version/s 3.1.0.BETA2 [ 10336 ]
              Fix Version/s 3.1.0.BETA1 [ 10335 ]
              Hide
              Permalink
              Nils Lundquist added a comment -

              This is due to the first row being updated as part of a dom diff effecting the entire body region of the scrollable table.

              When rows other than the first are hidden, because the diff produces enough updates to cause our diff "scope increase" optimization to kick in, the first row is updated as well, losing the sizing info that has been set on it.

              To workaround this issue resizeScrolling should be called on the client following these sorts of updates.

              Show
              Nils Lundquist added a comment - This is due to the first row being updated as part of a dom diff effecting the entire body region of the scrollable table. When rows other than the first are hidden, because the diff produces enough updates to cause our diff "scope increase" optimization to kick in, the first row is updated as well, losing the sizing info that has been set on it. To workaround this issue resizeScrolling should be called on the client following these sorts of updates.
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #29123 Fri May 18 10:41:08 MDT 2012 nils.lundquist ICE-8059 - Remove unique id from table body allowing the "dom diff scope enlargement" optimization to update the entire component region, including the script, resolving this issue.
              Files Changed
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/datatable/DataTableRenderer.java
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/datatable/datatable.js
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #29126 Fri May 18 10:50:53 MDT 2012 ken.fyten ICE-8059 - Remove unique id from table body allowing the "dom diff scope enlargement" optimization to update the entire component region, including the script, resolving this issue.
              Files Changed
              Commit graph MODIFY /icefaces3/tags/icefaces-3.1.0.BETA1/icefaces/ace/component/src/org/icefaces/ace/component/datatable/DataTableRenderer.java
              Commit graph MODIFY /icefaces3/tags/icefaces-3.1.0.BETA1/icefaces/ace/component/resources/icefaces.ace/datatable/datatable.js
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #29129 Fri May 18 11:33:22 MDT 2012 nils.lundquist ICE-8059 - Change how rows determine if they render inner divs to enable scrollable sizing. This fixes the cases where the first row of a scrollable table (containing the sizing rules) is hidden.
              Files Changed
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/datatable/DataTableRenderer.java
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/datatable/datatable.js
              Hide
              Permalink
              Nils Lundquist added a comment -

              Revision #29123
              Committed by nils.lundquist
              Moments ago
              ICE-8059 - Remove unique id from table body allowing the "dom diff scope enlargement" optimization to update the entire component region, including the script, resolving this issue.

              Show
              Nils Lundquist added a comment - Revision #29123 Committed by nils.lundquist Moments ago ICE-8059 - Remove unique id from table body allowing the "dom diff scope enlargement" optimization to update the entire component region, including the script, resolving this issue.
              Nils Lundquist made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Ken Fyten made changes -
              Fix Version/s 3.1.0.BETA1 [ 10335 ]
              Fix Version/s 3.1.0.BETA2 [ 10336 ]
              Hide
              Permalink
              Nils Lundquist added a comment -

              Revision #29129
              Committed by nils.lundquist
              Moments ago
              ICE-8059 - Change how rows determine if they render inner divs to enable scrollable sizing. This fixes the cases where the first row of a scrollable table (containing the sizing rules) is hidden.

              Show
              Nils Lundquist added a comment - Revision #29129 Committed by nils.lundquist Moments ago ICE-8059 - Change how rows determine if they render inner divs to enable scrollable sizing. This fixes the cases where the first row of a scrollable table (containing the sizing rules) is hidden.
              Hide
              Permalink
              Ken Fyten added a comment -

              Flag this as possible backward-compatibilty issue to be included in Release Notes.

              Show
              Ken Fyten added a comment - Flag this as possible backward-compatibilty issue to be included in Release Notes.
              Ken Fyten made changes -
              Affects [Compatibility/Configuration]
              Nils Lundquist made changes -
              Resolution Fixed [ 1 ]
              Status Resolved [ 5 ] Reopened [ 4 ]
              Nils Lundquist made changes -
              Comment [ Revision #29251
              Committed by nils.lundquist
              \Moments ago
              ICE-8188 - Fixed selector which was overly narrowed during refactor. ]
              Nils Lundquist made changes -
              Status Reopened [ 4 ] Closed [ 6 ]
              Resolution Fixed [ 1 ]
              Ken Fyten made changes -
              Resolution Fixed [ 1 ]
              Status Closed [ 6 ] Reopened [ 4 ]
              Assignee Priority P1 P3
              Ken Fyten made changes -
              Fix Version/s EE-3.0.0.GA_P01 [ 10327 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #29899 Tue Jul 10 11:13:51 MDT 2012 nils.lundquist ICE-8059 - Backport of trunk DataTable to maintenance branch.
              Files Changed
              Commit graph MODIFY /icefaces3/branches/icefaces-3.0.x-maintenance/icefaces/ace/component/src/org/icefaces/ace/component/datatable/DataTableRenderer.java
              Commit graph MODIFY /icefaces3/branches/icefaces-3.0.x-maintenance/icefaces/ace/component/src/org/icefaces/ace/component/datatable/DataTable.java
              Commit graph MODIFY /icefaces3/branches/icefaces-3.0.x-maintenance/icefaces/ace/component/src/org/icefaces/ace/renderkit/CoreRenderer.java
              Commit graph MODIFY /icefaces3/branches/icefaces-3.0.x-maintenance/icefaces/ace/component/src/org/icefaces/ace/component/column/ColumnMeta.java
              Commit graph MODIFY /icefaces3/branches/icefaces-3.0.x-maintenance/icefaces/ace/component/src/org/icefaces/ace/component/column/Column.java
              Commit graph MODIFY /icefaces3/branches/icefaces-3.0.x-maintenance/icefaces/ace/generator/src/org/icefaces/ace/generator/artifacts/ComponentArtifact.java
              Commit graph MODIFY /icefaces3/branches/icefaces-3.0.x-maintenance/icefaces/ace/component/resources/icefaces.ace/datatable/datatable.js
              Commit graph MODIFY /icefaces3/branches/icefaces-3.0.x-maintenance/icefaces/ace/component/src/org/icefaces/ace/component/datatable/DataTableConstants.java
              Commit graph MODIFY /icefaces3/branches/icefaces-3.0.x-maintenance/icefaces/ace/component/resources/icefaces.ace/datatable/datatable.css
              Commit graph MODIFY /icefaces3/branches/icefaces-3.0.x-maintenance/icefaces/ace/component/src/org/icefaces/ace/component/datatable/DataTableMeta.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #29907 Tue Jul 10 13:41:29 MDT 2012 nils.lundquist ICE-8059 - Aligning backported API with EE compat expectations.
              Files Changed
              Commit graph MODIFY /icefaces3/branches/icefaces-3.0.x-maintenance/icefaces/ace/component/resources/icefaces.ace/datatable/datatable.js
              Commit graph MODIFY /icefaces3/branches/icefaces-3.0.x-maintenance/icefaces/ace/component/src/org/icefaces/ace/component/datatable/DataTableMeta.java
              Hide
              Permalink
              Nils Lundquist added a comment -

              Revision #29899
              Committed by nils.lundquist
              Today
              ICE-8059 - Backport of trunk DataTable to maintenance branch.

              Revision #29907
              Committed by nils.lundquist
              ICE-8059 - Aligning backported API with EE compat expectations.

              Hid 'clickableHeaderSorting', 'toggleOnInvalidEdit', 'hiddenScrollableSizing', and 'staticHeaders' properties and reverted any defaults that may have changed since 3.0

              Tested with showcase for basic feature integrity

              Show
              Nils Lundquist added a comment - Revision #29899 Committed by nils.lundquist Today ICE-8059 - Backport of trunk DataTable to maintenance branch. Revision #29907 Committed by nils.lundquist ICE-8059 - Aligning backported API with EE compat expectations. Hid 'clickableHeaderSorting', 'toggleOnInvalidEdit', 'hiddenScrollableSizing', and 'staticHeaders' properties and reverted any defaults that may have changed since 3.0 Tested with showcase for basic feature integrity
              Nils Lundquist made changes -
              Status Reopened [ 4 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #30024 Tue Jul 17 11:47:24 MDT 2012 nils.lundquist ICE-8059 - Backport of trunk DataTable to maintenance branch. - Missed unversioned files.
              Files Changed
              Commit graph ADD /icefaces3/branches/icefaces-3.0.x-maintenance/icefaces/ace/component/src/org/icefaces/ace/util/collections/ExpressionListToValueListTransformer.java
              Commit graph ADD /icefaces3/branches/icefaces-3.0.x-maintenance/icefaces/ace/component/src/org/icefaces/ace/component/datatable/DataTableFootRenderer.java
              Commit graph ADD /icefaces3/branches/icefaces-3.0.x-maintenance/icefaces/ace/component/src/org/icefaces/ace/component/datatable/DataTableDecoder.java
              Commit graph ADD /icefaces3/branches/icefaces-3.0.x-maintenance/icefaces/ace/component/src/org/icefaces/ace/model/table/CellSelections.java
              Commit graph ADD /icefaces3/branches/icefaces-3.0.x-maintenance/icefaces/ace/component/src/org/icefaces/ace/component/datatable/DataTableHeadRenderer.java
              Commit graph ADD /icefaces3/branches/icefaces-3.0.x-maintenance/icefaces/ace/component/src/org/icefaces/ace/component/datatable/DataTableRowRenderer.java
              Commit graph ADD /icefaces3/branches/icefaces-3.0.x-maintenance/icefaces/ace/component/src/org/icefaces/ace/component/datatable/DataTableRendererUtil.java
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Nils Lundquist
                  Reporter:
                  Arran Mccullough
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: