ICEfaces
  1. ICEfaces
  2. ICE-8000

PanelPositioned renders a visible xml comment containing a random number

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: EE-1.8.2.GA_P03
    • Fix Version/s: EE-1.8.2.GA_P04
    • Component/s: ICE-Components
    • Labels:
      None
    • Environment:
      Chrome, IE

      Description

      The PanelPositioned component renders a visible xml comment containing a random number. The rendered comment only appears visible on some browsers, such as Chrome and IE, but not others, such as Firefox. The xml comment is being rendered in the following section of PanelPositionedRenderer:

                   if (isChanged(facesContext)) {
                          // Force the re rendering of the entire component. This is due to a strange quick with positioned
                          // panel. When an element is moved in the same list then it container element moves with it
                          // When the update occurs the elements are replaced but because the containers have moved
                          // then the result looks the same. (But a refresh shows otherwise)
                          Node node = domContext.createTextNode(
                                  "<!-- " + (new Random().nextInt(1000)) + "-->");
                          root.appendChild(node);
                      }

        Issue Links

          Activity

          Philip Breau created issue -
          Hide
          Philip Breau added a comment -

          screen shot showing the ee comps richTabs (which uses the panelPositioned) rendering the visible xml comment

          Show
          Philip Breau added a comment - screen shot showing the ee comps richTabs (which uses the panelPositioned) rendering the visible xml comment
          Philip Breau made changes -
          Field Original Value New Value
          Attachment richTabs.png [ 14283 ]
          Philip Breau made changes -
          Link This issue blocks IPCK-396 [ IPCK-396 ]
          Hide
          Philip Breau added a comment -

          blocks ipck-396

          Show
          Philip Breau added a comment - blocks ipck-396
          Hide
          Philip Breau added a comment -

          blocks ipck-396

          Show
          Philip Breau added a comment - blocks ipck-396
          Philip Breau made changes -
          Assignee Deryk Sinotte [ deryk.sinotte ]
          Philip Breau made changes -
          Environment n/a Chrome, IE
          Salesforce Case []
          Description The PanelPositioned component renders a visible xml comment containing a random number. Coming from this code in PanelPositionedRenderer:

                       if (isChanged(facesContext)) {
                              // Force the re rendering of the entire component. This is due to a strange quick with positioned
                              // panel. When an element is moved in the same list then it container element moves with it
                              // When the update occurs the elements are replaced but because the containers have moved
                              // then the result looks the same. (But a refresh shows otherwise)
                              Node node = domContext.createTextNode(
                                      "<!-- " + (new Random().nextInt(1000)) + "-->");
                              root.appendChild(node);
                          }
          The PanelPositioned component renders a visible xml comment containing a random number. The rendered comment only appears visible on some browsers, such as Chrome and IE, but not others, such as Firefox. The xml comment is being rendered in the following section of PanelPositionedRenderer:

                       if (isChanged(facesContext)) {
                              // Force the re rendering of the entire component. This is due to a strange quick with positioned
                              // panel. When an element is moved in the same list then it container element moves with it
                              // When the update occurs the elements are replaced but because the containers have moved
                              // then the result looks the same. (But a refresh shows otherwise)
                              Node node = domContext.createTextNode(
                                      "<!-- " + (new Random().nextInt(1000)) + "-->");
                              root.appendChild(node);
                          }
          Hide
          Deryk Sinotte added a comment -

          Assigning to Art to take a look at.

          Show
          Deryk Sinotte added a comment - Assigning to Art to take a look at.
          Deryk Sinotte made changes -
          Salesforce Case []
          Assignee Priority P1
          Assignee Deryk Sinotte [ deryk.sinotte ] Arturo Zambrano [ artzambrano ]
          Deryk Sinotte made changes -
          Salesforce Case []
          Fix Version/s EE-1.8.2.GA_P04 [ 10280 ]
          Hide
          Deryk Sinotte added a comment -

          Just wanted to mention that I see this happening on the portlet version also.

          Show
          Deryk Sinotte added a comment - Just wanted to mention that I see this happening on the portlet version also.
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #28650 Mon Apr 09 12:14:32 MDT 2012 art.zambrano ICE-8000 unescaped text node containing XML comment with random number in order to prevent it from being displayed on the browser
          Files Changed
          Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/panelpositioned/PanelPositionedRenderer.java
          Hide
          Arturo Zambrano added a comment -

          Committed fix at revision 28650.

          Just needed to create an unescaped text node for the XMLcomment.

          Show
          Arturo Zambrano added a comment - Committed fix at revision 28650. Just needed to create an unescaped text node for the XMLcomment.
          Arturo Zambrano made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Ken Fyten made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Assignee Priority P1

            People

            • Assignee:
              Arturo Zambrano
              Reporter:
              Philip Breau
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: