ICEfaces
  1. ICEfaces
  2. ICE-7989

Hanging Session Monitor thread upon shutdown or redeploy

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: EE-1.8.2.GA_P03
          • Fix Version/s: EE-1.8.2.GA_P04
          • Component/s: Framework
          • Labels:
            None
          • Environment:
            ICEfaces

            Description

            This issue is related to ICE-6967 and deals with the Session Monitor thread.

              Issue Links

              blocks

              Bug - A problem which impairs or prevents the functions of the product. ICE-6967 Hanging threads upon shutdown or undeploy

              • Major - Major loss of function.
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #28628 Tue Apr 03 14:54:50 MDT 2012 jack.van.ooststroom Fixed JIRA ICE-7989 : Hanging Session Monitor thread upon shutdown or redeploy
                Files Changed
                Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/webapp/http/servlet/SessionDispatcher.java
                Jack Van Ooststroom created issue -
                Jack Van Ooststroom made changes -
                Field Original Value New Value
                Assignee Jack van Ooststroom [ jack.van.ooststroom ]
                Jack Van Ooststroom made changes -
                Link This issue blocks ICE-6967 [ ICE-6967 ]
                Hide
                Permalink
                Jack Van Ooststroom added a comment -

                Sending src/com/icesoft/faces/webapp/http/servlet/SessionDispatcher.java
                Transmitting file data .
                Committed revision 28628.

                Show
                Jack Van Ooststroom added a comment - Sending src/com/icesoft/faces/webapp/http/servlet/SessionDispatcher.java Transmitting file data . Committed revision 28628.
                Hide
                Permalink
                Jack Van Ooststroom added a comment -

                The logic in the spawned thread was being executed every interval ms using a Thread.sleep(). Setting the run boolean to false while shutting down, didn't necessarily mean the thread got stopped before Tomcat completed the shutdown, hence the warning. When the run boolean is set to false, it now tries to join the spawned thread with a timeout of 1000ms. In addition the logic is still executed every interval ms, but the loop is "interrupted" every 1s to check to see if the run boolean is still set to true. This avoids the join logic to take up interval ms. Marking this one as FIXED.

                Show
                Jack Van Ooststroom added a comment - The logic in the spawned thread was being executed every interval ms using a Thread.sleep(). Setting the run boolean to false while shutting down, didn't necessarily mean the thread got stopped before Tomcat completed the shutdown, hence the warning. When the run boolean is set to false, it now tries to join the spawned thread with a timeout of 1000ms. In addition the logic is still executed every interval ms, but the loop is "interrupted" every 1s to check to see if the run boolean is still set to true. This avoids the join logic to take up interval ms. Marking this one as FIXED.
                Jack Van Ooststroom made changes -
                Status Open [ 1 ] Resolved [ 5 ]
                Resolution Fixed [ 1 ]
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #28656 Tue Apr 10 08:57:18 MDT 2012 jack.van.ooststroom Fixed JIRA ICE-7989 : Hanging Session Monitor thread upon shutdown or redeploy - Increased the thread join timeout
                Files Changed
                Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/webapp/http/servlet/SessionDispatcher.java
                Hide
                Permalink
                Jack Van Ooststroom added a comment -

                Sending core/src/com/icesoft/faces/webapp/http/servlet/SessionDispatcher.java
                Transmitting file data .
                Committed revision 28656.

                Show
                Jack Van Ooststroom added a comment - Sending core/src/com/icesoft/faces/webapp/http/servlet/SessionDispatcher.java Transmitting file data . Committed revision 28656.
                Ken Fyten made changes -
                Status Resolved [ 5 ] Closed [ 6 ]

                  People

                  • Assignee:
                    Jack Van Ooststroom
                    Reporter:
                    Jack Van Ooststroom
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    0 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: