ICEfaces
  1. ICEfaces
  2. ICE-7855

Patch myfaces 2.1.6 jar until Apache change is made for MYFACES-3489

          Details

          • Type: Task Task
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: EE-3.0.0.BETA
          • Fix Version/s: EE-3.0.0.GA
          • Component/s: Framework
          • Labels:
            None
          • Environment:
            WebSphere Portal + Myfaces 2.1.6 + ICEFaces 3 EE beta
          • Affects:
            Documentation (User Guide, Ref. Guide, etc.), Sample App./Tutorial, Compatibility/Configuration
          • Workaround Exists:
            Yes
          • Workaround Description:
            Need to use modified MyFaces 2.1.6 jars provided by ICEsoft

            Description

            There's a bug in the Myfaces ExternalContextUtils.java class which prevents it from detecting the type of request in portal 20 environments. A jira with myfaces has been created here: https://issues.apache.org/jira/browse/MYFACES-3489. We will need to create a local version of the myfaces jars until a fixed version has been released.

              Issue Links

              blocks

              Improvement - An improvement or enhancement to an existing feature or task. ICE-7926 Patches applied to Myfaces 2.1.6

              • Major - Major loss of function.
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #28168 Mon Mar 05 15:50:30 MST 2012 deryk.sinotte ICE-7855: modified MyFaces jar to patch issue in 2.1.6
                Files Changed
                Commit graph ADD /icefaces3/trunk/icefaces/lib/myfaces/myfaces-impl-2.1.6-ice-7855.jar
                Commit graph DEL /icefaces3/trunk/icefaces/lib/myfaces/myfaces-api-2.1.6.jar
                Commit graph ADD /icefaces3/trunk/icefaces/lib/myfaces/myfaces-api-2.1.6-ice-7855.jar
                Commit graph DEL /icefaces3/trunk/icefaces/lib/myfaces/myfaces-impl-2.1.6.jar
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #28169 Mon Mar 05 15:57:35 MST 2012 deryk.sinotte ICE-7855: modified MyFaces jar to patch issue in 2.1.6
                Files Changed
                Commit graph DEL /icefaces3/branches/icefaces-3.0.x-maintenance/icefaces/lib/myfaces/myfaces-api-2.1.6.jar
                Commit graph ADD /icefaces3/branches/icefaces-3.0.x-maintenance/icefaces/lib/myfaces/myfaces-impl-2.1.6-ice-7855.jar
                Commit graph DEL /icefaces3/branches/icefaces-3.0.x-maintenance/icefaces/lib/myfaces/myfaces-impl-2.1.6.jar
                Commit graph ADD /icefaces3/branches/icefaces-3.0.x-maintenance/icefaces/lib/myfaces/myfaces-api-2.1.6-ice-7855.jar
                Greg Dick created issue -
                Hide
                Permalink
                Deryk Sinotte added a comment -

                Checked in a custom built version of MyFaces 2.1.6 libs that contain the following patch:

                Index: shared/src/main/java/org/apache/myfaces/shared/util/ExternalContextUtils.java
                ===================================================================
                — shared/src/main/java/org/apache/myfaces/shared/util/ExternalContextUtils.java (revision 1244660)
                +++ shared/src/main/java/org/apache/myfaces/shared/util/ExternalContextUtils.java (working copy)
                @@ -126,7 +126,7 @@
                // performance. We want to do as few instanceof's as possible so
                // things are laid out according to the expected frequency of the
                // various requests occurring.

                • if(_PORTLET_10_SUPPORTED)
                  + if(_PORTLET_10_SUPPORTED || _PORTLET_20_SUPPORTED)
                  {
                  if (_PORTLET_CONTEXT_CLASS.isInstance(ec.getContext()))
                  {
                Show
                Deryk Sinotte added a comment - Checked in a custom built version of MyFaces 2.1.6 libs that contain the following patch: Index: shared/src/main/java/org/apache/myfaces/shared/util/ExternalContextUtils.java =================================================================== — shared/src/main/java/org/apache/myfaces/shared/util/ExternalContextUtils.java (revision 1244660) +++ shared/src/main/java/org/apache/myfaces/shared/util/ExternalContextUtils.java (working copy) @@ -126,7 +126,7 @@ // performance. We want to do as few instanceof's as possible so // things are laid out according to the expected frequency of the // various requests occurring. if(_PORTLET_10_SUPPORTED) + if(_PORTLET_10_SUPPORTED || _PORTLET_20_SUPPORTED) { if (_PORTLET_CONTEXT_CLASS.isInstance(ec.getContext())) {
                Deryk Sinotte made changes -
                Field Original Value New Value
                Workaround Description Need to use modified MyFaces 2.1.6 jars provided by ICEsoft
                Workaround Exists [Yes]
                Salesforce Case []
                Component/s Framework [ 10013 ]
                Fix Version/s EE-3.0.0.GA [ 10262 ]
                Affects [Documentation (User Guide, Ref. Guide, etc.), Sample App./Tutorial, Compatibility/Configuration]
                Assignee Priority P1
                Assignee Deryk Sinotte [ deryk.sinotte ]
                Hide
                Permalink
                Deryk Sinotte added a comment -

                The modified libs have been checked into both the trunk and the maintenance branch.

                Show
                Deryk Sinotte added a comment - The modified libs have been checked into both the trunk and the maintenance branch.
                Deryk Sinotte made changes -
                Status Open [ 1 ] Resolved [ 5 ]
                Resolution Fixed [ 1 ]
                Hide
                Permalink
                Greg Dick added a comment -

                I got notification that MYFACES-3489 has been fixed as of 6 March 2012

                Show
                Greg Dick added a comment - I got notification that MYFACES-3489 has been fixed as of 6 March 2012
                Deryk Sinotte made changes -
                Link This issue blocks ICE-7926 [ ICE-7926 ]
                Ken Fyten made changes -
                Status Resolved [ 5 ] Closed [ 6 ]
                Assignee Priority P1

                  People

                  • Assignee:
                    Deryk Sinotte
                    Reporter:
                    Greg Dick
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    0 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: