ICEfaces
  1. ICEfaces
  2. ICE-7853

ace:dataTable - Columns become misasligned when turning off pagination on a scrollable table

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 3.0
          • Fix Version/s: 3.0.1, EE-3.0.0.GA
          • Component/s: ACE-Components
          • Labels:
            None
          • Environment:
            Firefox, IE8, IE9
          • Workaround Exists:
            Yes
          • Workaround Description:
            Use a value binding for the page attribute and manually set the page to the first page (1).

            Description

            An ace:dataTable is set to be scrollable and do pagination. The paginator can be toggled on and off. If a user navigates to the any page other than the first one and then turns pagination off, the columns become misaligned. If pagination is then turned on, the columns become aligned. If the page is set to the first page and pagination is turned off then the columns stay aligned.

              Activity

              Ascending order - Click to sort in descending order
              Arran Mccullough created issue -
              Hide
              Permalink
              Arran Mccullough added a comment - - edited

              Test case that shows issue. Steps:

              • Load noHeaderGroup.jsf
              • Click on Toggle Pagination button.
              • Select the second page.
              • Click on Toggle Pagination button to turn off pagination.
              • Columns are now misaligned.
              Show
              Arran Mccullough added a comment - - edited Test case that shows issue. Steps: Load noHeaderGroup.jsf Click on Toggle Pagination button. Select the second page. Click on Toggle Pagination button to turn off pagination. Columns are now misaligned.
              Arran Mccullough made changes -
              Field Original Value New Value
              Attachment Case10648Example.zip [ 14132 ]
              Attachment Case10648Example.war [ 14133 ]
              Arran Mccullough made changes -
              Salesforce Case [5007000000JMQUL]
              Arran Mccullough made changes -
              Assignee Nils Lundquist [ nils.lundquist ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #28164 Mon Mar 05 14:33:38 MST 2012 nils.lundquist ICE-7853 - Force pagination reset when pagination disabled.
              Files Changed
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/datatable/DataTable.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #28165 Mon Mar 05 14:36:21 MST 2012 nils.lundquist ICE-7853 - Force pagination reset when pagination disabled
              Files Changed
              Commit graph MODIFY /icefaces3/branches/icefaces-3.0.x-maintenance/icefaces/ace/component/src/org/icefaces/ace/component/datatable/DataTable.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #28166 Mon Mar 05 14:38:17 MST 2012 nils.lundquist ICE-7853 - Force pagination reset when pagination disabled. - Missed @Override
              Files Changed
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/datatable/DataTable.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #28167 Mon Mar 05 14:39:14 MST 2012 nils.lundquist ICE-7853 - Force pagination reset when pagination disabled - Missed @Override
              Files Changed
              Commit graph MODIFY /icefaces3/branches/icefaces-3.0.x-maintenance/icefaces/ace/component/src/org/icefaces/ace/component/datatable/DataTable.java
              Arran Mccullough made changes -
              Workaround Description Use a value binding for the page attribute and manually set the page to the first page (1).
              Workaround Exists [Yes]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #28178 Mon Mar 05 19:21:27 MST 2012 nils.lundquist ICE-7853 - Changed first row calculation to handle case where pagination is disabled without resetting the page variable.
              Files Changed
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/datatable/DataTable.java
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/datatable/DataTableRenderer.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #28179 Mon Mar 05 19:28:01 MST 2012 nils.lundquist ICE-7853 - Simplified first row calculation to handle case where pagination is disabled without resetting the page variable.
              Files Changed
              Commit graph MODIFY /icefaces3/branches/icefaces-3.0.x-maintenance/icefaces/ace/component/src/org/icefaces/ace/component/datatable/DataTableRenderer.java
              Commit graph MODIFY /icefaces3/branches/icefaces-3.0.x-maintenance/icefaces/ace/component/src/org/icefaces/ace/component/datatable/DataTable.java
              Hide
              Permalink
              Nils Lundquist added a comment -

              The commit I made regarding this issue assumed they were setting the pagination via table.setPaginator rather than by altering the value binding.

              My changing the setter is fruitless as it is never called when the value binding is changed. The alternative, other than working around this at the app level, is to fix the underlying issue, or alter the getter for the 'paginator' boolean. Altering the getter is easier but would disable anyone from moving the 'first' row of the data model by any means other than our paginator..

              Show
              Nils Lundquist added a comment - The commit I made regarding this issue assumed they were setting the pagination via table.setPaginator rather than by altering the value binding. My changing the setter is fruitless as it is never called when the value binding is changed. The alternative, other than working around this at the app level, is to fix the underlying issue, or alter the getter for the 'paginator' boolean. Altering the getter is easier but would disable anyone from moving the 'first' row of the data model by any means other than our paginator..
              Hide
              Permalink
              Nils Lundquist added a comment -

              This has to do with an interaction of scolling resizing javascript and render logic to determine the first row of the datatable interacting with pagination.

              Show
              Nils Lundquist added a comment - This has to do with an interaction of scolling resizing javascript and render logic to determine the first row of the datatable interacting with pagination.
              Ken Fyten made changes -
              Fix Version/s EE-3.0.0.GA [ 10262 ]
              Fix Version/s 3.0.1 [ 10282 ]
              Affects Version/s 3.0 [ 10241 ]
              Affects Version/s EE-3.0.0.BETA [ 10324 ]
              Hide
              Permalink
              Nils Lundquist added a comment -

              Revision #28178
              Committed by nils.lundquist
              Yesterday 7:21 PM
              ICE-7853 - Changed first row calculation to handle case where pagination is disabled without resetting the page variable.

              Show
              Nils Lundquist added a comment - Revision #28178 Committed by nils.lundquist Yesterday 7:21 PM ICE-7853 - Changed first row calculation to handle case where pagination is disabled without resetting the page variable.
              Nils Lundquist made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Nils Lundquist
                  Reporter:
                  Arran Mccullough
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: