ICEfaces
  1. ICEfaces
  2. ICE-7816

Optimization - Add a wrapping div to ACE components to prevent the entire form to be updated

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.0
    • Fix Version/s: 3.1.0.RC1, 3.1
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      Any
    • Assignee Priority:
      P3

      Description

      Some ACE components' script tags are rendered outside of a container that has a client id. With our DOM diff mechanism, this causes the entire form to be updated whenever the component is updated. Therefore, when the form has too many contents, every update seems slow. It is necessary to prevent this from happening by rendering a div with a client id that wraps the original markup and the script tag. This situation had already been documented for the ace:dialog component in ICE-7755.

      A quick survey revealed that the following components may present this situation:
      accordion
      confirmationDialog
      dataExporter
      dateTimeEntry
      draggable, droppable
      maskedEntry
      menu components
      notificationPanel
      panel
      printer
      progressBar
      slider

        Activity

        Arturo Zambrano created issue -
        Ken Fyten made changes -
        Field Original Value New Value
        Summary Add a wrapping div to ACE components that cause the entire form to be updated Optimization - Add a wrapping div to ACE components that cause the entire form to be updated
        Salesforce Case []
        Fix Version/s 3.1 [ 10312 ]
        Hide
        Ted Goddard added a comment -

        If a subtree render is invoked via f:ajax, the DOM subtree will be looked up by client ID, so the clientID on the containing element of the component must be exactly the client ID of the component.

        Show
        Ted Goddard added a comment - If a subtree render is invoked via f:ajax, the DOM subtree will be looked up by client ID, so the clientID on the containing element of the component must be exactly the client ID of the component.
        Ken Fyten made changes -
        Salesforce Case []
        Fix Version/s 3.1.0.RC1 [ 10337 ]
        Assignee Arturo Zambrano [ artzambrano ]
        Ken Fyten made changes -
        Salesforce Case []
        Assignee Priority P3
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #29477 Tue Jun 12 15:55:17 MDT 2012 art.zambrano ICE-7816 wrapped all <script> tags and other elements inside a root container to avoid full-form dynamic updates
        Files Changed
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/sliderentry/SliderEntryRenderer.java
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/panel/PanelRenderer.java
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/notificationpanel/NotificationPanelRenderer.java
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/printer/PrinterRenderer.java
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/dnd/DroppableRenderer.java
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/confirmationdialog/ConfirmationDialogRenderer.java
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/dataexporter/DataExporterRenderer.java
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/accordion/AccordionRenderer.java
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/progressbar/ProgressBarRenderer.java
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/dnd/DraggableRenderer.java
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/maskedentry/MaskedEntryRenderer.java
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/datetimeentry/DateTimeEntryRenderer.java
        Hide
        Arturo Zambrano added a comment -

        Committed fix for all the above components at revision 29477.

        Menu components had already been fixed as part of ICE-8241.

        Show
        Arturo Zambrano added a comment - Committed fix for all the above components at revision 29477. Menu components had already been fixed as part of ICE-8241 .
        Ken Fyten made changes -
        Summary Optimization - Add a wrapping div to ACE components that cause the entire form to be updated Optimization - Add a wrapping div to ACE components to prevent the entire form to be updated
        Salesforce Case []
        Arturo Zambrano made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #29689 Tue Jun 26 12:55:33 MDT 2012 art.zambrano ICE-8280 reverted improvement made in ICE-7816, since it's not really necessary for ace:dataExporter
        Files Changed
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/dataexporter/DataExporterRenderer.java
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Arturo Zambrano
            Reporter:
            Arturo Zambrano
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: